CreateImportForMediaGroupDataTransferObject::add() - Code Metrics - forkcms/fork-cms-module-media-library-importer - Measure and Improve Code Quality continuously with Scrutinizer

CreateImportForMediaGroupDataTransferObject::add() A
last analyzed 2018-04-16 14:12 UTC

↳ Parent: CreateImportForMediaGroupDataTransferObject

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	1

<?php

namespace Backend\Modules\MediaLibraryImporter\Domain\MediaGroupImport\Command\Base;

use Backend\Modules\MediaLibrary\Domain\MediaGroup\MediaGroup;
use Backend\Modules\MediaLibrary\Domain\MediaGroup\Type;
use Backend\Modules\MediaLibraryImporter\Domain\MediaItemImport\MediaItemImportDataTransferObject;

class CreateImportForMediaGroupDataTransferObject
{
    /** @var MediaGroup|null */
    private $mediaGroupEntity;

    /** @var array|MediaItemImportDataTransferObject[] */
    public $mediaItemImportDataTransferObjects = [];

    /** @var Type */
    public $type;

    public function __construct(MediaGroup $mediaGroup = null)
    {
        $this->mediaGroupEntity = $mediaGroup;

        if (!$this->hasExistingMediaGroup()) {
            return;
        }

        $this->type = $mediaGroup->getType();
    }

    public function add(MediaItemImportDataTransferObject $mediaItemImportDataTransferObject): void
    {
        if ($this->hasExistingMediaGroup()) {
            $mediaItemImportDataTransferObject->setMediaGroup($this->mediaGroupEntity);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
        }

        $this->mediaItemImportDataTransferObjects[] = $mediaItemImportDataTransferObject;
    }

    public function getMediaGroupEntity(): MediaGroup
    {
        return $this->mediaGroupEntity;
    }

    public function hasExistingMediaGroup(): bool
    {
        return $this->mediaGroupEntity instanceof MediaGroup;
    }

    public function setMediaGroupEntity(MediaGroup $mediaGroup): void
    {
        $this->mediaGroupEntity = $mediaGroup;
    }
}


1			<?php
2
3			namespace Backend\Modules\MediaLibraryImporter\Domain\MediaGroupImport\Command\Base;
4
5			use Backend\Modules\MediaLibrary\Domain\MediaGroup\MediaGroup;
6			use Backend\Modules\MediaLibrary\Domain\MediaGroup\Type;
7			use Backend\Modules\MediaLibraryImporter\Domain\MediaItemImport\MediaItemImportDataTransferObject;
8
9			class CreateImportForMediaGroupDataTransferObject
10			{
11			/** @var MediaGroup\|null */
12			private $mediaGroupEntity;
13
14			/** @var array\|MediaItemImportDataTransferObject[] */
15			public $mediaItemImportDataTransferObjects = [];
16
17			/** @var Type */
18			public $type;
19
20			public function __construct(MediaGroup $mediaGroup = null)
21			{
22			$this->mediaGroupEntity = $mediaGroup;
23
24			if (!$this->hasExistingMediaGroup()) {
25			return;
26			}
27
28			$this->type = $mediaGroup->getType();
29			}
30
31			public function add(MediaItemImportDataTransferObject $mediaItemImportDataTransferObject): void
32			{
33			if ($this->hasExistingMediaGroup()) {
34			$mediaItemImportDataTransferObject->setMediaGroup($this->mediaGroupEntity);
			0 ignored issues – show Bug introduced 2017-04-18 09:24 UTC by Report Bug Copy Issue Report It seems like `$this->mediaGroupEntity` can be `null`; however, `setMediaGroup()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
35			}
36
37			$this->mediaItemImportDataTransferObjects[] = $mediaItemImportDataTransferObject;
38			}
39
40			public function getMediaGroupEntity(): MediaGroup
41			{
42			return $this->mediaGroupEntity;
43			}
44
45			public function hasExistingMediaGroup(): bool
46			{
47			return $this->mediaGroupEntity instanceof MediaGroup;
48			}
49
50			public function setMediaGroupEntity(MediaGroup $mediaGroup): void
51			{
52			$this->mediaGroupEntity = $mediaGroup;
53			}
54			}
55

forkcms / fork-cms-module-media-library-importer

CreateImportForMediaGroupDataTransferObject::add() A last analyzed 2018-04-16 14:12 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

CreateImportForMediaGroupDataTransferObject::add() A
last analyzed 2018-04-16 14:12 UTC