UserBetting::isSaveFormInValid() - Code Metrics - Inspection of "Fix Complexity" - football-betting/symfony4 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( fa97fb...0ef4e9 )

by Rafal

created 2018-07-01 21:10 UTC

UserBetting::isSaveFormInValid() B

↳ Parent: UserBetting

Complexity

Conditions	7
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
nc	4
nop	2
dl	0
loc	12
rs	8.8333
c	0
b	0
f	0

<?php

namespace App\GameBetting\Communication\Controller;


use App\GameBetting\Business\Form\UserBettingType;
use App\GameBetting\Business\Games\UserFutureGamesInterface;
use App\GameBetting\Business\Games\UserPastGamesInterface;
use App\GameBetting\Persistence\Entity\UserBetting as UserBettingEntity;
use App\GameCore\Persistence\Entity\Game;
use App\GameCore\Persistence\Repository\GameRepository;
use App\User\Persistence\Entity\User;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Routing\Annotation\Route;

class UserBetting extends Controller
{
    /**
     * @var UserFutureGamesInterface
     */
    private $userFutureGames;

    /**
     * @var UserPastGamesInterface
     */
    private $userPastGames;

    /**
     * @param UserFutureGamesInterface $userFutureGames
     * @param UserPastGamesInterface $userPastGames
     */
    public function __construct(UserFutureGamesInterface $userFutureGames, UserPastGamesInterface $userPastGames)
    {
        $this->userFutureGames = $userFutureGames;
        $this->userPastGames = $userPastGames;
    }

    /**
     * @TODO template struktur überarbeiten und eigene actions machen
     * @Route("/gamebet/", name="game_bet_list")
     */
    public function list()
    {
        $futureGamesFormBuilder = $this->getFutureGamesFormBuilder();
        $pastGamesForm = $this->userPastGames->get($this->getUser());

        return $this->render(
            'gamebetting/betting/betting.html.twig',
            [
                'futureGamesForm' => $futureGamesFormBuilder,
                'pastGamesForm' => \array_reverse(\array_slice($pastGamesForm, -6))
            ]
        );
    }

    /**
     * @Route("/active-games/", name="active-games")
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function getActiveGames()
    {
        $activeGames = $this->userPastGames->getActiveGames($this->getUser());

        return $this->render(
            'gamebetting/betting/active_games.html.twig',
            [
                'activeGames' => $activeGames
            ]
        );
    }

    /**
     * @Route("/all-upcomming-games", name="all_upcomming_games")
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function allUpcommingGames()
    {
        $futureGamesFormBuilder = $this->getFutureGamesFormBuilder();

        return $this->render(
            'gamebetting/betting/all_games.html.twig',
            [
                'futureGamesForm' => $futureGamesFormBuilder
            ]
        );
    }

    /**
     * @Route("/all-past-games", name="all_past_games")
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function allPastGames()
    {
        $pastGamesForm = $this->userPastGames->get($this->getUser());

        return $this->render(
            'gamebetting/betting/past_games.html.twig',
            [
                'pastGamesForm' => $pastGamesForm,
                'username' => false
            ]
        );
    }

    /**
     * toDo Refactor this
     * @Route("/past-game-detail/{gameId}", name="past_game_detail")
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function pastGameDetail(int $gameId)
    {
        $users = $this->getDoctrine()->getRepository(User::class)
            ->findBy([], ['username' => 'ASC']);

        $teamFirstName = '';
        $teamSecondName = '';
        $gameInfo2users = [];
        foreach ($users as $user) {
            $pastGamesForm = $this->userPastGames->getOnePastGame($user, $gameId);
            if (!empty($pastGamesForm)) {
                $teamFirstName = current($pastGamesForm)->getFirstTeamName();
                $teamSecondName = current($pastGamesForm)->getSecondTeamName();

                $gameInfo2users[$user->getUsername()] = current($pastGamesForm);
            }

        }

        return $this->render(
            'gamebetting/betting/past_game_detail.html.twig',
            [
                'gameInfo2users' => $gameInfo2users,
                'teamFirstName' => $teamFirstName,
                'teamSecondName' => $teamSecondName,
            ]
        );
    }

    /**
     * @Route("/all-past-games-by-user/{userId}", name="game_past_games_by_users")
     */
    public function allPastGameByUserId(int $userId)
    {
        $user = $this->getDoctrine()->getRepository(User::class)
            ->findOneBy(['id' => $userId]);
        $pastGamesForm = [];
        $username = '';
        if ($user instanceof User) {
            $pastGamesForm = $this->userPastGames->get($user);
            $username = $user->getUsername();
        }

        return $this->render(
            'gamebetting/betting/past_games.html.twig',
            [
                'pastGamesForm' => $pastGamesForm,
                'username' => $username
            ]
        );

    }

    public function getNextGames(int $numberOfGames)
    {
        $gameBetResult = \array_slice($this->userFutureGames->get($this->getUser()), 0, $numberOfGames);

        return $this->render(
            'dashboard/next_games.html.twig',
            [
                'gameBetResult' => $gameBetResult
            ]
        );
    }

    /**
     * @Route("/savebet", name="save_bet")
     * @Method({"POST"})
     */
    public function saveBet(Request $request)
    {
        $params = (array)$request->get('user_betting');
        $userBetting = new UserBettingEntity();
        $form = $this->createForm(UserBettingType::class, $userBetting);
        $form->handleRequest($request);

        if ($this->isSaveFormInValid($form, $params) === true) {
            return $this->json(['status' => false]);
        }

        $entityManager = $this->getDoctrine()->getManager();
        $userBetting = $entityManager->getRepository(UserBettingEntity::class)
            ->findByGameIdAndUserId($params['gameId'], $this->getUser()->getId());
        if (!$userBetting instanceof UserBettingEntity) {
            $userBetting = new UserBettingEntity();
            $game = $entityManager->getRepository(Game::class)
                ->find($params['gameId']);
            $userBetting->setGame($game);
            $userBetting->setUser($this->getUser());
        }


        $userBetting->setFirstTeamResult((int)$params['firstTeamResult']);
        $userBetting->setSecondTeamResult((int)$params['secondTeamResult']);

        if ($userBetting->getGame()->getDate()->getTimestamp() < time()) {
            return $this->json(['status' => false]);
        }

        $entityManager->persist($userBetting);
        $entityManager->flush();

        return $this->json(['status' => true]);
    }

    /**
     * @param $form
     * @param array $params
     * @return bool
     */
    private function isSaveFormInValid($form, array $params) : bool
    {
        $isFromInValid = false;
        if (!$form->isSubmitted() && !$form->isValid()) {
            $isFromInValid = true;
        } else if (!isset($params['firstTeamResult']) || $params['firstTeamResult'] < 0) {
            $isFromInValid = true;
        } else if (!isset($params['secondTeamResult']) || $params['secondTeamResult'] < 0) {
            $isFromInValid = true;
        }

        return $isFromInValid;
    }

    /**
     * @return array
     */
    private function getFutureGamesFormBuilder(): array
    {
        $userFurureGames = $this->userFutureGames->get(
            $this->getUser()
        );
        $gamesFormBuilder = [];
        foreach ($userFurureGames as $gameId => $futureGameInfo) {
            $gamesFormBuilder[$gameId] = $this->createForm(
                UserBettingType::class, null, $futureGameInfo
            )->createView();
        }
        return $gamesFormBuilder;
    }
}

1			<?php
2
3			namespace App\GameBetting\Communication\Controller;
4
5
6			use App\GameBetting\Business\Form\UserBettingType;
7			use App\GameBetting\Business\Games\UserFutureGamesInterface;
8			use App\GameBetting\Business\Games\UserPastGamesInterface;
9			use App\GameBetting\Persistence\Entity\UserBetting as UserBettingEntity;
10			use App\GameCore\Persistence\Entity\Game;
11			use App\GameCore\Persistence\Repository\GameRepository;
12			use App\User\Persistence\Entity\User;
13			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
14			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
15			use Symfony\Component\HttpFoundation\Request;
16			use Symfony\Component\Routing\Annotation\Route;
17
18			class UserBetting extends Controller
19			{
20			/**
21			* @var UserFutureGamesInterface
22			*/
23			private $userFutureGames;
24
25			/**
26			* @var UserPastGamesInterface
27			*/
28			private $userPastGames;
29
30			/**
31			* @param UserFutureGamesInterface $userFutureGames
32			* @param UserPastGamesInterface $userPastGames
33			*/
34			public function __construct(UserFutureGamesInterface $userFutureGames, UserPastGamesInterface $userPastGames)
35			{
36			$this->userFutureGames = $userFutureGames;
37			$this->userPastGames = $userPastGames;
38			}
39
40			/**
41			* @TODO template struktur überarbeiten und eigene actions machen
42			* @Route("/gamebet/", name="game_bet_list")
43			*/
44			public function list()
45			{
46			$futureGamesFormBuilder = $this->getFutureGamesFormBuilder();
47			$pastGamesForm = $this->userPastGames->get($this->getUser());
48
49			return $this->render(
50			'gamebetting/betting/betting.html.twig',
51			[
52			'futureGamesForm' => $futureGamesFormBuilder,
53			'pastGamesForm' => \array_reverse(\array_slice($pastGamesForm, -6))
54			]
55			);
56			}
57
58			/**
59			* @Route("/active-games/", name="active-games")
60			* @return \Symfony\Component\HttpFoundation\Response
61			*/
62			public function getActiveGames()
63			{
64			$activeGames = $this->userPastGames->getActiveGames($this->getUser());
65
66			return $this->render(
67			'gamebetting/betting/active_games.html.twig',
68			[
69			'activeGames' => $activeGames
70			]
71			);
72			}
73
74			/**
75			* @Route("/all-upcomming-games", name="all_upcomming_games")
76			* @return \Symfony\Component\HttpFoundation\Response
77			*/
78			public function allUpcommingGames()
79			{
80			$futureGamesFormBuilder = $this->getFutureGamesFormBuilder();
81
82			return $this->render(
83			'gamebetting/betting/all_games.html.twig',
84			[
85			'futureGamesForm' => $futureGamesFormBuilder
86			]
87			);
88			}
89
90			/**
91			* @Route("/all-past-games", name="all_past_games")
92			* @return \Symfony\Component\HttpFoundation\Response
93			*/
94			public function allPastGames()
95			{
96			$pastGamesForm = $this->userPastGames->get($this->getUser());
97
98			return $this->render(
99			'gamebetting/betting/past_games.html.twig',
100			[
101			'pastGamesForm' => $pastGamesForm,
102			'username' => false
103			]
104			);
105			}
106
107			/**
108			* toDo Refactor this
109			* @Route("/past-game-detail/{gameId}", name="past_game_detail")
110			* @return \Symfony\Component\HttpFoundation\Response
111			*/
112			public function pastGameDetail(int $gameId)
113			{
114			$users = $this->getDoctrine()->getRepository(User::class)
115			->findBy([], ['username' => 'ASC']);
116
117			$teamFirstName = '';
118			$teamSecondName = '';
119			$gameInfo2users = [];
120			foreach ($users as $user) {
121			$pastGamesForm = $this->userPastGames->getOnePastGame($user, $gameId);
122			if (!empty($pastGamesForm)) {
123			$teamFirstName = current($pastGamesForm)->getFirstTeamName();
124			$teamSecondName = current($pastGamesForm)->getSecondTeamName();
125
126			$gameInfo2users[$user->getUsername()] = current($pastGamesForm);
127			}
128
129			}
130
131			return $this->render(
132			'gamebetting/betting/past_game_detail.html.twig',
133			[
134			'gameInfo2users' => $gameInfo2users,
135			'teamFirstName' => $teamFirstName,
136			'teamSecondName' => $teamSecondName,
137			]
138			);
139			}
140
141			/**
142			* @Route("/all-past-games-by-user/{userId}", name="game_past_games_by_users")
143			*/
144			public function allPastGameByUserId(int $userId)
145			{
146			$user = $this->getDoctrine()->getRepository(User::class)
147			->findOneBy(['id' => $userId]);
148			$pastGamesForm = [];
149			$username = '';
150			if ($user instanceof User) {
151			$pastGamesForm = $this->userPastGames->get($user);
152			$username = $user->getUsername();
153			}
154
155			return $this->render(
156			'gamebetting/betting/past_games.html.twig',
157			[
158			'pastGamesForm' => $pastGamesForm,
159			'username' => $username
160			]
161			);
162
163			}
164
165			public function getNextGames(int $numberOfGames)
166			{
167			$gameBetResult = \array_slice($this->userFutureGames->get($this->getUser()), 0, $numberOfGames);
168
169			return $this->render(
170			'dashboard/next_games.html.twig',
171			[
172			'gameBetResult' => $gameBetResult
173			]
174			);
175			}
176
177			/**
178			* @Route("/savebet", name="save_bet")
179			* @Method({"POST"})
180			*/
181			public function saveBet(Request $request)
182			{
183			$params = (array)$request->get('user_betting');
184			$userBetting = new UserBettingEntity();
185			$form = $this->createForm(UserBettingType::class, $userBetting);
186			$form->handleRequest($request);
187
188			if ($this->isSaveFormInValid($form, $params) === true) {
189			return $this->json(['status' => false]);
190			}
191
192			$entityManager = $this->getDoctrine()->getManager();
193			$userBetting = $entityManager->getRepository(UserBettingEntity::class)
194			->findByGameIdAndUserId($params['gameId'], $this->getUser()->getId());
195			if (!$userBetting instanceof UserBettingEntity) {
196			$userBetting = new UserBettingEntity();
197			$game = $entityManager->getRepository(Game::class)
198			->find($params['gameId']);
199			$userBetting->setGame($game);
200			$userBetting->setUser($this->getUser());
201			}
202
203
204			$userBetting->setFirstTeamResult((int)$params['firstTeamResult']);
205			$userBetting->setSecondTeamResult((int)$params['secondTeamResult']);
206
207			if ($userBetting->getGame()->getDate()->getTimestamp() < time()) {
208			return $this->json(['status' => false]);
209			}
210
211			$entityManager->persist($userBetting);
212			$entityManager->flush();
213
214			return $this->json(['status' => true]);
215			}
216
217			/**
218			* @param $form
219			* @param array $params
220			* @return bool
221			*/
222			private function isSaveFormInValid($form, array $params) : bool
223			{
224			$isFromInValid = false;
225			if (!$form->isSubmitted() && !$form->isValid()) {
226			$isFromInValid = true;
227			} else if (!isset($params['firstTeamResult']) \|\| $params['firstTeamResult'] < 0) {
228			$isFromInValid = true;
229			} else if (!isset($params['secondTeamResult']) \|\| $params['secondTeamResult'] < 0) {
230			$isFromInValid = true;
231			}
232
233			return $isFromInValid;
234			}
235
236			/**
237			* @return array
238			*/
239			private function getFutureGamesFormBuilder(): array
240			{
241			$userFurureGames = $this->userFutureGames->get(
242			$this->getUser()
243			);
244			$gamesFormBuilder = [];
245			foreach ($userFurureGames as $gameId => $futureGameInfo) {
246			$gamesFormBuilder[$gameId] = $this->createForm(
247			UserBettingType::class, null, $futureGameInfo
248			)->createView();
249			}
250			return $gamesFormBuilder;
251			}
252			}

football-betting / symfony4

Push — master ( fa97fb...0ef4e9 )

UserBetting::isSaveFormInValid() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like