Client::getGames() - Code Metrics - Inspection of "Merge pull request #17 from football-betting/liveS..." - football-betting/symfony4 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 39dd2f...8ee4e9 )

by Rafal

created 2018-06-28 07:51 UTC

Client::getGames() A

↳ Parent: Client

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	9
rs	9.9666
c	0
b	0
f	0

<?php

namespace App\GameApi\Business\WorldCupSfgIo\Client;

use GuzzleHttp\Client as GuzzleHttpClient;


class Client implements ClientInterface
{
    private const URL = 'https://worldcup.sfg.io/';
    private const GAMES = '/matches/today';

    /**
     * @var GuzzleHttpClient
     */
    private $client;

    /**
     * @var ParserInterface
     */
    private $parser;

    /**
     * @param ParserInterface $parser
     */
    public function __construct(ParserInterface $parser)
    {
        $this->parser = $parser;
    }

    /**
     * @return \App\GameApi\Persistence\DataProvider\GameResult[]
     */
    public function getGames() : array
    {
        $res = $this->getClient()->get(self::GAMES, $this->options);

        $gameInfo = (array)json_decode(
            (string)$res->getBody()->getContents(),
            true
        );

        return $this->parser->get($gameInfo);
    }

    /**
     * @return GuzzleHttpClient
     */
    private function getClient() : GuzzleHttpClient
    {
        if ($this->client === null) {
            $this->client = new GuzzleHttpClient([
                'base_uri' => self::URL
            ]);
        }
        return $this->client;
    }
}

1			<?php
2
3			namespace App\GameApi\Business\WorldCupSfgIo\Client;
4
5			use GuzzleHttp\Client as GuzzleHttpClient;
6
7
8			class Client implements ClientInterface
9			{
10			private const URL = 'https://worldcup.sfg.io/';
11			private const GAMES = '/matches/today';
12
13			/**
14			* @var GuzzleHttpClient
15			*/
16			private $client;
17
18			/**
19			* @var ParserInterface
20			*/
21			private $parser;
22
23			/**
24			* @param ParserInterface $parser
25			*/
26			public function __construct(ParserInterface $parser)
27			{
28			$this->parser = $parser;
29			}
30
31			/**
32			* @return \App\GameApi\Persistence\DataProvider\GameResult[]
33			*/
34			public function getGames() : array
35			{
36			$res = $this->getClient()->get(self::GAMES, $this->options);
			0 ignored issues – show Bug Best Practice introduced 2018-06-26 21:24 UTC by Report Bug Copy Issue Report The property `options` does not exist on `App\GameApi\Business\WorldCupSfgIo\Client\Client`. Did you maybe forget to declare it? Loading history...
37			$gameInfo = (array)json_decode(
38			(string)$res->getBody()->getContents(),
39			true
40			);
41
42			return $this->parser->get($gameInfo);
43			}
44
45			/**
46			* @return GuzzleHttpClient
47			*/
48			private function getClient() : GuzzleHttpClient
49			{
50			if ($this->client === null) {
51			$this->client = new GuzzleHttpClient([
52			'base_uri' => self::URL
53			]);
54			}
55			return $this->client;
56			}
57			}

football-betting / symfony4

Push — master ( 39dd2f...8ee4e9 )

Client::getGames() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like