App\GameRating\Business\GamePoints\Points

Complexity

Total Complexity

7

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	checkCollection()	0	5	3
A	get()	0	17	3
A	__construct()	0	3	1

<?php


namespace App\GameRating\Business\GamePoints;


use App\GameRating\Business\GamePoints\Collection\CollectionInterface;
use App\GameRating\Persistence\DataProvider\Result;

class Points implements PointsInterface
{
    /**
     * @var CollectionInterface
     */
    private $collections;

    /**
     * @param CollectionInterface[] $collections
     */
    public function __construct(...$collections)
    {
        $this->collections = $collections;

It seems like $collections of type array<integer,App\GameRating\Business\GamePoints\Collection\CollectionInterface> is incompatible with the declared type App\GameRating\Business\GamePoints\Collection\CollectionInterface of property $collections.

    }

    /**
     * @param Result $result
     * @return int
     */
    public function get(Result $result): int
    {
        $this->checkCollection();

        usort($this->collections, function ($a, $b) {

$this->collections of type App\GameRating\Business\GamePoints\Collection\CollectionInterface is incompatible with the type array expected by parameter $array of usort().

            return $a->getScore() <=> $b->getScore();
        });
        $this->collections = array_reverse($this->collections);

It seems like array_reverse($this->collections) of type array is incompatible with the declared type App\GameRating\Business\GamePoints\Collection\CollectionInterface of property $collections.

        foreach ($this->collections as $collection) {
            if ($collection->check($result) === true) {
                $score = $collection->getScore();
                break;
            }
        }

        return $score;

The variable $score does not seem to be defined for all execution paths leading up to this point.

    }


    private function checkCollection()
    {
        foreach ($this->collections as $collection) {
            if (!$collection instanceof CollectionInterface) {
                throw new \RuntimeException('Collection: ' . get_class($collection) . 'is not instanceof ' . CollectionInterface::class);
            }
        }
    }


}