Issues in class-retina.php (master) - Issues in master - fooplugins/foogallery - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1881)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/class-retina.php (4 issues)

Labels

Severity

Minor 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 * FooGallery Retina Support class
 */

if ( !class_exists( 'FooGallery_Retina' ) ) {

    class FooGallery_Retina {
namespace YourVendor;

class YourClass { }

        function __construct() {

            add_filter('foogallery_attachment_html_image_attributes', array($this, 'add_retina_attributes'), 10, 3);
        }

        /**
         * @param array $attr
         * @param array $args
         * @param FooGalleryAttachment $attachment
         * @return mixed
         */
        function add_retina_attributes($attr, $args, $attachment) {

            global $current_foogallery;
function myFunction($a, $b) {
    // Do something
}

            if ( $current_foogallery && $current_foogallery->gallery_template ) {

                //first check if the gallery has saved Retina settings
                if ( isset($current_foogallery->retina) && is_array( $current_foogallery->retina ) ) {
                    $srcset = array();

					//get the original thumb dimensions
					$original_thumb_width = array_key_exists( 'width', $args ) ? intval( $args['width'] ) : 0;
					$original_thumb_height = array_key_exists( 'height', $args ) ? intval( $args['height'] ) : 0;

					//get the original full size image dimensions
					$original_width = $attachment->width;
					$original_height = $attachment->height;

					//if we do not have a width, we need to calculate one
					if ( 0 === $original_thumb_width ) {
						//find closest ratio multiple to image size
						if( $original_width > $original_height ) {
							//landscape
							$ratio = $original_width / $original_height;
							$original_thumb_width = intval( $original_thumb_height * $ratio );
						}else{
							//portrait
							$ratio = $original_height / $original_width;
							$original_thumb_width = intval( $original_thumb_height / $ratio );
						}
					}

                    foreach ( foogallery_retina_options() as $pixel_density ) {
                        $pixel_density_supported = array_key_exists( $pixel_density, $current_foogallery->retina ) ? ('true' === $current_foogallery->retina[$pixel_density]) : false;

                        if ( $pixel_density_supported ) {
                            $pixel_density_int = intval( str_replace( 'x', '', $pixel_density ) );

                            //apply scaling to the width and height attributes
                            $retina_width  = $original_thumb_width * $pixel_density_int;
                            $retina_height = $original_thumb_height * $pixel_density_int;

                            //if the new dimensions are smaller than the full size image dimensions then allow the retina thumb
                            if ( $retina_width < $original_width &&
                                $retina_height < $original_height ) {
                                $args['width'] = $retina_width;
                                $args['height'] = $retina_height;

                                //build up the retina attributes
                                $srcset[] = $attachment->html_img_src( $args ) . ' ' . $retina_width . 'w';
                            }
                        }
                    }

                    if ( count( $srcset ) ) {
                        $attr['srcset'] = implode( ',', $srcset );
                    }
                }
            }

            return $attr;
        }
    }
}


1			<?php
2			/*
3			* FooGallery Retina Support class
4			*/
5
6			if ( !class_exists( 'FooGallery_Retina' ) ) {
7
8			class FooGallery_Retina {
			0 ignored issues – show Coding Style Compatibility introduced 2016-11-01 21:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
9
10			function __construct() {
			0 ignored issues – show Best Practice introduced 2016-11-01 21:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
11			add_filter('foogallery_attachment_html_image_attributes', array($this, 'add_retina_attributes'), 10, 3);
12			}
13
14			/**
15			* @param array $attr
16			* @param array $args
17			* @param FooGalleryAttachment $attachment
18			* @return mixed
19			*/
20			function add_retina_attributes($attr, $args, $attachment) {
			0 ignored issues – show Best Practice introduced 2016-11-01 21:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
21			global $current_foogallery;
			0 ignored issues – show Compatibility Best Practice introduced 2016-11-01 21:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
22
23			if ( $current_foogallery && $current_foogallery->gallery_template ) {
24
25			//first check if the gallery has saved Retina settings
26			if ( isset($current_foogallery->retina) && is_array( $current_foogallery->retina ) ) {
27			$srcset = array();
28
29			//get the original thumb dimensions
30			$original_thumb_width = array_key_exists( 'width', $args ) ? intval( $args['width'] ) : 0;
31			$original_thumb_height = array_key_exists( 'height', $args ) ? intval( $args['height'] ) : 0;
32
33			//get the original full size image dimensions
34			$original_width = $attachment->width;
35			$original_height = $attachment->height;
36
37			//if we do not have a width, we need to calculate one
38			if ( 0 === $original_thumb_width ) {
39			//find closest ratio multiple to image size
40			if( $original_width > $original_height ) {
41			//landscape
42			$ratio = $original_width / $original_height;
43			$original_thumb_width = intval( $original_thumb_height * $ratio );
44			}else{
45			//portrait
46			$ratio = $original_height / $original_width;
47			$original_thumb_width = intval( $original_thumb_height / $ratio );
48			}
49			}
50
51			foreach ( foogallery_retina_options() as $pixel_density ) {
52			$pixel_density_supported = array_key_exists( $pixel_density, $current_foogallery->retina ) ? ('true' === $current_foogallery->retina[$pixel_density]) : false;
53
54			if ( $pixel_density_supported ) {
55			$pixel_density_int = intval( str_replace( 'x', '', $pixel_density ) );
56
57			//apply scaling to the width and height attributes
58			$retina_width = $original_thumb_width * $pixel_density_int;
59			$retina_height = $original_thumb_height * $pixel_density_int;
60
61			//if the new dimensions are smaller than the full size image dimensions then allow the retina thumb
62			if ( $retina_width < $original_width &&
63			$retina_height < $original_height ) {
64			$args['width'] = $retina_width;
65			$args['height'] = $retina_height;
66
67			//build up the retina attributes
68			$srcset[] = $attachment->html_img_src( $args ) . ' ' . $retina_width . 'w';
69			}
70			}
71			}
72
73			if ( count( $srcset ) ) {
74			$attr['srcset'] = implode( ',', $srcset );
75			}
76			}
77			}
78
79			return $attr;
80			}
81			}
82			}
83

GitHub Access Token became invalid

Issues (1881)

Security Analysis not enabled

includes/class-retina.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

fooplugins / foogallery

GitHub Access Token became invalid

Issues (1881)

Security Analysis not enabled

includes/class-retina.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like