Issues in class-foogallery-lazyload.php (master) - Issues in master - fooplugins/foogallery - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1881)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/class-foogallery-lazyload.php (16 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Class used to handle lazy loading for gallery templates
 * Date: 20/03/2017
 */
if ( ! class_exists( 'FooGallery_LazyLoad' ) ) {

	class FooGallery_LazyLoad
namespace YourVendor;

class YourClass { }
    {

        function __construct()

        {
            //determine lazy loading for the gallery once up front before the template is loaded
            add_action('foogallery_located_template', array($this, 'determine_lazyloading_for_gallery'));

            //change the image src attribute to data attributes if lazy loading is enabled
            add_filter('foogallery_attachment_html_image_attributes', array($this, 'change_src_attributes'), 99, 3);

            //add the lazy load attributes to the gallery container
            add_filter('foogallery_build_container_data_options', array($this, 'add_lazyload_options'), 10, 3);

            //add common fields to the templates that support it
            add_filter('foogallery_override_gallery_template_fields', array($this, 'add_lazyload_field'), 100, 2);

            //build up preview arguments
            add_filter( 'foogallery_preview_arguments', array( $this, 'preview_arguments' ), 10, 3 );

            //add some settings to allow forcing of the lazy loading to be disabled
            add_filter( 'foogallery_admin_settings_override', array( $this, 'add_settings' ) );
        }

        /**
         * Determine all the lazu loading variables that can be set on a gallery
         * @param $foogallery
         */
        function determine_lazyloading_for_gallery($foogallery) {

            global $current_foogallery;
function myFunction($a, $b) {
    // Do something
}
            global $current_foogallery_template;
function myFunction($a, $b) {
    // Do something
}

            if ($current_foogallery !== null) {
                //make sure we only do this once for better performance
                if (!isset($current_foogallery->lazyload_support)) {

                    //load the gallery template
                    $template_info = foogallery_get_gallery_template($current_foogallery_template);

                    //check if the template supports lazy loading
                    $lazyloading_support = isset($template_info['lazyload_support']) &&
                        true === $template_info['lazyload_support'];

                    //set if lazy loading is supported for the gallery
                    $current_foogallery->lazyload_support = apply_filters('foogallery_lazy_load', $lazyloading_support, $current_foogallery, $current_foogallery_template);

                    //set if lazy loading is enabled for the gallery
                    $lazyloading_default = '';
                    $lazyloading_enabled = foogallery_gallery_template_setting('lazyload', $lazyloading_default) === '';
                    $current_foogallery->lazyload_enabled = $lazyloading_enabled;

                    //set if lazy loading is forced to disabled for all galleries
                    $lazyloading_forced_disabled = foogallery_get_setting('disable_lazy_loading') === 'on';
                    $current_foogallery->lazyload_forced_disabled = $lazyloading_forced_disabled;

                    //check if we are inside a feed. Always disable lazy load when shown within a feed
					if ( is_feed() ) {
						$current_foogallery->lazyload_forced_disabled = true;
					}

                }
            }
        }

        /**
         * @param array $attr
         * @param array $args
         * @param FooGalleryAttachment $attachment
         * @return mixed
         */
        function change_src_attributes($attr, $args, $attachment)

        {
            global $current_foogallery;
function myFunction($a, $b) {
    // Do something
}

            if ($current_foogallery !== null) {

            	//check that lazy loading was not disabled from the Gallery Settings -> Advanced Tab
            	if ( isset( $current_foogallery->lazyload_enabled ) ) {
            		if ( false === $current_foogallery->lazyload_enabled ) {
						return $attr;
					}
				}

				//check that lazy loading was not disabled from Global Settings or any other reason
				if ( isset( $current_foogallery->lazyload_forced_disabled ) ) {
					if ( true === $current_foogallery->lazyload_forced_disabled ) {
						return $attr;
					}
				}

                if (isset($current_foogallery->lazyload_support) && true === $current_foogallery->lazyload_support) {
                    if (isset($attr['src'])) {
                        //rename src => data-src
                        $src = $attr['src'];
                        unset($attr['src']);
                        $attr['data-src-fg'] = $src;
                    }

                    if (isset($attr['srcset'])) {
                        //rename srcset => data-srcset
                        $src = $attr['srcset'];
                        unset($attr['srcset']);
                        $attr['data-srcset-fg'] = $src;
                    }
                }
            }

            return $attr;
        }


        /**
         * Add the required lazy load options if needed
         *
         * @param $attributes array
         * @param $gallery FooGallery
         *
         * @return array
         */
        function add_lazyload_options($options, $gallery, $attributes)

        {
            if ( isset( $gallery->lazyload_support ) && true === $gallery->lazyload_support ) {
                $options['lazy'] = $gallery->lazyload_enabled && !$gallery->lazyload_forced_disabled;
                if ( $options['lazy'] ) {
					$options['src']    = 'data-src-fg';
					$options['srcset'] = 'data-srcset-fg';
				} else {
					$options['src']    = 'src';
					$options['srcset'] = 'srcset';
				}
            }
            return $options;
        }

        /**
         * Add lazyload field to the gallery template if supported
         *
         * @param $fields
         * @param $template
         *
         * @return array
         */
        function add_lazyload_field($fields, $template)

        {
            //check if the template supports lazy loading
            if ( $template && array_key_exists( 'lazyload_support', $template ) && true === $template['lazyload_support'] ) {

                $fields[] = array(
                    'id'      => 'lazyload',
                    'title'   => __( 'Lazy Loading', 'foogallery' ),
                    'desc'    => __( 'If you choose to disable lazy loading, then all thumbnails will be loaded at once. This means you will lose the performance improvements that lazy loading gives you.', 'foogallery' ),
                    'section' => __( 'Advanced', 'foogallery' ),
                    'type'     => 'radio',
                    'spacer'   => '<span class="spacer"></span>',
                    'default'  => '',
                    'choices'  => array(
                        '' => __( 'Enable Lazy Loading', 'foogallery' ),
                        'disabled' => __( 'Disable Lazy Loading', 'foogallery' ),
                    ),
                    'row_data' => array(
                        'data-foogallery-change-selector' => 'input:radio',
                        'data-foogallery-preview' => 'shortcode'
                    )
                );
            }

            return $fields;
        }

        /**
         * Build up a arguments used in the preview of the gallery
         * @param $args
         * @param $post_data
         * @param $template
         *
         * @return mixed
         */
        function preview_arguments( $args, $post_data, $template ) {

            if ( isset( $post_data[FOOGALLERY_META_SETTINGS][$template . '_lazyload'] ) ) {
                $args['lazyload'] = $post_data[FOOGALLERY_META_SETTINGS][$template . '_lazyload'];
            }
            return $args;
        }


        /**
         * Add some global settings
         * @param $settings
         *
         * @return array
         */
        function add_settings( $settings ) {


            $lazy_settings[] = array(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                'id'      => 'disable_lazy_loading',
                'title'   => __( 'Disable Lazy Loading', 'foogallery' ),
                'desc'    => __( 'This will disable lazy loading for ALL galleries. This is not recommended, but is sometimes needed when there are problems with the galleries displaying on some installs.', 'foogallery' ),
                'type'    => 'checkbox',
                'tab'     => 'general',
                'section' => __( 'Lazy Loading', 'foogallery' )
            );

            $new_settings = array_merge( $lazy_settings, $settings['settings'] );

            $settings['settings'] = $new_settings;

            return $settings;
        }
    }
}

GitHub Access Token became invalid

Issues (1881)

Security Analysis not enabled

includes/class-foogallery-lazyload.php (16 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2			/**
3			* Class used to handle lazy loading for gallery templates
4			* Date: 20/03/2017
5			*/
6			if ( ! class_exists( 'FooGallery_LazyLoad' ) ) {
7
8			class FooGallery_LazyLoad
			0 ignored issues – show Coding Style Compatibility introduced 2017-04-12 18:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
9			{
10
11			function __construct()
			0 ignored issues – show Best Practice introduced 2017-11-12 07:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
12			{
13			//determine lazy loading for the gallery once up front before the template is loaded
14			add_action('foogallery_located_template', array($this, 'determine_lazyloading_for_gallery'));
15
16			//change the image src attribute to data attributes if lazy loading is enabled
17			add_filter('foogallery_attachment_html_image_attributes', array($this, 'change_src_attributes'), 99, 3);
18
19			//add the lazy load attributes to the gallery container
20			add_filter('foogallery_build_container_data_options', array($this, 'add_lazyload_options'), 10, 3);
21
22			//add common fields to the templates that support it
23			add_filter('foogallery_override_gallery_template_fields', array($this, 'add_lazyload_field'), 100, 2);
24
25			//build up preview arguments
26			add_filter( 'foogallery_preview_arguments', array( $this, 'preview_arguments' ), 10, 3 );
27
28			//add some settings to allow forcing of the lazy loading to be disabled
29			add_filter( 'foogallery_admin_settings_override', array( $this, 'add_settings' ) );
30			}
31
32			/**
33			* Determine all the lazu loading variables that can be set on a gallery
34			* @param $foogallery
35			*/
36			function determine_lazyloading_for_gallery($foogallery) {
			0 ignored issues – show Unused Code introduced 2017-11-12 07:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$foogallery` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Best Practice introduced 2017-11-12 07:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
37			global $current_foogallery;
			0 ignored issues – show Compatibility Best Practice introduced 2017-11-12 07:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
38			global $current_foogallery_template;
			0 ignored issues – show Compatibility Best Practice introduced 2017-11-07 07:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
39
40			if ($current_foogallery !== null) {
41			//make sure we only do this once for better performance
42			if (!isset($current_foogallery->lazyload_support)) {
43
44			//load the gallery template
45			$template_info = foogallery_get_gallery_template($current_foogallery_template);
46
47			//check if the template supports lazy loading
48			$lazyloading_support = isset($template_info['lazyload_support']) &&
49			true === $template_info['lazyload_support'];
50
51			//set if lazy loading is supported for the gallery
52			$current_foogallery->lazyload_support = apply_filters('foogallery_lazy_load', $lazyloading_support, $current_foogallery, $current_foogallery_template);
53
54			//set if lazy loading is enabled for the gallery
55			$lazyloading_default = '';
56			$lazyloading_enabled = foogallery_gallery_template_setting('lazyload', $lazyloading_default) === '';
57			$current_foogallery->lazyload_enabled = $lazyloading_enabled;
58
59			//set if lazy loading is forced to disabled for all galleries
60			$lazyloading_forced_disabled = foogallery_get_setting('disable_lazy_loading') === 'on';
61			$current_foogallery->lazyload_forced_disabled = $lazyloading_forced_disabled;
62
63			//check if we are inside a feed. Always disable lazy load when shown within a feed
64			if ( is_feed() ) {
65			$current_foogallery->lazyload_forced_disabled = true;
66			}
67
68			}
69			}
70			}
71
72			/**
73			* @param array $attr
74			* @param array $args
75			* @param FooGalleryAttachment $attachment
76			* @return mixed
77			*/
78			function change_src_attributes($attr, $args, $attachment)
			0 ignored issues – show Unused Code introduced 2017-04-12 18:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$args` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-04-12 18:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$attachment` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Best Practice introduced 2017-04-12 18:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
79			{
80			global $current_foogallery;
			0 ignored issues – show Compatibility Best Practice introduced 2017-09-20 14:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
81
82			if ($current_foogallery !== null) {
83
84			//check that lazy loading was not disabled from the Gallery Settings -> Advanced Tab
85			if ( isset( $current_foogallery->lazyload_enabled ) ) {
86			if ( false === $current_foogallery->lazyload_enabled ) {
87			return $attr;
88			}
89			}
90
91			//check that lazy loading was not disabled from Global Settings or any other reason
92			if ( isset( $current_foogallery->lazyload_forced_disabled ) ) {
93			if ( true === $current_foogallery->lazyload_forced_disabled ) {
94			return $attr;
95			}
96			}
97
98			if (isset($current_foogallery->lazyload_support) && true === $current_foogallery->lazyload_support) {
99			if (isset($attr['src'])) {
100			//rename src => data-src
101			$src = $attr['src'];
102			unset($attr['src']);
103			$attr['data-src-fg'] = $src;
104			}
105
106			if (isset($attr['srcset'])) {
107			//rename srcset => data-srcset
108			$src = $attr['srcset'];
109			unset($attr['srcset']);
110			$attr['data-srcset-fg'] = $src;
111			}
112			}
113			}
114
115			return $attr;
116			}
117
118
119			/**
120			* Add the required lazy load options if needed
121			*
122			* @param $attributes array
123			* @param $gallery FooGallery
124			*
125			* @return array
126			*/
127			function add_lazyload_options($options, $gallery, $attributes)
			0 ignored issues – show Unused Code introduced 2017-08-16 20:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$attributes` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Best Practice introduced 2017-08-16 20:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
128			{
129			if ( isset( $gallery->lazyload_support ) && true === $gallery->lazyload_support ) {
130			$options['lazy'] = $gallery->lazyload_enabled && !$gallery->lazyload_forced_disabled;
131			if ( $options['lazy'] ) {
132			$options['src'] = 'data-src-fg';
133			$options['srcset'] = 'data-srcset-fg';
134			} else {
135			$options['src'] = 'src';
136			$options['srcset'] = 'srcset';
137			}
138			}
139			return $options;
140			}
141
142			/**
143			* Add lazyload field to the gallery template if supported
144			*
145			* @param $fields
146			* @param $template
147			*
148			* @return array
149			*/
150			function add_lazyload_field($fields, $template)
			0 ignored issues – show Best Practice introduced 2017-04-12 18:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
151			{
152			//check if the template supports lazy loading
153			if ( $template && array_key_exists( 'lazyload_support', $template ) && true === $template['lazyload_support'] ) {
154
155			$fields[] = array(
156			'id' => 'lazyload',
157			'title' => __( 'Lazy Loading', 'foogallery' ),
158			'desc' => __( 'If you choose to disable lazy loading, then all thumbnails will be loaded at once. This means you will lose the performance improvements that lazy loading gives you.', 'foogallery' ),
159			'section' => __( 'Advanced', 'foogallery' ),
160			'type' => 'radio',
161			'spacer' => '<span class="spacer"></span>',
162			'default' => '',
163			'choices' => array(
164			'' => __( 'Enable Lazy Loading', 'foogallery' ),
165			'disabled' => __( 'Disable Lazy Loading', 'foogallery' ),
166			),
167			'row_data' => array(
168			'data-foogallery-change-selector' => 'input:radio',
169			'data-foogallery-preview' => 'shortcode'
170			)
171			);
172			}
173
174			return $fields;
175			}
176
177			/**
178			* Build up a arguments used in the preview of the gallery
179			* @param $args
180			* @param $post_data
181			* @param $template
182			*
183			* @return mixed
184			*/
185			function preview_arguments( $args, $post_data, $template ) {
			0 ignored issues – show Best Practice introduced 2017-11-08 12:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
186			if ( isset( $post_data[FOOGALLERY_META_SETTINGS][$template . '_lazyload'] ) ) {
187			$args['lazyload'] = $post_data[FOOGALLERY_META_SETTINGS][$template . '_lazyload'];
188			}
189			return $args;
190			}
191
192
193			/**
194			* Add some global settings
195			* @param $settings
196			*
197			* @return array
198			*/
199			function add_settings( $settings ) {
			0 ignored issues – show Best Practice introduced 2017-11-12 07:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
200
201			$lazy_settings[] = array(
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-11-12 07:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$lazy_settings` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$lazy_settings = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
202			'id' => 'disable_lazy_loading',
203			'title' => __( 'Disable Lazy Loading', 'foogallery' ),
204			'desc' => __( 'This will disable lazy loading for ALL galleries. This is not recommended, but is sometimes needed when there are problems with the galleries displaying on some installs.', 'foogallery' ),
205			'type' => 'checkbox',
206			'tab' => 'general',
207			'section' => __( 'Lazy Loading', 'foogallery' )
208			);
209
210			$new_settings = array_merge( $lazy_settings, $settings['settings'] );
211
212			$settings['settings'] = $new_settings;
213
214			return $settings;
215			}
216			}
217			}

fooplugins / foogallery

GitHub Access Token became invalid

Issues (1881)

Security Analysis not enabled

includes/class-foogallery-lazyload.php (16 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like