Issues in class-fs-plugin.php (master) - Issues in master - fooplugins/foogallery - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1881)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

freemius/includes/entities/class-fs-plugin.php (6 issues)

Labels

Severity

Minor 6

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

    /**
     * @package     Freemius
     * @copyright   Copyright (c) 2015, Freemius, Inc.
     * @license     https://www.gnu.org/licenses/gpl-3.0.html GNU General Public License Version 3
     * @since       1.0.3
     */

    if ( ! defined( 'ABSPATH' ) ) {
        exit;
    }

    class FS_Plugin extends FS_Scope_Entity {
namespace YourVendor;

class YourClass { }
        /**
         * @since 1.0.6
         * @var null|number
         */
        public $parent_plugin_id;
        /**
         * @var string
         */
        public $title;
        /**
         * @var string
         */
        public $slug;
        /**
         * @author Leo Fajardo (@leorw)
         * @since 2.2.1
         *
         * @var string
         */
        public $premium_slug;
        /**
         * @since 1.2.2
         *
         * @var string 'plugin' or 'theme'
         */
        public $type;
        /**
         * @author Leo Fajardo (@leorw)
         *
         * @since  1.2.3
         *
         * @var string|false false if the module doesn't have an affiliate program or one of the following: 'selected', 'customers', or 'all'.
         */
        public $affiliate_moderation;
        /**
         * @var bool Set to true if the free version of the module is hosted on WordPress.org. Defaults to true.
         */
        public $is_wp_org_compliant = true;

        #region Install Specific Properties

        /**
         * @var string
         */
        public $file;
        /**
         * @var string
         */
        public $version;
        /**
         * @var bool
         */
        public $auto_update;
        /**
         * @var FS_Plugin_Info
         */
        public $info;
        /**
         * @since 1.0.9
         *
         * @var bool
         */
        public $is_premium;
        /**
         * @author Leo Fajardo (@leorw)
         * @since 2.2.1
         *
         * @var string
         */
        public $premium_suffix;
        /**
         * @since 1.0.9
         *
         * @var bool
         */
        public $is_live;

        const AFFILIATE_MODERATION_CUSTOMERS = 'customers';

        #endregion Install Specific Properties

        /**
         * @param stdClass|bool $plugin
         */
        function __construct( $plugin = false ) {

            parent::__construct( $plugin );

            $this->is_premium = false;
            $this->is_live    = true;

            if ( empty( $this->premium_slug ) && ! empty( $plugin->slug ) ) {
                $this->premium_slug = "{$this->slug}-premium";
            }

            if ( empty( $this->premium_suffix ) ) {
                $this->premium_suffix = '(Premium)';
            }

            if ( isset( $plugin->info ) && is_object( $plugin->info ) ) {
                $this->info = new FS_Plugin_Info( $plugin->info );
            }
        }

        /**
         * Check if plugin is an add-on (has parent).
         *
         * @author Vova Feldman (@svovaf)
         * @since  1.0.6
         *
         * @return bool
         */
        function is_addon() {

            return isset( $this->parent_plugin_id ) && is_numeric( $this->parent_plugin_id );
        }

        /**
         * @author Leo Fajardo (@leorw)
         * @since  1.2.3
         *
         * @return bool
         */
        function has_affiliate_program() {

            return ( ! empty( $this->affiliate_moderation ) );
        }

        static function get_type() {

            return 'plugin';
        }
    }

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2017-06-04 19:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 13 and the first side effect is on line 10. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/**
3			* @package Freemius
4			* @copyright Copyright (c) 2015, Freemius, Inc.
5			* @license https://www.gnu.org/licenses/gpl-3.0.html GNU General Public License Version 3
6			* @since 1.0.3
7			*/
8
9			if ( ! defined( 'ABSPATH' ) ) {
10			exit;
11			}
12
13			class FS_Plugin extends FS_Scope_Entity {
			0 ignored issues – show Coding Style Compatibility introduced 2017-06-04 19:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
14			/**
15			* @since 1.0.6
16			* @var null\|number
17			*/
18			public $parent_plugin_id;
19			/**
20			* @var string
21			*/
22			public $title;
23			/**
24			* @var string
25			*/
26			public $slug;
27			/**
28			* @author Leo Fajardo (@leorw)
29			* @since 2.2.1
30			*
31			* @var string
32			*/
33			public $premium_slug;
34			/**
35			* @since 1.2.2
36			*
37			* @var string 'plugin' or 'theme'
38			*/
39			public $type;
40			/**
41			* @author Leo Fajardo (@leorw)
42			*
43			* @since 1.2.3
44			*
45			* @var string\|false false if the module doesn't have an affiliate program or one of the following: 'selected', 'customers', or 'all'.
46			*/
47			public $affiliate_moderation;
48			/**
49			* @var bool Set to true if the free version of the module is hosted on WordPress.org. Defaults to true.
50			*/
51			public $is_wp_org_compliant = true;
52
53			#region Install Specific Properties
54
55			/**
56			* @var string
57			*/
58			public $file;
59			/**
60			* @var string
61			*/
62			public $version;
63			/**
64			* @var bool
65			*/
66			public $auto_update;
67			/**
68			* @var FS_Plugin_Info
69			*/
70			public $info;
71			/**
72			* @since 1.0.9
73			*
74			* @var bool
75			*/
76			public $is_premium;
77			/**
78			* @author Leo Fajardo (@leorw)
79			* @since 2.2.1
80			*
81			* @var string
82			*/
83			public $premium_suffix;
84			/**
85			* @since 1.0.9
86			*
87			* @var bool
88			*/
89			public $is_live;
90
91			const AFFILIATE_MODERATION_CUSTOMERS = 'customers';
92
93			#endregion Install Specific Properties
94
95			/**
96			* @param stdClass\|bool $plugin
97			*/
98			function __construct( $plugin = false ) {
			0 ignored issues – show Best Practice introduced 2017-06-04 19:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
99			parent::__construct( $plugin );
100
101			$this->is_premium = false;
102			$this->is_live = true;
103
104			if ( empty( $this->premium_slug ) && ! empty( $plugin->slug ) ) {
105			$this->premium_slug = "{$this->slug}-premium";
106			}
107
108			if ( empty( $this->premium_suffix ) ) {
109			$this->premium_suffix = '(Premium)';
110			}
111
112			if ( isset( $plugin->info ) && is_object( $plugin->info ) ) {
113			$this->info = new FS_Plugin_Info( $plugin->info );
114			}
115			}
116
117			/**
118			* Check if plugin is an add-on (has parent).
119			*
120			* @author Vova Feldman (@svovaf)
121			* @since 1.0.6
122			*
123			* @return bool
124			*/
125			function is_addon() {
			0 ignored issues – show Best Practice introduced 2017-06-04 19:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
126			return isset( $this->parent_plugin_id ) && is_numeric( $this->parent_plugin_id );
127			}
128
129			/**
130			* @author Leo Fajardo (@leorw)
131			* @since 1.2.3
132			*
133			* @return bool
134			*/
135			function has_affiliate_program() {
			0 ignored issues – show Best Practice introduced 2017-11-07 07:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
136			return ( ! empty( $this->affiliate_moderation ) );
137			}
138
139			static function get_type() {
			0 ignored issues – show Best Practice introduced 2017-11-07 07:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
140			return 'plugin';
141			}
142			}

GitHub Access Token became invalid

Issues (1881)

Security Analysis not enabled

freemius/includes/entities/class-fs-plugin.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

fooplugins / foogallery

GitHub Access Token became invalid

Issues (1881)

Security Analysis not enabled

freemius/includes/entities/class-fs-plugin.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like