Issues in album-stack.php (master) - Issues in master - fooplugins/foogallery - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1881)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

extensions/albums/album-stack.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * FooGallery All-In-One Stack Album template
 */
global $current_foogallery_album;
global $current_foogallery_album_arguments;
global $current_foogallery;
function myFunction($a, $b) {
    // Do something
}
$args = foogallery_album_template_setting( 'thumbnail_dimensions', array() );
$lightbox = foogallery_album_template_setting( 'lightbox', 'unknown' );
$random_angle = foogallery_album_template_setting( 'random_angle', 'false' );
$gutter = foogallery_album_template_setting( 'gutter', '40' );
$delay = foogallery_album_template_setting( 'delay', '0' );
$pile_angles = foogallery_album_template_setting( 'pile_angles', '2' );
if ( !function_exists( 'foogallery_album_all_in_one_stack_render_gallery_attachment' ) ) {
	function foogallery_album_all_in_one_stack_render_gallery_attachment( $gallery, $attachment, $args, $lightbox ) {
		echo '<li data-pile="' . esc_attr( $gallery->name ) . '">';
		$args['link_attributes']['rel']   = 'lightbox[' . $gallery->ID . ']';
		$args['link_attributes']['class'] = apply_filters( 'foogallery_album_stack_link_class_name', $lightbox );
		echo $attachment->html( $args, false, false );
		if ( $attachment->caption ) {
			echo '<span class="tp-info"><span>' . wp_filter_nohtml_kses( $attachment->caption ) . '</span></span>';
		}
		echo $attachment->html_img( $args );
		echo '</a>';
		echo '</li>';
	}
}
?>
<div id="foogallery-album-<?php echo $current_foogallery_album->ID; ?>" class="foogallery-container foogallery-stack-album">
	<div class="topbar">
		<span id="foogallery-stack-album-back-<?php echo $current_foogallery_album->ID; ?>" class="back">&larr;</span>
		<h2><?php echo $current_foogallery_album->name; ?></h2><h3 id="foogallery-stack-album-gallery-<?php echo $current_foogallery_album->ID; ?>"></h3>
	</div>
	<ul id="foogallery-stack-album-<?php echo $current_foogallery_album->ID; ?>" class="tp-grid">
		<?php
		foreach ( $current_foogallery_album->galleries() as $gallery ) {
			$current_foogallery = $gallery;
			$featured_attachment = $gallery->featured_attachment();
			//render the featured attachment first
			foogallery_album_all_in_one_stack_render_gallery_attachment( $gallery, $featured_attachment, $args, $lightbox );

			foreach ( $gallery->attachments() as $attachment ) {
				if ( $featured_attachment->ID !== $attachment->ID ) {
					//render all but the featured attachment
					foogallery_album_all_in_one_stack_render_gallery_attachment( $gallery, $attachment, $args, $lightbox );
				}
			}
		}
		?>
	</ul>
</div>
<script type="text/javascript">
	jQuery(function($) {

		var $grid = $( '#foogallery-stack-album-<?php echo $current_foogallery_album->ID; ?>' ),
			$name = $( '#foogallery-stack-album-gallery-<?php echo $current_foogallery_album->ID; ?>' ),
			$close = $( '#foogallery-stack-album-back-<?php echo $current_foogallery_album->ID; ?>' ),
			$loader = $( '<div class="loader"><i></i><i></i><i></i><i></i><i></i><i></i></div>' ).insertBefore( $grid ),
			stapel = $grid.stapel( {
				delay : <?php echo $delay; ?>,
				randomAngle : <?php echo $random_angle; ?>,
				gutter : <?php echo $gutter; ?>,
				pileAngles : <?php echo $pile_angles; ?>,
				onLoad : function() {
					$loader.remove();
				},
				onBeforeOpen : function( pileName ) {
					$name.html( pileName );
				},
				onAfterOpen : function( pileName ) {
					$close.show();
				}
			} );

		$close.on( 'click', function() {
			$close.hide();
			$name.empty();
			stapel.closePile();
		} );
	} );
</script>


GitHub Access Token became invalid

Issues (1881)

Security Analysis not enabled

extensions/albums/album-stack.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2018-01-10 18:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 15 and the first side effect is on line 5. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/**
3			* FooGallery All-In-One Stack Album template
4			*/
5			global $current_foogallery_album;
6			global $current_foogallery_album_arguments;
7			global $current_foogallery;
			0 ignored issues – show Compatibility Best Practice introduced 2018-03-22 15:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
8			$args = foogallery_album_template_setting( 'thumbnail_dimensions', array() );
9			$lightbox = foogallery_album_template_setting( 'lightbox', 'unknown' );
10			$random_angle = foogallery_album_template_setting( 'random_angle', 'false' );
11			$gutter = foogallery_album_template_setting( 'gutter', '40' );
12			$delay = foogallery_album_template_setting( 'delay', '0' );
13			$pile_angles = foogallery_album_template_setting( 'pile_angles', '2' );
14			if ( !function_exists( 'foogallery_album_all_in_one_stack_render_gallery_attachment' ) ) {
15			function foogallery_album_all_in_one_stack_render_gallery_attachment( $gallery, $attachment, $args, $lightbox ) {
16			echo '<li data-pile="' . esc_attr( $gallery->name ) . '">';
17			$args['link_attributes']['rel'] = 'lightbox[' . $gallery->ID . ']';
18			$args['link_attributes']['class'] = apply_filters( 'foogallery_album_stack_link_class_name', $lightbox );
19			echo $attachment->html( $args, false, false );
20			if ( $attachment->caption ) {
21			echo '<span class="tp-info"><span>' . wp_filter_nohtml_kses( $attachment->caption ) . '</span></span>';
22			}
23			echo $attachment->html_img( $args );
24			echo '</a>';
25			echo '</li>';
26			}
27			}
28			?>
29			<div id="foogallery-album-<?php echo $current_foogallery_album->ID; ?>" class="foogallery-container foogallery-stack-album">
30			<div class="topbar">
31			<span id="foogallery-stack-album-back-<?php echo $current_foogallery_album->ID; ?>" class="back">←</span>
32			<h2><?php echo $current_foogallery_album->name; ?></h2><h3 id="foogallery-stack-album-gallery-<?php echo $current_foogallery_album->ID; ?>"></h3>
33			</div>
34			<ul id="foogallery-stack-album-<?php echo $current_foogallery_album->ID; ?>" class="tp-grid">
35			<?php
36			foreach ( $current_foogallery_album->galleries() as $gallery ) {
37			$current_foogallery = $gallery;
38			$featured_attachment = $gallery->featured_attachment();
39			//render the featured attachment first
40			foogallery_album_all_in_one_stack_render_gallery_attachment( $gallery, $featured_attachment, $args, $lightbox );
41
42			foreach ( $gallery->attachments() as $attachment ) {
43			if ( $featured_attachment->ID !== $attachment->ID ) {
44			//render all but the featured attachment
45			foogallery_album_all_in_one_stack_render_gallery_attachment( $gallery, $attachment, $args, $lightbox );
46			}
47			}
48			}
49			?>
50			</ul>
51			</div>
52			<script type="text/javascript">
53			jQuery(function($) {
54
55			var $grid = $( '#foogallery-stack-album-<?php echo $current_foogallery_album->ID; ?>' ),
56			$name = $( '#foogallery-stack-album-gallery-<?php echo $current_foogallery_album->ID; ?>' ),
57			$close = $( '#foogallery-stack-album-back-<?php echo $current_foogallery_album->ID; ?>' ),
58			$loader = $( '<div class="loader"><i></i><i></i><i></i><i></i><i></i><i></i></div>' ).insertBefore( $grid ),
59			stapel = $grid.stapel( {
60			delay : <?php echo $delay; ?>,
61			randomAngle : <?php echo $random_angle; ?>,
62			gutter : <?php echo $gutter; ?>,
63			pileAngles : <?php echo $pile_angles; ?>,
64			onLoad : function() {
65			$loader.remove();
66			},
67			onBeforeOpen : function( pileName ) {
68			$name.html( pileName );
69			},
70			onAfterOpen : function( pileName ) {
71			$close.show();
72			}
73			} );
74
75			$close.on( 'click', function() {
76			$close.hide();
77			$name.empty();
78			stapel.closePile();
79			} );
80			} );
81			</script>
82

fooplugins / foogallery

GitHub Access Token became invalid

Issues (1881)

Security Analysis not enabled

extensions/albums/album-stack.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like