FooGallery_PixabayClient::search() - Code Metrics - Inspection of "initial demo content code" - fooplugins/foogallery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/demo-content ( 34d331 )

by Brad

created 2018-03-05 03:56 UTC

FooGallery_PixabayClient::search() B

↳ Parent: FooGallery_PixabayClient

Complexity

Conditions	2
Paths	2

Size

Total Lines	24
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	14
nc	2
nop	2
dl	0
loc	24
rs	8.9713
c	0
b	0
f	0

<?php
/**
 * pixabay-php-api
 * PixabayClient API
 *
 * PHP Version 5
 *
 * @category Production
 * @package  Default
 * @author   Philipp Tkachev <[email protected]>
 * @date     12/14/14 9:18 AM
 * @license  https://www.zoonman.com/projects/pixabay/license.txt MIT
 * @version  GIT: 1.0
 * @link     https://www.zoonman.com/projects/pixabay/
 */

/**
 * Class PixabayClient
 * @package Pixabay\PixabayClient
 */
class FooGallery_PixabayClient {
namespace YourVendor;

class YourClass { }
	/**
	 * @var array
	 */
	private $optionsList = [

		'key',
		'response_group',
		'id',
		'q',
		'lang',
		'callback',
		'image_type',
		'orientation',
		'category',
		'min_width',
		'min_height',
		'editors_choice',
		'safesearch',
		'page',
		'per_page',
		'pretty',
		'response_group',
		'order',
		'video_type'
	];

	/**
	 * Root of Pixabay REST API
	 */
	const API_ROOT = 'https://pixabay.com/api/';

	/**
	 * Get Data from Pixabay API
	 *
	 * @return mixed
	 */
	public function search( $key, $query )
	{
		$options['key'] = $key;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
		$options['q'] = $query;

		$url = add_query_arg( array(
			'key' => $key,
			'q' => $query,
		), self::API_ROOT );

		$transient_key = 'foogallery-pixabay-' . esc_attr($query);

		if ( false === ( $response_data = get_transient( $transient_key ) ) ) {
			$response = wp_remote_get( esc_url( $url ) );
			$response_data = wp_remote_retrieve_body( $response );

			$expires = 60 * 60 * 24; //cache for 24 hours

			//Cache the result
			set_transient( $transient_key, $response_data, $expires );
		}

		return json_decode( $response_data, false );
	}
}

1			<?php
2			/**
3			* pixabay-php-api
4			* PixabayClient API
5			*
6			* PHP Version 5
7			*
8			* @category Production
9			* @package Default
10			* @author Philipp Tkachev <[email protected]>
11			* @date 12/14/14 9:18 AM
12			* @license https://www.zoonman.com/projects/pixabay/license.txt MIT
13			* @version GIT: 1.0
14			* @link https://www.zoonman.com/projects/pixabay/
15			*/
16
17			/**
18			* Class PixabayClient
19			* @package Pixabay\PixabayClient
20			*/
21			class FooGallery_PixabayClient {
			0 ignored issues – show Coding Style Compatibility introduced 2018-03-05 03:59 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
22			/**
23			* @var array
24			*/
25			private $optionsList = [
			0 ignored issues – show Unused Code introduced 2018-03-05 03:59 UTC by Report Bug Copy Issue Report The property `$optionsList` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
26			'key',
27			'response_group',
28			'id',
29			'q',
30			'lang',
31			'callback',
32			'image_type',
33			'orientation',
34			'category',
35			'min_width',
36			'min_height',
37			'editors_choice',
38			'safesearch',
39			'page',
40			'per_page',
41			'pretty',
42			'response_group',
43			'order',
44			'video_type'
45			];
46
47			/**
48			* Root of Pixabay REST API
49			*/
50			const API_ROOT = 'https://pixabay.com/api/';
51
52			/**
53			* Get Data from Pixabay API
54			*
55			* @return mixed
56			*/
57			public function search( $key, $query )
58			{
59			$options['key'] = $key;
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-03-05 03:59 UTC by Report Bug Copy Issue Report `$options` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$options = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
60			$options['q'] = $query;
61
62			$url = add_query_arg( array(
63			'key' => $key,
64			'q' => $query,
65			), self::API_ROOT );
66
67			$transient_key = 'foogallery-pixabay-' . esc_attr($query);
68
69			if ( false === ( $response_data = get_transient( $transient_key ) ) ) {
70			$response = wp_remote_get( esc_url( $url ) );
71			$response_data = wp_remote_retrieve_body( $response );
72
73			$expires = 60 * 60 * 24; //cache for 24 hours
74
75			//Cache the result
76			set_transient( $transient_key, $response_data, $expires );
77			}
78
79			return json_decode( $response_data, false );
80			}
81			}

fooplugins / foogallery

GitHub Access Token became invalid

Push — feature/demo-content ( 34d331 )

FooGallery_PixabayClient::search() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like