FooGallery_Pro_Advanced_Gallery_Settings

Complexity

Total Complexity

6

Size/Duplication

Total Lines	85
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	add_advanced_fields()	0	36	1
A	add_data_options()	0	19	4

<?php
/**
 * Class for adding advanced settings to all gallery templates
 * Date: 11/09/2018
 */
if ( ! class_exists( 'FooGallery_Pro_Advanced_Gallery_Settings' ) ) {

	class FooGallery_Pro_Advanced_Gallery_Settings {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

		function __construct() {

It is generally recommended to explicitly declare the visibility for methods.

			//add fields to all templates
			add_filter( 'foogallery_override_gallery_template_fields', array( $this, 'add_advanced_fields' ), 10, 2 );

			//add data options
			add_filter( 'foogallery_build_container_data_options', array( $this, 'add_data_options' ), 10, 3 );
		}

		/**
		 * Add fields to the gallery template
		 *
		 * @param $fields
		 * @param $template
		 *
		 * @return array
		 */
		function add_advanced_fields( $fields, $template ) {

The parameter $template is not used and could be removed.

It is generally recommended to explicitly declare the visibility for methods.

			$fields[] = array(
				'id'       => 'state',
				'title'    => __( 'State', 'foogallery' ),
				'desc'     => __( 'Allow the gallery to keep state for both paging and filtering. When enabled, changing the page or filter will alter the URL.', 'foogallery' ),
				'section'  => __( 'Advanced', 'foogallery' ),
				'type'     => 'radio',
				'default'  => 'no',
				'spacer'   => '<span class="spacer"></span>',
				'choices'  => array(
					'no'  => __( 'Disabled', 'foogallery' ),
					'yes'   => __( 'Enabled', 'foogallery' ),
				),
//				'row_data' => array(

46% of this comment could be valid code. Did you maybe forget this after debugging?

//					'data-foogallery-change-selector' => 'input:radio',
//					'data-foogallery-value-selector'  => 'input:checked',
//					'data-foogallery-preview'         => 'class'
//				)
			);

			$fields[] = array(
				'id'       => 'custom_settings',
				'title'    => __( 'Custom Settings', 'foogallery' ),
				'desc'     => __( 'Add any custom settings to the gallery which will be merged with existing settings.', 'foogallery' ),
				'section'  => __( 'Advanced', 'foogallery' ),
				'type'     => 'textarea',
				'default'  => '',
//				'row_data' => array(

46% of this comment could be valid code. Did you maybe forget this after debugging?

//					'data-foogallery-change-selector' => 'input:radio',
//					'data-foogallery-value-selector'  => 'input:checked',
//					'data-foogallery-preview'         => 'class'
//				)
			);

			return $fields;
		}

		/**
		 * Add the required data options
		 *
		 * @param $options
		 * @param $gallery    FooGallery
		 *
		 * @param $attributes array
		 *
		 * @return array
		 */
		function add_data_options($options, $gallery, $attributes) {

The parameter $gallery is not used and could be removed.

The parameter $attributes is not used and could be removed.

It is generally recommended to explicitly declare the visibility for methods.

			$enable_state = foogallery_gallery_template_setting( 'state', 'no' );

			if ( 'yes' === $enable_state ) {
				$options['state']['enabled'] = true;
			}

			$custom_settings = foogallery_gallery_template_setting( 'custom_settings', '' );

			if ( !empty( $custom_settings ) ) {
				$settings_array = @json_decode($custom_settings, true);

				if ( isset( $settings_array ) ) {
					$options = array_merge_recursive( $options, $settings_array );
				}
			}

			return $options;
		}
	}
}