FooGallery_Retina::add_retina_attributes() - Code Metrics - Inspection of "include retina support with 2x thumb support" - fooplugins/foogallery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/retina-support ( 8a0915 )

by Brad

created 2016-11-01 21:28 UTC

FooGallery_Retina::add_retina_attributes() A

↳ Parent: FooGallery_Retina

Complexity

Conditions	3
Paths	2

Size

Total Lines	19
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	7
nc	2
nop	3
dl	0
loc	19
rs	9.4285
c	0
b	0
f	0

<?php
/*
 * FooGallery Retina Support class
 */

if ( !class_exists( 'FooGallery_Retina' ) ) {

    class FooGallery_Retina {
namespace YourVendor;

class YourClass { }

        function __construct() {

            add_filter('foogallery_attachment_html_image_attributes', array($this, 'add_retina_attributes'), 10, 3);
        }

        /**
         * @param array $attr
         * @param array $args
         * @param FooGalleryAttachment $attachment
         * @return mixed
         */
        function add_retina_attributes($attr, $args, $attachment) {

            global $current_foogallery;
function myFunction($a, $b) {
    // Do something
}

            if ( $current_foogallery && $current_foogallery->gallery_template ) {

                //first check if the gallery template supports Retina thumbs

                //Then get the retina settings, e.g. 2x, 3x, 4x

                //apply scaling to the width and height attributes
                $args['width']  = (int)$args['width'] * 2;
                $args['height'] = (int)$args['height'] * 2;

                //build up the retina attributes
                $attr['srcset'] = $attachment->html_img_src( $args ) . ' ' . $args['width'] . 'w';
            }

            return $attr;
        }
    }
}


GitHub Access Token became invalid

Push — feature/retina-support ( 8a0915 )

FooGallery_Retina::add_retina_attributes() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2			/*
3			* FooGallery Retina Support class
4			*/
5
6			if ( !class_exists( 'FooGallery_Retina' ) ) {
7
8			class FooGallery_Retina {
			0 ignored issues – show Coding Style Compatibility introduced 2016-11-01 21:32 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
9
10			function __construct() {
			0 ignored issues – show Best Practice introduced 2016-11-01 21:32 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
11			add_filter('foogallery_attachment_html_image_attributes', array($this, 'add_retina_attributes'), 10, 3);
12			}
13
14			/**
15			* @param array $attr
16			* @param array $args
17			* @param FooGalleryAttachment $attachment
18			* @return mixed
19			*/
20			function add_retina_attributes($attr, $args, $attachment) {
			0 ignored issues – show Best Practice introduced 2016-11-01 21:32 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
21			global $current_foogallery;
			0 ignored issues – show Compatibility Best Practice introduced 2016-11-01 21:32 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
22
23			if ( $current_foogallery && $current_foogallery->gallery_template ) {
24
25			//first check if the gallery template supports Retina thumbs
26
27			//Then get the retina settings, e.g. 2x, 3x, 4x
28
29			//apply scaling to the width and height attributes
30			$args['width'] = (int)$args['width'] * 2;
31			$args['height'] = (int)$args['height'] * 2;
32
33			//build up the retina attributes
34			$attr['srcset'] = $attachment->html_img_src( $args ) . ' ' . $args['width'] . 'w';
35			}
36
37			return $attr;
38			}
39			}
40			}
41

fooplugins / foogallery

GitHub Access Token became invalid

Push — feature/retina-support ( 8a0915 )

FooGallery_Retina::add_retina_attributes() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like