FooGallery_Pro_Default_Templates

Complexity

Total Complexity

5

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	pro_core_gallery_style()	0	4	2
A	pro_core_gallery_script()	0	4	2

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 7 and the first side effect is on line 13.

/**
 * FooGallery Pro Default Templates Class
 */
if ( ! class_exists( 'FooGallery_Pro_Default_Templates' ) ) {

	define( 'FOOGALLERY_PRO_DEFAULT_TEMPLATES_URL', plugin_dir_url( __FILE__ ) );
	define( 'FOOGALLERY_PRO_DEFAULT_TEMPLATES_PATH', plugin_dir_path( __FILE__ ) );

	define( 'FOOGALLERY_PRO_DEFAULT_TEMPLATES_SHARED_URL', FOOGALLERY_PRO_DEFAULT_TEMPLATES_URL . 'shared/' );
	define( 'FOOGALLERY_PRO_DEFAULT_TEMPLATES_SHARED_PATH', FOOGALLERY_PRO_DEFAULT_TEMPLATES_PATH . 'shared/' );

	require_once( FOOGALLERY_PRO_DEFAULT_TEMPLATES_PATH . 'polaroid/class-polaroid-gallery-template.php' );

	class FooGallery_Pro_Default_Templates {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

		function __construct() {

It is generally recommended to explicitly declare the visibility for methods.

			new FooGallery_Polaroid_Gallery_Template();

			add_filter( 'foogallery_core_gallery_style', array( $this, 'pro_core_gallery_style' ) );
			add_filter( 'foogallery_core_gallery_script', array( $this, 'pro_core_gallery_script' ) );
		}

		/***
		 * Return the path to the PRO core gallery stylesheet
		 */
		function pro_core_gallery_style( $url ){

The parameter $url is not used and could be removed.

It is generally recommended to explicitly declare the visibility for methods.

			$filename = foogallery_get_setting( 'enable_debugging', false ) ? '' : '.min';
			return FOOGALLERY_PRO_DEFAULT_TEMPLATES_SHARED_URL . 'css/foogallery' . $filename . '.css';
		}

		/***
		 * Return the path to the PRO core gallery script
		 */
		function pro_core_gallery_script( $url ){

The parameter $url is not used and could be removed.

It is generally recommended to explicitly declare the visibility for methods.

			$filename = foogallery_get_setting( 'enable_debugging', false ) ? '' : '.min';
			return FOOGALLERY_DEFAULT_TEMPLATES_EXTENSION_SHARED_URL . 'js/foogallery' . $filename . '.js';
		}
	}
}