FS_Payment

Complexity

Total Complexity

5

Size/Duplication

Total Lines	98
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	1

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	get_type()	0	3	1
A	is_refund()	0	3	2
A	is_migrated()	0	3	1

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 13 and the first side effect is on line 10.

    /**
     * @package     Freemius
     * @copyright   Copyright (c) 2016, Freemius, Inc.
     * @license     https://www.gnu.org/licenses/gpl-3.0.html GNU General Public License Version 3
     * @since       1.0.0
     */

    if ( ! defined( 'ABSPATH' ) ) {
        exit;
    }

    class FS_Payment extends FS_Entity {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

        #region Properties

        /**
         * @var number
         */
        public $plugin_id;
        /**
         * @var number
         */
        public $user_id;
        /**
         * @var number
         */
        public $install_id;
        /**
         * @var number
         */
        public $subscription_id;
        /**
         * @var number
         */
        public $plan_id;
        /**
         * @var number
         */
        public $license_id;
        /**
         * @var float
         */
        public $gross;
        /**
         * @var number
         */
        public $bound_payment_id;
        /**
         * @var string
         */
        public $external_id;
        /**
         * @var string
         */
        public $gateway;
        /**
         * @var string ISO 3166-1 alpha-2 - two-letter country code.
         *
         * @link http://www.wikiwand.com/en/ISO_3166-1_alpha-2
         */
        public $country_code;
        /**
         * @var string
         */
        public $vat_id;
        /**
         * @var float Actual Tax / VAT in $$$
         */
        public $vat;
        /**
         * @var int Payment source.
         */
        public $source = 0;

        #endregion Properties

        /**
         * @param object|bool $payment
         */
        function __construct( $payment = false ) {

It is generally recommended to explicitly declare the visibility for methods.

            parent::__construct( $payment );
        }

        static function get_type() {

It is generally recommended to explicitly declare the visibility for methods.

            return 'payment';
        }

        /**
         * @author Vova Feldman (@svovaf)
         * @since  1.0.0
         *
         * @return bool
         */
        function is_refund() {

It is generally recommended to explicitly declare the visibility for methods.

            return ( parent::is_valid_id( $this->bound_payment_id ) && 0 > $this->gross );

It seems like you call parent on a different method (is_valid_id() instead of is_refund()). Are you sure this is correct? If so, you might want to change this to $this->is_valid_id().

        }

        /**
         * Checks if the payment was migrated from another platform.
         *
         * @author Vova Feldman (@svovaf)
         * @since  2.0.2
         *
         * @return bool
         */
        function is_migrated() {

It is generally recommended to explicitly declare the visibility for methods.

            return ( 0 != $this->source );
        }
    }