FooGallery_Extensions_Loader::load_active_extensions() - Code Metrics - Inspection of "Merge branch 'release/1.4.24'" - fooplugins/foogallery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b0f362...88f370 )

by Brad

created 2018-03-22 15:34 UTC

load_active_extensions() B

↳ Parent: FooGallery_Extensions_Loader

Complexity

Conditions	6
Paths	7

Size

Total Lines	22
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	6
eloc	13
nc	7
nop	0
dl	0
loc	22
rs	8.6737
c	0
b	0
f	0

<?php

if ( ! class_exists( 'FooGallery_Extensions_Loader' ) ) {
	class FooGallery_Extensions_Loader {
namespace YourVendor;

class YourClass { }

		function __construct() {

			add_action( 'plugins_loaded', array( $this, 'load_active_extensions' ) );
		}

		/**
		 * Load all FooGallery extensions that have been activated.
		 * For each extension, create an instance of the extension class and add it to a global extensions array
		 */
		function load_active_extensions() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
			$action = foo_safe_get( $_POST, 'action');
			if ( 'deactivate' === $action || 'heartbeat' === $action ) { return; }

			if ( ! function_exists( 'get_current_screen' ) ) {
				require_once(ABSPATH . 'wp-admin/includes/screen.php');
			}

			$api               = new FooGallery_Extensions_API();
			$active_extensions = $api->get_active_extensions();
			foreach ( $active_extensions as $slug => $class ) {
				try {
					$this->load_extension( $slug, $class );
				}
				catch (Exception $e) {
					$error = $e;
					$something = $error;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
				}
			}

			//What if no extensions were loaded?
		}

		function load_extension( $slug, $class ) {

			global $foogallery_extensions;
function myFunction($a, $b) {
    // Do something
}
			global $foogallery_currently_loading;
function myFunction($a, $b) {
    // Do something
}
			if ( is_null( $foogallery_extensions ) ) {
				$foogallery_extensions = array();
			}
			if ( class_exists( $class ) && !array_key_exists( $slug, $foogallery_extensions ) ) {
				$foogallery_currently_loading = $slug;
				$instance = new $class();
				$foogallery_extensions[ $slug ] = $instance;
			}
		}

		function handle_load_exceptions( $errno, $errstr, $errfile, $errline ) {

			global $foogallery_currently_loading;
function myFunction($a, $b) {
    // Do something
}
			$api = new FooGallery_Extensions_API();
			$api->deactivate( $foogallery_currently_loading, false, true );

			//don't execute PHP internal error handler
			return true;
		}
	}
}


1			<?php
2
3			if ( ! class_exists( 'FooGallery_Extensions_Loader' ) ) {
4			class FooGallery_Extensions_Loader {
			0 ignored issues – show Coding Style Compatibility introduced 2017-03-21 17:22 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
5
6			function __construct() {
			0 ignored issues – show Best Practice introduced 2017-03-21 17:22 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
7			add_action( 'plugins_loaded', array( $this, 'load_active_extensions' ) );
8			}
9
10			/**
11			* Load all FooGallery extensions that have been activated.
12			* For each extension, create an instance of the extension class and add it to a global extensions array
13			*/
14			function load_active_extensions() {
			0 ignored issues – show Best Practice introduced 2017-03-21 17:22 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Coding Style introduced 2018-02-26 18:29 UTC by Report Bug Copy Issue Report `load_active_extensions` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
15			$action = foo_safe_get( $_POST, 'action');
16			if ( 'deactivate' === $action \|\| 'heartbeat' === $action ) { return; }
17
18			if ( ! function_exists( 'get_current_screen' ) ) {
19			require_once(ABSPATH . 'wp-admin/includes/screen.php');
20			}
21
22			$api = new FooGallery_Extensions_API();
23			$active_extensions = $api->get_active_extensions();
24			foreach ( $active_extensions as $slug => $class ) {
25			try {
26			$this->load_extension( $slug, $class );
27			}
28			catch (Exception $e) {
29			$error = $e;
30			$something = $error;
			0 ignored issues – show Unused Code introduced 2018-02-26 18:29 UTC by Report Bug Copy Issue Report `$something` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
31			}
32			}
33
34			//What if no extensions were loaded?
35			}
36
37			function load_extension( $slug, $class ) {
			0 ignored issues – show Best Practice introduced 2017-03-21 17:22 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
38			global $foogallery_extensions;
			0 ignored issues – show Compatibility Best Practice introduced 2017-03-21 17:22 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
39			global $foogallery_currently_loading;
			0 ignored issues – show Compatibility Best Practice introduced 2017-03-21 17:22 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
40			if ( is_null( $foogallery_extensions ) ) {
41			$foogallery_extensions = array();
42			}
43			if ( class_exists( $class ) && !array_key_exists( $slug, $foogallery_extensions ) ) {
44			$foogallery_currently_loading = $slug;
45			$instance = new $class();
46			$foogallery_extensions[ $slug ] = $instance;
47			}
48			}
49
50			function handle_load_exceptions( $errno, $errstr, $errfile, $errline ) {
			0 ignored issues – show Unused Code introduced 2017-03-21 17:22 UTC by Report Bug Copy Issue Report The parameter `$errno` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-03-21 17:22 UTC by Report Bug Copy Issue Report The parameter `$errstr` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-03-21 17:22 UTC by Report Bug Copy Issue Report The parameter `$errfile` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-03-21 17:22 UTC by Report Bug Copy Issue Report The parameter `$errline` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Best Practice introduced 2017-03-21 17:22 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
51			global $foogallery_currently_loading;
			0 ignored issues – show Compatibility Best Practice introduced 2017-03-21 17:22 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
52			$api = new FooGallery_Extensions_API();
53			$api->deactivate( $foogallery_currently_loading, false, true );
54
55			//don't execute PHP internal error handler
56			return true;
57			}
58			}
59			}
60

fooplugins / foogallery

GitHub Access Token became invalid

Push — master ( b0f362...88f370 )

load_active_extensions() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like