FooGallery_Retina::__construct() - Code Metrics - Inspection of "Merge branch 'feature/retina-support' into develop" - fooplugins/foogallery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 4d0c63...e5739d )

by Brad

created 2016-12-06 07:24 UTC

FooGallery_Retina::__construct() A

↳ Parent: FooGallery_Retina

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php
/*
 * FooGallery Retina Support class
 */

if ( !class_exists( 'FooGallery_Retina' ) ) {

    class FooGallery_Retina {
namespace YourVendor;

class YourClass { }

        function __construct() {

            add_filter('foogallery_attachment_html_image_attributes', array($this, 'add_retina_attributes'), 10, 3);
        }

        /**
         * @param array $attr
         * @param array $args
         * @param FooGalleryAttachment $attachment
         * @return mixed
         */
        function add_retina_attributes($attr, $args, $attachment) {

            global $current_foogallery;
function myFunction($a, $b) {
    // Do something
}

            if ( $current_foogallery && $current_foogallery->gallery_template ) {

                //first check if the gallery template supports Retina thumbs
                if ( $current_foogallery->retina ) {
                    $srcset = array();

                    $original_width = intval( $args['width'] );
                    $original_height = intval( $args['height'] );

                    foreach ( foogallery_retina_options() as $pixel_density ) {
                        $pixel_density_supported = array_key_exists( $pixel_density, $current_foogallery->retina ) ? ('true' === $current_foogallery->retina[$pixel_density]) : false;

                        if ( $pixel_density_supported ) {
                            $pixel_density_int = intval( str_replace( 'x', '', $pixel_density ) );

                            //apply scaling to the width and height attributes
                            $retina_width  = $original_width * $pixel_density_int;
                            $retina_height = $original_height * $pixel_density_int;

                            //if the new dimensions are smaller than the full size image dimensions then allow the retina thumb
                            if ( $retina_width < $attachment->width &&
                                $retina_height < $attachment->height ) {
                                $args['width'] = $retina_width;
                                $args['height'] = $retina_height;

                                //build up the retina attributes
                                $srcset[] = $attachment->html_img_src( $args ) . ' ' . $retina_width . 'w';
                            }
                        }
                    }

                    if ( count( $srcset ) ) {
                        $attr['srcset'] = implode( ',', $srcset );
                    }
                }
            }

            return $attr;
        }
    }
}


1			<?php
2			/*
3			* FooGallery Retina Support class
4			*/
5
6			if ( !class_exists( 'FooGallery_Retina' ) ) {
7
8			class FooGallery_Retina {
			0 ignored issues – show Coding Style Compatibility introduced 2016-11-01 21:32 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
9
10			function __construct() {
			0 ignored issues – show Best Practice introduced 2016-11-01 21:32 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
11			add_filter('foogallery_attachment_html_image_attributes', array($this, 'add_retina_attributes'), 10, 3);
12			}
13
14			/**
15			* @param array $attr
16			* @param array $args
17			* @param FooGalleryAttachment $attachment
18			* @return mixed
19			*/
20			function add_retina_attributes($attr, $args, $attachment) {
			0 ignored issues – show Best Practice introduced 2016-11-01 21:32 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
21			global $current_foogallery;
			0 ignored issues – show Compatibility Best Practice introduced 2016-11-01 21:32 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
22
23			if ( $current_foogallery && $current_foogallery->gallery_template ) {
24
25			//first check if the gallery template supports Retina thumbs
26			if ( $current_foogallery->retina ) {
27			$srcset = array();
28
29			$original_width = intval( $args['width'] );
30			$original_height = intval( $args['height'] );
31
32			foreach ( foogallery_retina_options() as $pixel_density ) {
33			$pixel_density_supported = array_key_exists( $pixel_density, $current_foogallery->retina ) ? ('true' === $current_foogallery->retina[$pixel_density]) : false;
34
35			if ( $pixel_density_supported ) {
36			$pixel_density_int = intval( str_replace( 'x', '', $pixel_density ) );
37
38			//apply scaling to the width and height attributes
39			$retina_width = $original_width * $pixel_density_int;
40			$retina_height = $original_height * $pixel_density_int;
41
42			//if the new dimensions are smaller than the full size image dimensions then allow the retina thumb
43			if ( $retina_width < $attachment->width &&
44			$retina_height < $attachment->height ) {
45			$args['width'] = $retina_width;
46			$args['height'] = $retina_height;
47
48			//build up the retina attributes
49			$srcset[] = $attachment->html_img_src( $args ) . ' ' . $retina_width . 'w';
50			}
51			}
52			}
53
54			if ( count( $srcset ) ) {
55			$attr['srcset'] = implode( ',', $srcset );
56			}
57			}
58			}
59
60			return $attr;
61			}
62			}
63			}
64

fooplugins / foogallery

GitHub Access Token became invalid

Push — develop ( 4d0c63...e5739d )

FooGallery_Retina::__construct() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like