fooplugins /
foogallery
Complex classes like FS_Storage often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use FS_Storage, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 22 | class FS_Storage { |
||
| 23 | /** |
||
| 24 | * @var FS_Storage[] |
||
| 25 | */ |
||
| 26 | private static $_instances = array(); |
||
| 27 | /** |
||
| 28 | * @var FS_Key_Value_Storage Site level storage. |
||
| 29 | */ |
||
| 30 | private $_storage; |
||
| 31 | |||
| 32 | /** |
||
| 33 | * @var FS_Key_Value_Storage Network level storage. |
||
| 34 | */ |
||
| 35 | private $_network_storage; |
||
| 36 | |||
| 37 | /** |
||
| 38 | * @var string |
||
| 39 | */ |
||
| 40 | private $_module_type; |
||
| 41 | |||
| 42 | /** |
||
| 43 | * @var string |
||
| 44 | */ |
||
| 45 | private $_module_slug; |
||
| 46 | |||
| 47 | /** |
||
| 48 | * @var int The ID of the blog that is associated with the current site level options. |
||
| 49 | */ |
||
| 50 | private $_blog_id = 0; |
||
| 51 | |||
| 52 | /** |
||
| 53 | * @var bool |
||
| 54 | */ |
||
| 55 | private $_is_multisite; |
||
| 56 | |||
| 57 | /** |
||
| 58 | * @var bool |
||
| 59 | */ |
||
| 60 | private $_is_network_active = false; |
||
| 61 | |||
| 62 | /** |
||
| 63 | * @var bool |
||
| 64 | */ |
||
| 65 | private $_is_delegated_connection = false; |
||
| 66 | |||
| 67 | /** |
||
| 68 | * @var array { |
||
| 69 | * @key string Option name. |
||
| 70 | * @value int If 0 store on the network level. If 1, store on the network level only if module was network level activated. If 2, store on the network level only if network activated and NOT delegated the connection. |
||
| 71 | * } |
||
| 72 | */ |
||
| 73 | private static $_NETWORK_OPTIONS_MAP; |
||
| 74 | |||
| 75 | /** |
||
| 76 | * @author Leo Fajardo (@leorw) |
||
| 77 | * |
||
| 78 | * @param string $module_type |
||
| 79 | * @param string $slug |
||
| 80 | * |
||
| 81 | * @return FS_Storage |
||
| 82 | */ |
||
| 83 | static function instance( $module_type, $slug ) { |
||
| 92 | |||
| 93 | /** |
||
| 94 | * @author Leo Fajardo (@leorw) |
||
| 95 | * |
||
| 96 | * @param string $module_type |
||
| 97 | * @param string $slug |
||
| 98 | */ |
||
| 99 | private function __construct( $module_type, $slug ) { |
||
| 111 | |||
| 112 | /** |
||
| 113 | * Tells this storage wrapper class that the context plugin is network active. This flag will affect how values |
||
| 114 | * are retrieved/stored from/into the storage. |
||
| 115 | * |
||
| 116 | * @author Leo Fajardo (@leorw) |
||
| 117 | * |
||
| 118 | * @param bool $is_network_active |
||
| 119 | * @param bool $is_delegated_connection |
||
| 120 | */ |
||
| 121 | function set_network_active( $is_network_active = true, $is_delegated_connection = false ) { |
||
| 125 | |||
| 126 | /** |
||
| 127 | * Switch the context of the site level storage manager. |
||
| 128 | * |
||
| 129 | * @author Vova Feldman (@svovaf) |
||
| 130 | * @since 2.0.0 |
||
| 131 | * |
||
| 132 | * @param int $blog_id |
||
| 133 | */ |
||
| 134 | function set_site_blog_context( $blog_id ) { |
||
| 139 | |||
| 140 | /** |
||
| 141 | * @author Leo Fajardo (@leorw) |
||
| 142 | * |
||
| 143 | * @param string $key |
||
| 144 | * @param mixed $value |
||
| 145 | * @param null|bool|int $network_level_or_blog_id When an integer, use the given blog storage. When `true` use the multisite storage (if there's a network). When `false`, use the current context blog storage. When `null`, the decision which storage to use (MS vs. Current S) will be handled internally and determined based on the $option (based on self::$_BINARY_MAP). |
||
| 146 | * @param bool $flush |
||
| 147 | */ |
||
| 148 | function store( $key, $value, $network_level_or_blog_id = null, $flush = true ) { |
||
| 156 | |||
| 157 | /** |
||
| 158 | * @author Leo Fajardo (@leorw) |
||
| 159 | * |
||
| 160 | * @param bool $store |
||
| 161 | * @param string[] $exceptions Set of keys to keep and not clear. |
||
| 162 | * @param int|null|bool $network_level_or_blog_id |
||
| 163 | */ |
||
| 164 | function clear_all( $store = true, $exceptions = array(), $network_level_or_blog_id = null ) { |
||
| 180 | |||
| 181 | /** |
||
| 182 | * @author Leo Fajardo (@leorw) |
||
| 183 | * |
||
| 184 | * @param string $key |
||
| 185 | * @param bool $store |
||
| 186 | * @param null|bool|int $network_level_or_blog_id When an integer, use the given blog storage. When `true` use the multisite storage (if there's a network). When `false`, use the current context blog storage. When `null`, the decision which storage to use (MS vs. Current S) will be handled internally and determined based on the $option (based on self::$_BINARY_MAP). |
||
| 187 | */ |
||
| 188 | function remove( $key, $store = true, $network_level_or_blog_id = null ) { |
||
| 196 | |||
| 197 | /** |
||
| 198 | * @author Leo Fajardo (@leorw) |
||
| 199 | * |
||
| 200 | * @param string $key |
||
| 201 | * @param mixed $default |
||
| 202 | * @param null|bool|int $network_level_or_blog_id When an integer, use the given blog storage. When `true` use the multisite storage (if there's a network). When `false`, use the current context blog storage. When `null`, the decision which storage to use (MS vs. Current S) will be handled internally and determined based on the $option (based on self::$_BINARY_MAP). |
||
| 203 | * |
||
| 204 | * @return mixed |
||
| 205 | */ |
||
| 206 | function get( $key, $default = false, $network_level_or_blog_id = null ) { |
||
| 215 | |||
| 216 | /** |
||
| 217 | * Multisite activated: |
||
| 218 | * true: Save network storage. |
||
| 219 | * int: Save site specific storage. |
||
| 220 | * false|0: Save current site storage. |
||
| 221 | * null: Save network and current site storage. |
||
| 222 | * Site level activated: |
||
| 223 | * Save site storage. |
||
| 224 | * |
||
| 225 | * @author Vova Feldman (@svovaf) |
||
| 226 | * @since 2.0.0 |
||
| 227 | * |
||
| 228 | * @param bool|int|null $network_level_or_blog_id |
||
| 229 | */ |
||
| 230 | function save( $network_level_or_blog_id = null ) { |
||
| 242 | |||
| 243 | /** |
||
| 244 | * @author Vova Feldman (@svovaf) |
||
| 245 | * @since 2.0.0 |
||
| 246 | * |
||
| 247 | * @return string |
||
| 248 | */ |
||
| 249 | function get_module_slug() { |
||
| 252 | |||
| 253 | /** |
||
| 254 | * @author Vova Feldman (@svovaf) |
||
| 255 | * @since 2.0.0 |
||
| 256 | * |
||
| 257 | * @return string |
||
| 258 | */ |
||
| 259 | function get_module_type() { |
||
| 262 | |||
| 263 | /** |
||
| 264 | * Migration script to the new storage data structure that is network compatible. |
||
| 265 | * |
||
| 266 | * IMPORTANT: |
||
| 267 | * This method should be executed only after it is determined if this is a network |
||
| 268 | * level compatible product activation. |
||
| 269 | * |
||
| 270 | * @author Vova Feldman (@svovaf) |
||
| 271 | * @since 2.0.0 |
||
| 272 | */ |
||
| 273 | function migrate_to_network() { |
||
| 318 | |||
| 319 | #-------------------------------------------------------------------------------- |
||
| 320 | #region Helper Methods |
||
| 321 | #-------------------------------------------------------------------------------- |
||
| 322 | |||
| 323 | /** |
||
| 324 | * We don't want to load the map right away since it's not even needed in a non-MS environment. |
||
| 325 | * |
||
| 326 | * Example: |
||
| 327 | * array( |
||
| 328 | * 'option1' => 0, // Means that the option should always be stored on the network level. |
||
| 329 | * 'option2' => 1, // Means that the option should be stored on the network level only when the module was network level activated. |
||
| 330 | * 'option2' => 2, // Means that the option should be stored on the network level only when the module was network level activated AND the connection was NOT delegated. |
||
| 331 | * 'option3' => 3, // Means that the option should always be stored on the site level. |
||
| 332 | * ) |
||
| 333 | * |
||
| 334 | * @author Vova Feldman (@svovaf) |
||
| 335 | * @since 2.0.0 |
||
| 336 | */ |
||
| 337 | private static function load_network_options_map() { |
||
| 389 | |||
| 390 | /** |
||
| 391 | * This method will and should only be executed when is_multisite() is true. |
||
| 392 | * |
||
| 393 | * @author Vova Feldman (@svovaf) |
||
| 394 | * @since 2.0.0 |
||
| 395 | * |
||
| 396 | * @param string $key |
||
| 397 | * |
||
| 398 | * @return bool|mixed |
||
| 399 | */ |
||
| 400 | private function is_multisite_option( $key ) { |
||
| 436 | |||
| 437 | /** |
||
| 438 | * @author Leo Fajardo |
||
| 439 | * |
||
| 440 | * @param string $key |
||
| 441 | * @param null|bool|int $network_level_or_blog_id When an integer, use the given blog storage. When `true` use the multisite storage (if there's a network). When `false`, use the current context blog storage. When `null`, the decision which storage to use (MS vs. Current S) will be handled internally and determined based on the $option (based on self::$_BINARY_MAP). |
||
| 442 | * |
||
| 443 | * @return bool |
||
| 444 | */ |
||
| 445 | private function should_use_network_storage( $key, $network_level_or_blog_id = null ) { |
||
| 464 | |||
| 465 | /** |
||
| 466 | * @author Vova Feldman (@svovaf) |
||
| 467 | * @since 2.0.0 |
||
| 468 | * |
||
| 469 | * @param int $blog_id |
||
| 470 | * |
||
| 471 | * @return \FS_Key_Value_Storage |
||
| 472 | */ |
||
| 473 | private function get_site_storage( $blog_id = 0 ) { |
||
| 487 | |||
| 488 | #endregion |
||
| 489 | |||
| 490 | #-------------------------------------------------------------------------------- |
||
| 491 | #region Magic methods |
||
| 492 | #-------------------------------------------------------------------------------- |
||
| 493 | |||
| 494 | function __set( $k, $v ) { |
||
| 501 | |||
| 502 | function __isset( $k ) { |
||
| 507 | |||
| 508 | function __unset( $k ) { |
||
| 515 | |||
| 516 | function __get( $k ) { |
||
| 521 | |||
| 522 | #endregion |
||
| 523 | } |
Loading history...
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.