FooGallery_Pro_Gallery_Shortcode_Override

Complexity

Total Complexity

4

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	gallery_shortcode_override_settings()	0	12	1
A	override_gallery_output()	0	13	2

<?php
/**
 * FooGallery Pro Gallery Shortcode Override Class
 */
if ( ! class_exists( 'FooGallery_Pro_Gallery_Shortcode_Override' ) ) {

    class FooGallery_Pro_Gallery_Shortcode_Override {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

        function __construct() {

It is generally recommended to explicitly declare the visibility for methods.

            add_filter( 'foogallery_admin_settings_override', array( $this, 'gallery_shortcode_override_settings' ) );
            add_filter( 'post_gallery', array( $this, 'override_gallery_output' ), 10, 3 );
        }

        /**
         * Create the override
         * @return array
         */
        function gallery_shortcode_override_settings($settings) {

It is generally recommended to explicitly declare the visibility for methods.

            $settings['settings'][] = array(
                'id' => 'override_gallery_shortcode',
                'title' => __('Override Gallery Shortcode', 'foogallery'),
                'desc' => sprintf(__('This will allow you to override all default gallery shortcodes to rather use a %s template. The defaults above will be used when displaying the gallery.', 'foogallery'), foogallery_plugin_name()),
                'type' => 'checkbox',
                'tab' => 'general',
                'section' => __('Shortcodes', 'foogallery')
            );

            return $settings;
        }

        /*
         * Override the gallery shortcode output if enabled
         * @param $output
         * @param $attr
         * @param $instance
         * @return string
         */
        function override_gallery_output( $output, $attr, $instance) {

The parameter $instance is not used and could be removed.

It is generally recommended to explicitly declare the visibility for methods.

            $override_enabled = foogallery_get_setting( 'override_gallery_shortcode');

            if ($override_enabled  === 'on') {
                $shortcode_instance = new FooGallery_Shortcodes();

                $attr['attachment_ids'] = $attr['ids'];

                return $shortcode_instance->render_foogallery_shortcode( $attr );
            }

            return '';
        }
    }
}