Issues in foogallery.php - All Issues - Inspection of "Merge branch 'release/1.6.0'" - fooplugins/foogallery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8970a4...b3ee5f )

by Brad

created 2018-11-09 16:08 UTC

foogallery.php (11 issues)

Labels

Severity

Minor 11

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
Plugin Name: FooGallery
Description: FooGallery is the most intuitive and extensible gallery management tool ever created for WordPress
Version:     1.6.1
Author:      FooPlugins
Plugin URI:  https://foo.gallery
Author URI:  http://fooplugins.com
Text Domain: foogallery
License:     GPL-2.0+
Domain Path: /languages

@fs_premium_only /pro/
 */

// If this file is called directly, abort.
if ( ! defined( 'WPINC' ) ) {
	die;
}

if ( ! class_exists( 'FooGallery_Plugin' ) ) {

	define( 'FOOGALLERY_SLUG', 'foogallery' );
	define( 'FOOGALLERY_PATH', plugin_dir_path( __FILE__ ) );
	define( 'FOOGALLERY_URL', plugin_dir_url( __FILE__ ) );
	define( 'FOOGALLERY_FILE', __FILE__ );
	define( 'FOOGALLERY_VERSION', '1.6.1' );
	define( 'FOOGALLERY_SETTINGS_VERSION', '2' );

	require_once( FOOGALLERY_PATH . 'includes/constants.php' );

	// Create a helper function for easy SDK access.
	function foogallery_fs() {
		global $foogallery_fs;
function myFunction($a, $b) {
    // Do something
}

		if ( ! isset( $foogallery_fs ) ) {
			// Include Freemius SDK.
			require_once dirname(__FILE__) . '/freemius/start.php';

			$foogallery_fs = fs_dynamic_init( array(
				'id'                => '843',
				'slug'              => 'foogallery',
				'type'              => 'plugin',
				'public_key'        => 'pk_d87616455a835af1d0658699d0192',
				'is_premium'        => true,
				'has_paid_plans'    => true,
				'trial'               => array(
					'days'               => 7,
					'is_require_payment' => false,
				),
				'menu'              => array(
					'slug'       => 'edit.php?post_type=' . FOOGALLERY_CPT_GALLERY,
					'first-path' => 'edit.php?post_type=' . FOOGALLERY_CPT_GALLERY . '&page=' . FOOGALLERY_ADMIN_MENU_HELP_SLUG,
					'account'    => true,
					'contact'    => false,
					'support'    => false,
				),
			) );
		}

		return $foogallery_fs;
	}

	// Init Freemius.
	foogallery_fs();

	// Signal that SDK was initiated.
	do_action( 'foogallery_fs_loaded' );


	require_once( FOOGALLERY_PATH . 'includes/foopluginbase/bootstrapper.php' );

	/**
	 * FooGallery_Plugin class
	 *
	 * @package   FooGallery
	 * @author    Brad Vincent <[email protected]>
	 * @license   GPL-2.0+
	 * @link      https://github.com/fooplugins/foogallery
	 * @copyright 2013 FooPlugins LLC
	 */
	class FooGallery_Plugin extends Foo_Plugin_Base_v2_4 {

		private static $instance;

		public static function get_instance() {
			if ( ! isset(self::$instance) && ! (self::$instance instanceof FooGallery_Plugin) ) {
				self::$instance = new FooGallery_Plugin();
			}

			return self::$instance;
		}

		/**
		 * Initialize the plugin by setting localization, filters, and administration functions.
		 */
		private function __construct() {

			//include everything we need!
			require_once( FOOGALLERY_PATH . 'includes/includes.php' );

			register_activation_hook( __FILE__, array( 'FooGallery_Plugin', 'activate' ) );

			//init FooPluginBase
			$this->init( FOOGALLERY_FILE, FOOGALLERY_SLUG, FOOGALLERY_VERSION, 'FooGallery' );

			//setup text domain
			$this->load_plugin_textdomain();

			//setup gallery post type
			new FooGallery_PostTypes();

			//load any extensions
			new FooGallery_Extensions_Loader();

			if ( is_admin() ) {
				new FooGallery_Admin();
				add_action( 'wpmu_new_blog', array( $this, 'set_default_extensions_for_multisite_network_activated' ) );
				add_action( 'admin_page_access_denied', array( $this, 'check_for_access_denied' ) );
				foogallery_fs()->add_filter( 'connect_message_on_update', array( $this, 'override_connect_message_on_update' ), 10, 6 );
				foogallery_fs()->add_filter( 'is_submenu_visible', array( $this, 'is_submenu_visible' ), 10, 2 );
				foogallery_fs()->add_filter( 'hide_account_tabs', '__return_true' );
				add_action( 'foogallery_admin_menu_before', array( $this, 'add_freemius_activation_menu' ) );
			} else {
				new FooGallery_Public();
			}

			new FooGallery_Shortcodes();

			new FooGallery_Thumbnails();

			new FooGallery_Attachment_Filters();

			new FooGallery_Retina();

			new FooGallery_WPThumb_Enhancements();

			new FooGallery_Animated_Gif_Support();

			new FooGallery_Cache();

			new FooGallery_Common_Fields();

			new FooGallery_LazyLoad();

			new FooGallery_Paging();

			new FooGallery_Thumbnail_Dimensions();

			new FooGallery_Attachment_Custom_Class();

			new FooGallery_Upgrade();

			new FooGallery_Compatibility();

			new FooGallery_Extensions_Compatibility();

			new FooGallery_Default_Crop_Position();

			$checker = new FooGallery_Version_Check();
			$checker->wire_up_checker();

            new FooGallery_Widget_Init();

            //include the default templates no matter what!
            new FooGallery_Default_Templates();

			if ( foogallery_fs()->is__premium_only() ) {
				if ( foogallery_fs()->can_use_premium_code() ) {
					require_once FOOGALLERY_PATH . 'pro/foogallery-pro.php';

					new FooGallery_Pro();
				}
			} else {
				add_filter( 'foogallery_extensions_for_view', array( $this, 'add_foogallery_pro_extension' ) );
			}

			//init Gutenberg!
			new FooGallery_Gutenberg();
		}

		function add_foogallery_pro_extension( $extensions ) {


			$extension = array(
				'slug' => 'foogallery-pro',
				'class' => 'FooGallery_Pro',
				'categories' => array( 'Featured', 'Premium' ),
				'title' => 'FooGallery Pro',
				'description' => 'The best gallery plugin for WordPress just got even better!',
				'price' => '$49',
				'author' => 'FooPlugins',
				'author_url' => 'http://fooplugins.com',
				'thumbnail' => 'https://s3.amazonaws.com/foogallery/extensions/foogallerypro.png',
				'tags' => array( 'premium' ),
				'source' => 'fooplugins',
				"download_button" => array(
					"text" => "Start FREE Trial",
					"target" => "_self",
					"href" => foogallery_fs()->checkout_url( WP_FS__PERIOD_ANNUALLY, true ),
					"confirm" => false
				)
			);

			array_unshift( $extensions, $extension );

			return $extensions;
		}

		/**
		 * Checks for the access denied page after we have activated/updated the plugin
		 */
		function check_for_access_denied() {

			global $plugin_page;
function myFunction($a, $b) {
    // Do something
}

			if ( FOOGALLERY_ADMIN_MENU_HELP_SLUG === $plugin_page ||
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
				FOOGALLERY_ADMIN_MENU_SETTINGS_SLUG === $plugin_page ||
				FOOGALLERY_ADMIN_MENU_EXTENSIONS_SLUG === $plugin_page ||
				FOOGALLERY_ADMIN_MENU_SYSTEMINFO_SLUG === $plugin_page) {
				//fs_redirect( 'admin.php?page=' . FOOGALLERY_SLUG );

			}
		}

		/**
		 *
		 */
		function override_connect_message_on_update( $original, $first_name, $plugin_name, $login, $link, $freemius_link ) {


			return
				sprintf( __( 'Hey %s', 'foogallery' ), $first_name ) . '<br>' .
				sprintf(
					__( '<h2>Thank you for updating to %1$s v%5$s!</h2>Our goal with this update is to make %1$s the best gallery plugin for WordPress, but we need your help!<br><br>We have introduced this opt-in so that you can help us improve %1$s by simply clicking <strong>Allow &amp; Continue</strong>.<br><br>If you opt-in, some data about your usage of %1$s will be sent to %4$s. If you skip this, that\'s okay! %1$s will still work just fine.', 'foogallery' ),
					'<b>' . $plugin_name . '</b>',
					'<b>' . $login . '</b>',
					$link,
					$freemius_link,
					FOOGALLERY_VERSION
				);
		}

		function add_freemius_activation_menu() {

			global $foogallery_fs;
function myFunction($a, $b) {
    // Do something
}

			$parent_slug = foogallery_admin_menu_parent_slug();

			if ( ! $foogallery_fs->is_registered() ) {
				add_submenu_page(
					$parent_slug,
					__( 'FooGallery Opt-In', 'foogallery' ),
					__( 'Activation', 'foogallery' ),
					'manage_options',
					'foogallery-optin',
					array( $foogallery_fs, '_connect_page_render' )
				);
			}
		}

		function is_submenu_visible( $visible, $id ) {

			if ( 'addons' === $id ) {
				//hide addons submenu for now
				$visible = false;
			}
			return $visible;
		}

		/**
		 * Set default extensions when a new site is created in multisite and FooGallery is network activated
		 *
		 * @since 1.2.5
		 *
		 * @param int $blog_id The ID of the newly created site
		 */
		public function set_default_extensions_for_multisite_network_activated( $blog_id ) {
			switch_to_blog( $blog_id );

			if ( false === get_option( FOOGALLERY_EXTENSIONS_AUTO_ACTIVATED_OPTIONS_KEY, false ) ) {
				$api = new FooGallery_Extensions_API();

				$api->auto_activate_extensions();

				update_option( FOOGALLERY_EXTENSIONS_AUTO_ACTIVATED_OPTIONS_KEY, true );
			}

			restore_current_blog();
		}

		/**
		 * Fired when the plugin is activated.
		 *
		 * @since    1.0.0
		 *
		 * @param    boolean    $network_wide    True if WPMU superadmin uses
		 *                                       "Network Activate" action, false if
		 *                                       WPMU is disabled or plugin is
		 *                                       activated on an individual blog.
		 */
		public static function activate( $network_wide ) {
			if ( function_exists( 'is_multisite' ) && is_multisite() ) {

				if ( $network_wide  ) {

					// Get all blog ids
					$blog_ids = self::get_blog_ids();
					if ( is_array( $blog_ids ) ) {
						foreach ( $blog_ids as $blog_id ) {

							switch_to_blog( $blog_id );
							self::single_activate();
						}

						restore_current_blog();
					}

				} else {
					self::single_activate();
				}

			} else {
				self::single_activate( false );
			}
		}

		/**
		 * Fired for each blog when the plugin is activated.
		 *
		 * @since    1.0.0
		 */
		private static function single_activate( $multisite = true ) {
			if ( false === get_option( FOOGALLERY_EXTENSIONS_AUTO_ACTIVATED_OPTIONS_KEY, false ) ) {
				$api = new FooGallery_Extensions_API();

				$api->auto_activate_extensions();

				update_option( FOOGALLERY_EXTENSIONS_AUTO_ACTIVATED_OPTIONS_KEY, true );
			}
			if ( false === $multisite ) {
				//Make sure we redirect to the welcome page
				set_transient( FOOGALLERY_ACTIVATION_REDIRECT_TRANSIENT_KEY, true, 30 );
			}

			//force a version check on activation to make sure housekeeping is performed
			foogallery_perform_version_check();
		}

		/**
		 * Get all blog ids of blogs in the current network that are:
		 * - not archived
		 * - not spam
		 * - not deleted
		 *
		 * @since    1.0.0
		 *
		 * @return   array|false    The blog ids, false if no matches.
		 */
		private static function get_blog_ids() {

			if ( function_exists( 'get_sites' ) ) {

				$sites = get_sites();
				$blog_ids = array();
                foreach ( $sites as $site ) {
                    $blog_ids[] = $site->blog_id;
				}
				return $blog_ids;
			} else {
				//pre WP 3.7 - do this the old way!
				global $wpdb;

				// get an array of blog ids
				$sql = "SELECT blog_id FROM $wpdb->blogs WHERE archived = '0' AND spam = '0' AND deleted = '0'";

				return $wpdb->get_col( $sql );
			}
		}
	}
}

FooGallery_Plugin::get_instance();


GitHub Access Token became invalid

Push — master ( 8970a4...b3ee5f )

foogallery.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-02-28 06:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 23 and the first side effect is on line 30. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/*
3			Plugin Name: FooGallery
4			Description: FooGallery is the most intuitive and extensible gallery management tool ever created for WordPress
5			Version: 1.6.1
6			Author: FooPlugins
7			Plugin URI: https://foo.gallery
8			Author URI: http://fooplugins.com
9			Text Domain: foogallery
10			License: GPL-2.0+
11			Domain Path: /languages
12
13			@fs_premium_only /pro/
14			*/
15
16			// If this file is called directly, abort.
17			if ( ! defined( 'WPINC' ) ) {
18			die;
19			}
20
21			if ( ! class_exists( 'FooGallery_Plugin' ) ) {
22
23			define( 'FOOGALLERY_SLUG', 'foogallery' );
24			define( 'FOOGALLERY_PATH', plugin_dir_path( __FILE__ ) );
25			define( 'FOOGALLERY_URL', plugin_dir_url( __FILE__ ) );
26			define( 'FOOGALLERY_FILE', __FILE__ );
27			define( 'FOOGALLERY_VERSION', '1.6.1' );
28			define( 'FOOGALLERY_SETTINGS_VERSION', '2' );
29
30			require_once( FOOGALLERY_PATH . 'includes/constants.php' );
31
32			// Create a helper function for easy SDK access.
33			function foogallery_fs() {
34			global $foogallery_fs;
			0 ignored issues – show Compatibility Best Practice introduced 2017-06-04 19:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
35
36			if ( ! isset( $foogallery_fs ) ) {
37			// Include Freemius SDK.
38			require_once dirname(__FILE__) . '/freemius/start.php';
39
40			$foogallery_fs = fs_dynamic_init( array(
41			'id' => '843',
42			'slug' => 'foogallery',
43			'type' => 'plugin',
44			'public_key' => 'pk_d87616455a835af1d0658699d0192',
45			'is_premium' => true,
46			'has_paid_plans' => true,
47			'trial' => array(
48			'days' => 7,
49			'is_require_payment' => false,
50			),
51			'menu' => array(
52			'slug' => 'edit.php?post_type=' . FOOGALLERY_CPT_GALLERY,
53			'first-path' => 'edit.php?post_type=' . FOOGALLERY_CPT_GALLERY . '&page=' . FOOGALLERY_ADMIN_MENU_HELP_SLUG,
54			'account' => true,
55			'contact' => false,
56			'support' => false,
57			),
58			) );
59			}
60
61			return $foogallery_fs;
62			}
63
64			// Init Freemius.
65			foogallery_fs();
66
67			// Signal that SDK was initiated.
68			do_action( 'foogallery_fs_loaded' );
69
70
71			require_once( FOOGALLERY_PATH . 'includes/foopluginbase/bootstrapper.php' );
72
73			/**
74			* FooGallery_Plugin class
75			*
76			* @package FooGallery
77			* @author Brad Vincent <[email protected]>
78			* @license GPL-2.0+
79			* @link https://github.com/fooplugins/foogallery
80			* @copyright 2013 FooPlugins LLC
81			*/
82			class FooGallery_Plugin extends Foo_Plugin_Base_v2_4 {
83
84			private static $instance;
85
86			public static function get_instance() {
87			if ( ! isset(self::$instance) && ! (self::$instance instanceof FooGallery_Plugin) ) {
88			self::$instance = new FooGallery_Plugin();
89			}
90
91			return self::$instance;
92			}
93
94			/**
95			* Initialize the plugin by setting localization, filters, and administration functions.
96			*/
97			private function __construct() {
98
99			//include everything we need!
100			require_once( FOOGALLERY_PATH . 'includes/includes.php' );
101
102			register_activation_hook( __FILE__, array( 'FooGallery_Plugin', 'activate' ) );
103
104			//init FooPluginBase
105			$this->init( FOOGALLERY_FILE, FOOGALLERY_SLUG, FOOGALLERY_VERSION, 'FooGallery' );
106
107			//setup text domain
108			$this->load_plugin_textdomain();
109
110			//setup gallery post type
111			new FooGallery_PostTypes();
112
113			//load any extensions
114			new FooGallery_Extensions_Loader();
115
116			if ( is_admin() ) {
117			new FooGallery_Admin();
118			add_action( 'wpmu_new_blog', array( $this, 'set_default_extensions_for_multisite_network_activated' ) );
119			add_action( 'admin_page_access_denied', array( $this, 'check_for_access_denied' ) );
120			foogallery_fs()->add_filter( 'connect_message_on_update', array( $this, 'override_connect_message_on_update' ), 10, 6 );
121			foogallery_fs()->add_filter( 'is_submenu_visible', array( $this, 'is_submenu_visible' ), 10, 2 );
122			foogallery_fs()->add_filter( 'hide_account_tabs', '__return_true' );
123			add_action( 'foogallery_admin_menu_before', array( $this, 'add_freemius_activation_menu' ) );
124			} else {
125			new FooGallery_Public();
126			}
127
128			new FooGallery_Shortcodes();
129
130			new FooGallery_Thumbnails();
131
132			new FooGallery_Attachment_Filters();
133
134			new FooGallery_Retina();
135
136			new FooGallery_WPThumb_Enhancements();
137
138			new FooGallery_Animated_Gif_Support();
139
140			new FooGallery_Cache();
141
142			new FooGallery_Common_Fields();
143
144			new FooGallery_LazyLoad();
145
146			new FooGallery_Paging();
147
148			new FooGallery_Thumbnail_Dimensions();
149
150			new FooGallery_Attachment_Custom_Class();
151
152			new FooGallery_Upgrade();
153
154			new FooGallery_Compatibility();
155
156			new FooGallery_Extensions_Compatibility();
157
158			new FooGallery_Default_Crop_Position();
159
160			$checker = new FooGallery_Version_Check();
161			$checker->wire_up_checker();
162
163			new FooGallery_Widget_Init();
164
165			//include the default templates no matter what!
166			new FooGallery_Default_Templates();
167
168			if ( foogallery_fs()->is__premium_only() ) {
169			if ( foogallery_fs()->can_use_premium_code() ) {
170			require_once FOOGALLERY_PATH . 'pro/foogallery-pro.php';
171
172			new FooGallery_Pro();
173			}
174			} else {
175			add_filter( 'foogallery_extensions_for_view', array( $this, 'add_foogallery_pro_extension' ) );
176			}
177
178			//init Gutenberg!
179			new FooGallery_Gutenberg();
180			}
181
182			function add_foogallery_pro_extension( $extensions ) {
			0 ignored issues – show Best Practice introduced 2018-02-06 18:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
183
184			$extension = array(
185			'slug' => 'foogallery-pro',
186			'class' => 'FooGallery_Pro',
187			'categories' => array( 'Featured', 'Premium' ),
188			'title' => 'FooGallery Pro',
189			'description' => 'The best gallery plugin for WordPress just got even better!',
190			'price' => '$49',
191			'author' => 'FooPlugins',
192			'author_url' => 'http://fooplugins.com',
193			'thumbnail' => 'https://s3.amazonaws.com/foogallery/extensions/foogallerypro.png',
194			'tags' => array( 'premium' ),
195			'source' => 'fooplugins',
196			"download_button" => array(
197			"text" => "Start FREE Trial",
198			"target" => "_self",
199			"href" => foogallery_fs()->checkout_url( WP_FS__PERIOD_ANNUALLY, true ),
200			"confirm" => false
201			)
202			);
203
204			array_unshift( $extensions, $extension );
205
206			return $extensions;
207			}
208
209			/**
210			* Checks for the access denied page after we have activated/updated the plugin
211			*/
212			function check_for_access_denied() {
			0 ignored issues – show Best Practice introduced 2017-06-13 18:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
213			global $plugin_page;
			0 ignored issues – show Compatibility Best Practice introduced 2017-06-13 18:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
214
215			if ( FOOGALLERY_ADMIN_MENU_HELP_SLUG === $plugin_page \|\|
			0 ignored issues – show Unused Code introduced 2017-11-07 07:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
216			FOOGALLERY_ADMIN_MENU_SETTINGS_SLUG === $plugin_page \|\|
217			FOOGALLERY_ADMIN_MENU_EXTENSIONS_SLUG === $plugin_page \|\|
218			FOOGALLERY_ADMIN_MENU_SYSTEMINFO_SLUG === $plugin_page) {
219			//fs_redirect( 'admin.php?page=' . FOOGALLERY_SLUG );
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-11-07 07:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this `37%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
220			}
221			}
222
223			/**
224			*
225			*/
226			function override_connect_message_on_update( $original, $first_name, $plugin_name, $login, $link, $freemius_link ) {
			0 ignored issues – show Best Practice introduced 2017-06-13 18:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
227
228			return
229			sprintf( __( 'Hey %s', 'foogallery' ), $first_name ) . '<br>' .
230			sprintf(
231			__( '<h2>Thank you for updating to %1$s v%5$s!</h2>Our goal with this update is to make %1$s the best gallery plugin for WordPress, but we need your help!<br><br>We have introduced this opt-in so that you can help us improve %1$s by simply clicking <strong>Allow & Continue</strong>.<br><br>If you opt-in, some data about your usage of %1$s will be sent to %4$s. If you skip this, that\'s okay! %1$s will still work just fine.', 'foogallery' ),
232			'<b>' . $plugin_name . '</b>',
233			'<b>' . $login . '</b>',
234			$link,
235			$freemius_link,
236			FOOGALLERY_VERSION
237			);
238			}
239
240			function add_freemius_activation_menu() {
			0 ignored issues – show Best Practice introduced 2017-08-21 17:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
241			global $foogallery_fs;
			0 ignored issues – show Compatibility Best Practice introduced 2017-08-21 17:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
242
243			$parent_slug = foogallery_admin_menu_parent_slug();
244
245			if ( ! $foogallery_fs->is_registered() ) {
246			add_submenu_page(
247			$parent_slug,
248			__( 'FooGallery Opt-In', 'foogallery' ),
249			__( 'Activation', 'foogallery' ),
250			'manage_options',
251			'foogallery-optin',
252			array( $foogallery_fs, '_connect_page_render' )
253			);
254			}
255			}
256
257			function is_submenu_visible( $visible, $id ) {
			0 ignored issues – show Best Practice introduced 2018-02-06 18:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
258			if ( 'addons' === $id ) {
259			//hide addons submenu for now
260			$visible = false;
261			}
262			return $visible;
263			}
264
265			/**
266			* Set default extensions when a new site is created in multisite and FooGallery is network activated
267			*
268			* @since 1.2.5
269			*
270			* @param int $blog_id The ID of the newly created site
271			*/
272			public function set_default_extensions_for_multisite_network_activated( $blog_id ) {
273			switch_to_blog( $blog_id );
274
275			if ( false === get_option( FOOGALLERY_EXTENSIONS_AUTO_ACTIVATED_OPTIONS_KEY, false ) ) {
276			$api = new FooGallery_Extensions_API();
277
278			$api->auto_activate_extensions();
279
280			update_option( FOOGALLERY_EXTENSIONS_AUTO_ACTIVATED_OPTIONS_KEY, true );
281			}
282
283			restore_current_blog();
284			}
285
286			/**
287			* Fired when the plugin is activated.
288			*
289			* @since 1.0.0
290			*
291			* @param boolean $network_wide True if WPMU superadmin uses
292			* "Network Activate" action, false if
293			* WPMU is disabled or plugin is
294			* activated on an individual blog.
295			*/
296			public static function activate( $network_wide ) {
297			if ( function_exists( 'is_multisite' ) && is_multisite() ) {
298
299			if ( $network_wide ) {
300
301			// Get all blog ids
302			$blog_ids = self::get_blog_ids();
303			if ( is_array( $blog_ids ) ) {
304			foreach ( $blog_ids as $blog_id ) {
305
306			switch_to_blog( $blog_id );
307			self::single_activate();
308			}
309
310			restore_current_blog();
311			}
312
313			} else {
314			self::single_activate();
315			}
316
317			} else {
318			self::single_activate( false );
319			}
320			}
321
322			/**
323			* Fired for each blog when the plugin is activated.
324			*
325			* @since 1.0.0
326			*/
327			private static function single_activate( $multisite = true ) {
328			if ( false === get_option( FOOGALLERY_EXTENSIONS_AUTO_ACTIVATED_OPTIONS_KEY, false ) ) {
329			$api = new FooGallery_Extensions_API();
330
331			$api->auto_activate_extensions();
332
333			update_option( FOOGALLERY_EXTENSIONS_AUTO_ACTIVATED_OPTIONS_KEY, true );
334			}
335			if ( false === $multisite ) {
336			//Make sure we redirect to the welcome page
337			set_transient( FOOGALLERY_ACTIVATION_REDIRECT_TRANSIENT_KEY, true, 30 );
338			}
339
340			//force a version check on activation to make sure housekeeping is performed
341			foogallery_perform_version_check();
342			}
343
344			/**
345			* Get all blog ids of blogs in the current network that are:
346			* - not archived
347			* - not spam
348			* - not deleted
349			*
350			* @since 1.0.0
351			*
352			* @return array\|false The blog ids, false if no matches.
353			*/
354			private static function get_blog_ids() {
355
356			if ( function_exists( 'get_sites' ) ) {
357
358			$sites = get_sites();
359			$blog_ids = array();
360			foreach ( $sites as $site ) {
361			$blog_ids[] = $site->blog_id;
362			}
363			return $blog_ids;
364			} else {
365			//pre WP 3.7 - do this the old way!
366			global $wpdb;
367
368			// get an array of blog ids
369			$sql = "SELECT blog_id FROM $wpdb->blogs WHERE archived = '0' AND spam = '0' AND deleted = '0'";
370
371			return $wpdb->get_col( $sql );
372			}
373			}
374			}
375			}
376
377			FooGallery_Plugin::get_instance();
378

fooplugins / foogallery

GitHub Access Token became invalid

Push — master ( 8970a4...b3ee5f )

foogallery.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like