FooGallery_Rest_Routes::get_galleries() - Code Metrics - Inspection of "added rest route for galleries" - fooplugins/foogallery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/gutenberg ( 9bd719...01d718 )

by Brad

created 2018-10-28 16:37 UTC

FooGallery_Rest_Routes::get_galleries() A

↳ Parent: FooGallery_Rest_Routes

Complexity

Conditions	3
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
nc	2
nop	1
dl	0
loc	23
rs	9.552
c	0
b	0
f	0

<?php
/**
 * class for Rest API Routes within FooGallery
 *
 * @since 1.6.0
 */
if ( ! class_exists( 'FooGallery_Rest_Routes' ) ) {

	class FooGallery_Rest_Routes {
namespace YourVendor;

class YourClass { }
		/**
		 * Constructs the class.
		 *
		 * @access public
		 */
		public function __construct() {
			add_action( 'rest_api_init', array( $this, 'register_routes' ) );
		}

		/**
		 * Registers the necessary REST API routes for FooGallery
		 *
		 * @access public
		 */
		public function register_routes() {
			$nonce = wp_create_nonce( 'wp_rest' );
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}


			register_rest_route(
				'foogallery/v1',
				'galleries',
				array(
					'methods'  			  => WP_REST_Server::READABLE,
					'callback' 			  => array( $this, 'get_galleries' ),
					'permission_callback' => array( $this, 'get_galleries_permissions_check' ),
					'schema' 			  => array( $this, 'get_galleries_schema' ),
				)
			);


		}

		/**
		 * Checks if a given request has access to get galleries.
		 *
		 * @access public
		 *
		 * @param WP_REST_Request $request Request.
		 *
		 * @return true|WP_Error True if the request has read access, WP_Error object otherwise.
		 */
		public function get_galleries_permissions_check( $request ) {

			if ( ! current_user_can( 'edit_posts' ) ) {
				return new WP_Error(
					'foogallery_galleries_cannot_read',
					__( 'Sorry, you are not allowed to read galleries as this user.', 'foogallery' ),
					array(
						'status' => rest_authorization_required_code(),
					)
				);
			}

			return true;
		}

		/**
		 * Returns a list of all galleries.
		 *
		 * @since  2.8.0
		 * @access public
		 *
		 * @param WP_REST_Request $request Full details about the request.
		 *
		 * @return WP_REST_Response|WP_Error Response object on success, or WP_Error object on failure.
		 */
		public function get_galleries( $request ) {

			$args = array(
				'post_type'     => FOOGALLERY_CPT_GALLERY,
				'post_status'	=> array( 'publish', 'draft' ),
				'cache_results' => false,
				'nopaging'      => true,
			);

			$gallery_posts = get_posts( $args );

			$galleries = array();

			if ( !empty( $gallery_posts ) ) {
				foreach ( $gallery_posts as $post ) {
					$galleries[] = array(
						'ID' => $post->ID,
						'Name' => $post->post_title
					);
				}
			}

			return rest_ensure_response( $galleries );
		}

		/**
		 * Retrieves block's output schema, conforming to JSON Schema.
		 *
		 * @since  2.8.0
		 * @access public
		 *
		 * @return array Item schema data.
		 */
		public function get_item_schema() {
			return array(
				'$schema'    => 'http://json-schema.org/schema#',
				'title'      => 'foogallery',
				'type'       => 'object',
				'properties' => array(
					'ID' => array(
						'description' => __( 'The FooGallery ID.', 'foogallery' ),
						'type'        => 'int',
						'required'    => true,
						'context'     => array( 'edit' ),
					),
					'Name' => array(
						'description' => __( 'The FooGallery Name.', 'foogallery' ),
						'type'        => 'string',
						'required'    => false,
						'context'     => array( 'edit' ),
					),
				),
			);
		}
	}
}


1			<?php
2			/**
3			* class for Rest API Routes within FooGallery
4			*
5			* @since 1.6.0
6			*/
7			if ( ! class_exists( 'FooGallery_Rest_Routes' ) ) {
8
9			class FooGallery_Rest_Routes {
			0 ignored issues – show Coding Style Compatibility introduced 2018-10-28 17:30 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
10			/**
11			* Constructs the class.
12			*
13			* @access public
14			*/
15			public function __construct() {
16			add_action( 'rest_api_init', array( $this, 'register_routes' ) );
17			}
18
19			/**
20			* Registers the necessary REST API routes for FooGallery
21			*
22			* @access public
23			*/
24			public function register_routes() {
25			$nonce = wp_create_nonce( 'wp_rest' );
			0 ignored issues – show Unused Code introduced 2018-10-28 17:30 UTC by Report Bug Copy Issue Report `$nonce` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
26
27
28			register_rest_route(
29			'foogallery/v1',
30			'galleries',
31			array(
32			'methods' => WP_REST_Server::READABLE,
33			'callback' => array( $this, 'get_galleries' ),
34			'permission_callback' => array( $this, 'get_galleries_permissions_check' ),
35			'schema' => array( $this, 'get_galleries_schema' ),
36			)
37			);
38
39
40			}
41
42			/**
43			* Checks if a given request has access to get galleries.
44			*
45			* @access public
46			*
47			* @param WP_REST_Request $request Request.
48			*
49			* @return true\|WP_Error True if the request has read access, WP_Error object otherwise.
50			*/
51			public function get_galleries_permissions_check( $request ) {
			0 ignored issues – show Unused Code introduced 2018-10-28 17:30 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
52			if ( ! current_user_can( 'edit_posts' ) ) {
53			return new WP_Error(
54			'foogallery_galleries_cannot_read',
55			__( 'Sorry, you are not allowed to read galleries as this user.', 'foogallery' ),
56			array(
57			'status' => rest_authorization_required_code(),
58			)
59			);
60			}
61
62			return true;
63			}
64
65			/**
66			* Returns a list of all galleries.
67			*
68			* @since 2.8.0
69			* @access public
70			*
71			* @param WP_REST_Request $request Full details about the request.
72			*
73			* @return WP_REST_Response\|WP_Error Response object on success, or WP_Error object on failure.
74			*/
75			public function get_galleries( $request ) {
			0 ignored issues – show Unused Code introduced 2018-10-28 17:30 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
76			$args = array(
77			'post_type' => FOOGALLERY_CPT_GALLERY,
78			'post_status' => array( 'publish', 'draft' ),
79			'cache_results' => false,
80			'nopaging' => true,
81			);
82
83			$gallery_posts = get_posts( $args );
84
85			$galleries = array();
86
87			if ( !empty( $gallery_posts ) ) {
88			foreach ( $gallery_posts as $post ) {
89			$galleries[] = array(
90			'ID' => $post->ID,
91			'Name' => $post->post_title
92			);
93			}
94			}
95
96			return rest_ensure_response( $galleries );
97			}
98
99			/**
100			* Retrieves block's output schema, conforming to JSON Schema.
101			*
102			* @since 2.8.0
103			* @access public
104			*
105			* @return array Item schema data.
106			*/
107			public function get_item_schema() {
108			return array(
109			'$schema' => 'http://json-schema.org/schema#',
110			'title' => 'foogallery',
111			'type' => 'object',
112			'properties' => array(
113			'ID' => array(
114			'description' => __( 'The FooGallery ID.', 'foogallery' ),
115			'type' => 'int',
116			'required' => true,
117			'context' => array( 'edit' ),
118			),
119			'Name' => array(
120			'description' => __( 'The FooGallery Name.', 'foogallery' ),
121			'type' => 'string',
122			'required' => false,
123			'context' => array( 'edit' ),
124			),
125			),
126			);
127			}
128			}
129			}
130

fooplugins / foogallery

GitHub Access Token became invalid

Push — feature/gutenberg ( 9bd719...01d718 )

FooGallery_Rest_Routes::get_galleries() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like