TerminateKernel::handle() - Code Metrics - Inspection of "wip" - fondbot/framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 3e13b9...155993 )

by Vladimir

created 2017-09-07 22:31 UTC

TerminateKernel::handle() B

↳ Parent: TerminateKernel

Complexity

Conditions	3
Paths	4

Size

Total Lines	32
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	32
c	1
b	0
f	0
cc	3
eloc	3
nc	4
nop	1
ccs	0
cts	4
cp	0
crap	12
rs	8.8571

<?php

declare(strict_types=1);

namespace FondBot\Foundation\Commands;

use FondBot\Foundation\Kernel;
use Illuminate\Foundation\Bus\Dispatchable;

class TerminateKernel
{
    use Dispatchable;

    public function handle(Kernel $kernel): void
    {
        // TODO

        // Close session if conversation has not been transitioned
        // Otherwise, save session state

//        if (!$this->transitioned) {
//            kernel()->closeSession();
//            kernel()->clearContext();
//        }

        // Save session if exists
        if ($session = $kernel->getSession()) {
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
//            SaveSession::dispatch($session);

        }

        // Save context if exists
        if ($context = $kernel->getContext()) {
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
//            SaveContext::dispatch($context);

        }
        //

//        /**
//         * Clear context.
//         */
//        public function clearContext(): void
//    {
//        if ($this->context !== null) {
//            $this->contextManager()->clear($this->context);
//            $this->context = null;
//        }
//    }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace FondBot\Foundation\Commands;
6
7			use FondBot\Foundation\Kernel;
8			use Illuminate\Foundation\Bus\Dispatchable;
9
10			class TerminateKernel
11			{
12			use Dispatchable;
13
14			public function handle(Kernel $kernel): void
15			{
16			// TODO
17
18			// Close session if conversation has not been transitioned
19			// Otherwise, save session state
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-11 22:02 UTC by Report Bug Copy Issue Report `48%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
20			// if (!$this->transitioned) {
21			// kernel()->closeSession();
22			// kernel()->clearContext();
23			// }
24
25			// Save session if exists
26			if ($session = $kernel->getSession()) {
			0 ignored issues – show Bug introduced 2017-09-07 22:33 UTC by Report Bug Copy Issue Report The method `getSession()` does not seem to exist on `object<FondBot\Foundation\Kernel>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Unused Code introduced 2017-09-07 22:33 UTC by Report Bug Copy Issue Report `$session` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history... Unused Code introduced 2017-09-07 22:33 UTC by Report Bug Copy Issue Report This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
27			// SaveSession::dispatch($session);
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-09-07 22:33 UTC by Report Bug Copy Issue Report `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
28			}
29
30			// Save context if exists
31			if ($context = $kernel->getContext()) {
			0 ignored issues – show Unused Code introduced 2017-09-07 22:33 UTC by Report Bug Copy Issue Report `$context` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history... Unused Code introduced 2017-09-07 22:33 UTC by Report Bug Copy Issue Report This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
32			// SaveContext::dispatch($context);
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-09-07 22:33 UTC by Report Bug Copy Issue Report `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
33			}
34			//
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-09-07 22:33 UTC by Report Bug Copy Issue Report `42%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
35			// /**
36			// * Clear context.
37			// */
38			// public function clearContext(): void
39			// {
40			// if ($this->context !== null) {
41			// $this->contextManager()->clear($this->context);
42			// $this->context = null;
43			// }
44			// }
45			}
46			}
47

fondbot / framework

Push — master ( 3e13b9...155993 )

TerminateKernel::handle() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like