Completed
Push — master ( 7e5dfc...eef8f6 )
by Vladimir
02:29
created

ActivatorParser::__construct()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 6
Code Lines 3

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 4
CRAP Score 1

Importance

Changes 0
Metric Value
cc 1
eloc 3
nc 1
nop 1
dl 0
loc 6
ccs 4
cts 4
cp 1
crap 1
rs 9.4285
c 0
b 0
f 0
1
<?php
2
3
declare(strict_types=1);
4
5
namespace FondBot\Conversation;
6
7
use InvalidArgumentException;
8
use FondBot\Conversation\Activators\Exact;
9
use FondBot\Conversation\Activators\InArray;
10
use FondBot\Conversation\Activators\Pattern;
11
use FondBot\Contracts\Conversation\Activator;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, FondBot\Conversation\Activator.

Let’s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let’s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
12
use FondBot\Conversation\Activators\Contains;
13
use FondBot\Conversation\Activators\WithPayload;
14
use FondBot\Conversation\Activators\WithAttachment;
15
16
class ActivatorParser
17
{
18
    private $data;
19
    private $result = [];
20
21
    private $activators = [
22
        'contains' => Contains::class,
23
        'exact' => Exact::class,
24
        'in_array' => InArray::class,
25
        'pattern' => Pattern::class,
26
        'with_attachment' => WithAttachment::class,
27
        'with_payload' => WithPayload::class,
28
    ];
29
30 2
    public function __construct(array $data)
31
    {
32 2
        $this->data = $data;
33
34 2
        $this->parse();
35 1
    }
36
37 2
    protected function parse(): void
38
    {
39 2
        foreach ($this->data as $key => $activator) {
40 2
            if ($activator instanceof Activator) {
41 1
                $this->result[] = $activator;
42
43 1
                continue;
44
            }
45
46 2
            [$activator, $parameters] = explode(':', $activator, 2);
0 ignored issues
show
Bug introduced by
The variable $parameters does not exist. Did you forget to declare it?

This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug.

Loading history...
47
48 2
            if (isset($this->activators[$activator])) {
49 1
                $this->result[] = new $this->activators[$activator]($parameters);
50
51 1
                continue;
52
            }
53
54 1
            throw new InvalidArgumentException('Activator `'.$activator.'` does not exist.');
55
        }
56 1
    }
57
58
    /**
59
     * @return Activator[]
60
     */
61 1
    public function getResult(): array
62
    {
63 1
        return $this->result;
64
    }
65
}
66