ChannelServiceProvider::config() - Code Metrics - Inspection of "use orchestra/testbench" - fondbot/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b112db...b25060 )

by Vladimir

created 2017-09-06 21:55 UTC

ChannelServiceProvider::config() A

↳ Parent: ChannelServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	0
dl	0
loc	7
ccs	0
cts	3
cp	0
crap	2
rs	9.4285
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace FondBot\Channels;

use Illuminate\Support\ServiceProvider;
use Illuminate\Contracts\Config\Repository;

class ChannelServiceProvider extends ServiceProvider
{
    /**
     * Register the service provider.
     *
     * @return void
     */
    public function register(): void
    {
        $this->app->singleton(ChannelManager::class, function () {
            /** @var array $channels */
            $channels = collect($this->config())
                ->mapWithKeys(function (array $parameters, string $name) {
                    return [$name => $parameters];
                })
                ->toArray();

            $manager = new ChannelManager($this->app);

            $manager->register($channels);

            return $manager;
        });
    }

    private function config(): array
    {
        /** @var Repository $config */
        $config = $this->app[Repository::class];

        return $config->get('fondbot.channels');
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace FondBot\Channels;
6
7		use Illuminate\Support\ServiceProvider;
8		use Illuminate\Contracts\Config\Repository;
9
10		class ChannelServiceProvider extends ServiceProvider
11		{
12		/**
13		* Register the service provider.
14		*
15		* @return void
16		*/
17		public function register(): void
18		{
19	83	$this->app->singleton(ChannelManager::class, function () {
20		/** @var array $channels */
21		$channels = collect($this->config())
22		->mapWithKeys(function (array $parameters, string $name) {
23		return [$name => $parameters];
24		})
25		->toArray();
26
27		$manager = new ChannelManager($this->app);
		0 ignored issues – show Compatibility introduced 2017-09-04 21:54 UTC by Report Bug Copy Issue Report `$this->app` of type `object<Illuminate\Contra...Foundation\Application>` is not a sub-type of `object<Illuminate\Foundation\Application>`. It seems like you assume a concrete implementation of the interface `Illuminate\Contracts\Foundation\Application` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
28		$manager->register($channels);
29
30		return $manager;
31	83	});
32	83	}
33
34		private function config(): array
35		{
36		/** @var Repository $config */
37		$config = $this->app[Repository::class];
38
39		return $config->get('fondbot.channels');
40		}
41		}
42

fondbot / framework

Push — master ( b112db...b25060 )

ChannelServiceProvider::config() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like