LogServiceProvider::boot() - Code Metrics - Inspection of "fix" - fondbot/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( da1cfa...dccc7f )

by Vladimir

created 2017-05-12 07:59 UTC

LogServiceProvider::boot() A

↳ Parent: LogServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	21
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	21
ccs	0
cts	8
cp	0
rs	9.3142
c	0
b	0
f	0
cc	1
eloc	12
nc	1
nop	0
crap	2

<?php

declare(strict_types=1);

namespace FondBot\Application;

use Exception;
use Whoops\Run;
use Monolog\Logger;
use Psr\Log\LoggerInterface;
use Monolog\Handler\StreamHandler;
use Whoops\Handler\PrettyPageHandler;
use League\Container\ServiceProvider\AbstractServiceProvider;
use League\Container\ServiceProvider\BootableServiceProviderInterface;

class LogServiceProvider extends AbstractServiceProvider implements BootableServiceProviderInterface
{
    protected $provides = [
        LoggerInterface::class,
    ];

    /**
     * Method will be invoked on registration of a service provider implementing
     * this interface. Provides ability for eager loading of Service Providers.
     *
     * @return void
     */
    public function boot(): void
    {
        $this->getContainer()->share(LoggerInterface::class, function () {
            $logger = new Logger('FondBot');
            $logger->pushHandler(new StreamHandler(
                $this->getContainer()->get('resources_path').'/logs/app.log'
            ));

            return $logger;
        });

        $whoops = new Run;
        $whoops->pushHandler(new PrettyPageHandler);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $whoops->pushHandler(function (Exception $exception, $inspector, $run) {

            /** @var LoggerInterface $logger */
            $logger = $this->getContainer()->get(LoggerInterface::class);

            $logger->error($exception);
        });
        $whoops->register();
    }

    /**
     * Use the register method to register items with the container via the
     * protected $this->container property or the `getContainer` method
     * from the ContainerAwareTrait.
     *
     * @return void
     */
    public function register(): void
    {
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace FondBot\Application;
6
7			use Exception;
8			use Whoops\Run;
9			use Monolog\Logger;
10			use Psr\Log\LoggerInterface;
11			use Monolog\Handler\StreamHandler;
12			use Whoops\Handler\PrettyPageHandler;
13			use League\Container\ServiceProvider\AbstractServiceProvider;
14			use League\Container\ServiceProvider\BootableServiceProviderInterface;
15
16			class LogServiceProvider extends AbstractServiceProvider implements BootableServiceProviderInterface
17			{
18			protected $provides = [
19			LoggerInterface::class,
20			];
21
22			/**
23			* Method will be invoked on registration of a service provider implementing
24			* this interface. Provides ability for eager loading of Service Providers.
25			*
26			* @return void
27			*/
28			public function boot(): void
29			{
30			$this->getContainer()->share(LoggerInterface::class, function () {
31			$logger = new Logger('FondBot');
32			$logger->pushHandler(new StreamHandler(
33			$this->getContainer()->get('resources_path').'/logs/app.log'
34			));
35
36			return $logger;
37			});
38
39			$whoops = new Run;
40			$whoops->pushHandler(new PrettyPageHandler);
			0 ignored issues – show Documentation introduced 2017-05-10 21:42 UTC by Report Bug Copy Issue Report `new \Whoops\Handler\PrettyPageHandler()` is of type `object<Whoops\Handler\PrettyPageHandler>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
41			$whoops->pushHandler(function (Exception $exception, $inspector, $run) {
			0 ignored issues – show Unused Code introduced 2017-05-10 22:36 UTC by Report Bug Copy Issue Report The parameter `$inspector` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-05-10 22:36 UTC by Report Bug Copy Issue Report The parameter `$run` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
42			/** @var LoggerInterface $logger */
43			$logger = $this->getContainer()->get(LoggerInterface::class);
44
45			$logger->error($exception);
46			});
47			$whoops->register();
48			}
49
50			/**
51			* Use the register method to register items with the container via the
52			* protected $this->container property or the `getContainer` method
53			* from the ContainerAwareTrait.
54			*
55			* @return void
56			*/
57			public function register(): void
58			{
59			}
60			}
61

fondbot / framework

Push — master ( da1cfa...dccc7f )

LogServiceProvider::boot() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like