IntentManager::find() - Code Metrics - Inspection of "wip" - fondbot/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 16b7cb...b112db )

by Vladimir

created 2017-09-06 16:49 UTC

IntentManager::find() B

↳ Parent: IntentManager

Complexity

Conditions	5
Paths	4

Size

Total Lines	13
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes

Metric	Value
cc	5
eloc	6
nc	4
nop	1
dl	0
loc	13
ccs	0
cts	6
cp	0
crap	30
rs	8.8571
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace FondBot\Conversation;

use FondBot\Events\MessageReceived;

class IntentManager
{
    /** @var Intent[] */
    private $intents = [];

    /** @var Intent */
    private $fallbackIntent;

    /**
     * Register intents.
     *
     * @param array  $intents
     * @param string $fallbackIntent
     */
    public function register(array $intents, string $fallbackIntent): void
    {
        $this->intents = $intents;
        $this->fallbackIntent = $fallbackIntent;

    }

    /**
     * Find intent.
     *
     * @param MessageReceived $message
     *
     * @return Intent|null
     */
    public function find(MessageReceived $message): ?Intent
    {
        foreach ($this->intents as $intent) {
            foreach ($intent->activators() as $activator) {
                if ($activator->matches($message) && $intent->passesAuthorization($message)) {
                    return resolve($intent);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                }
            }
        }

        // Otherwise, return fallback intent
        return resolve($this->fallbackIntent);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace FondBot\Conversation;
6
7			use FondBot\Events\MessageReceived;
8
9			class IntentManager
10			{
11			/** @var Intent[] */
12			private $intents = [];
13
14			/** @var Intent */
15			private $fallbackIntent;
16
17			/**
18			* Register intents.
19			*
20			* @param array $intents
21			* @param string $fallbackIntent
22			*/
23			public function register(array $intents, string $fallbackIntent): void
24			{
25			$this->intents = $intents;
26			$this->fallbackIntent = $fallbackIntent;
			0 ignored issues – show Documentation Bug introduced 2017-09-06 16:57 UTC by Report Bug Copy Issue Report It seems like `$fallbackIntent` of type `string` is incompatible with the declared type `object<FondBot\Conversation\Intent>` of property `$fallbackIntent`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
27			}
28
29			/**
30			* Find intent.
31			*
32			* @param MessageReceived $message
33			*
34			* @return Intent\|null
35			*/
36			public function find(MessageReceived $message): ?Intent
37			{
38			foreach ($this->intents as $intent) {
39			foreach ($intent->activators() as $activator) {
40			if ($activator->matches($message) && $intent->passesAuthorization($message)) {
41			return resolve($intent);
			0 ignored issues – show Documentation introduced 2017-09-06 16:57 UTC by Report Bug Copy Issue Report `$intent` is of type `object<FondBot\Conversation\Intent>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
42			}
43			}
44			}
45
46			// Otherwise, return fallback intent
47			return resolve($this->fallbackIntent);
			0 ignored issues – show Documentation introduced 2017-09-06 16:57 UTC by Report Bug Copy Issue Report `$this->fallbackIntent` is of type `object<FondBot\Conversation\Intent>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
48			}
49			}
50

fondbot / framework

Push — master ( 16b7cb...b112db )

IntentManager::find() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like