Assets::__construct() - Code Metrics - Inspection of "switch to own implementation of asset discovery" - fondbot/framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 922d24...7b732c )

by Vladimir

created 2017-06-04 23:25 UTC

Assets::__construct() A

↳ Parent: Assets

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	4
ccs	3
cts	3
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace FondBot\Application;

use League\Flysystem\Filesystem;

class Assets
{
    public const TYPE_DRIVER = 'driver';

    private $filesystem;

    public function __construct(Filesystem $filesystem)
    {
        $this->filesystem = $filesystem;
    }

    /**
     * Discover assets.
     *
     * @param string|null $type
     *
     * @return array
     */
    public function discover(string $type = null): array
    {
        $files = $this->filesystem->listContents('vendor', true);

        // Find all composer.json files
        // Then find suitable assets
        $assets = [];

        collect($files)
            ->filter(function (array $file) {
                return $file['type'] === 'file' && $file['basename'] === 'composer.json';
            })
            ->transform(function ($file) {
                $contents = $this->filesystem->get($file['path'])->read();
                $manifest = json_decode($contents, true);

                if (isset($manifest['extra'], $manifest['extra']['fondbot'])) {
                    return $manifest['extra']['fondbot'];
                }

                return null;
            })
            ->filter(function ($item) use ($type) {
                if ($item === null) {
                    return false;
                }

                // Filter by type
                if ($type !== null) {
                    return key($item) === $type;
                }

                return true;
            })
            ->each(function ($item) use (&$assets) {
                $type = key($item);

                $assets[$type][] = $item[$type];
            });

        if ($type !== null) {
            $assets = collect($assets)
                ->filter(function ($_, $key) use ($type) {
                    return $key === $type;
                })
                ->values()
                ->flatten()
                ->toArray();
        }

        return $assets;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace FondBot\Application;
6
7		use League\Flysystem\Filesystem;
8
9		class Assets
10		{
11		public const TYPE_DRIVER = 'driver';
12
13		private $filesystem;
14
15	2	public function __construct(Filesystem $filesystem)
16		{
17	2	$this->filesystem = $filesystem;
18	2	}
19
20		/**
21		* Discover assets.
22		*
23		* @param string\|null $type
24		*
25		* @return array
26		*/
27	2	public function discover(string $type = null): array
28		{
29	2	$files = $this->filesystem->listContents('vendor', true);
30
31		// Find all composer.json files
32		// Then find suitable assets
33	2	$assets = [];
34
35	2	collect($files)
36		->filter(function (array $file) {
37	2	return $file['type'] === 'file' && $file['basename'] === 'composer.json';
38	2	})
39		->transform(function ($file) {
40	2	$contents = $this->filesystem->get($file['path'])->read();
41	2	$manifest = json_decode($contents, true);
42
43	2	if (isset($manifest['extra'], $manifest['extra']['fondbot'])) {
44	2	return $manifest['extra']['fondbot'];
45		}
46
47	2	return null;
48	2	})
49		->filter(function ($item) use ($type) {
50	2	if ($item === null) {
51	2	return false;
52		}
53
54		// Filter by type
55	2	if ($type !== null) {
56	1	return key($item) === $type;
57		}
58
59	1	return true;
60	2	})
61		->each(function ($item) use (&$assets) {
62	2	$type = key($item);
63
64	2	$assets[$type][] = $item[$type];
65	2	});
66
67	2	if ($type !== null) {
68	1	$assets = collect($assets)
69	1	->filter(function ($_, $key) use ($type) {
70	1	return $key === $type;
71	1	})
72	1	->values()
73	1	->flatten()
74	1	->toArray();
75		}
76
77	2	return $assets;
78		}
79		}
80

fondbot / framework

Push — master ( 922d24...7b732c )

Assets::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like