FondBot\Console\InstallDriverCommand::handle()

Complexity

Conditions	4
Paths	4

Size

Total Lines	31
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function handle(Api $api, Composer $composer): void
    {
        // Check if package is listed in store
        $name = $this->argument('name');
        $driver = $api->findDriver($this->argument('name'));

It seems like $this->argument('name') can also be of type null and array; however, parameter $name of FondBot\Foundation\Api::findDriver() does only seem to accept string, maybe add an additional type check?

        if ($driver === null) {
            $this->error('"'.$name.'" is not found in the available drivers list or is not yet supported by current FondBot version ('.FondBot::version().').');

Are you sure $name of type null|string|array can be used in concatenation?

            exit(0);

Using exit here is not recommended.

        }

        if ($composer->installed($driver['package'])) {
            $this->error('Driver is already installed.');

            return;
        }

        // Install driver
        $this->info('Installing driver...');

        $result = $composer->install($driver['package'], function ($_, $line) use (&$output) {
            $output .= $line;
        });

        if ($result !== 0) {
            $this->error($output);
            exit($result);

Using exit here is not recommended.

        }

        $this->info('Driver installed. ✔');
    }