fomvasss / laravel-notification-channel-sms-ru

src/SmsRuServiceProvider.php

<?php

namespace NotificationChannels\SmsRu;

use Illuminate\Support\ServiceProvider;

class SmsRuServiceProvider extends ServiceProvider
{
    /**
     * Register the application services.
     */
    public function register()
    {
        $this->app->singleton(SmsRuApi::class, function ($app) {

The parameter $app is not used and could be removed.

            $apiId = $this->app['config']['services.sms_ru.api_id'];
            $client = new SmsRuApi(new \Zelenin\SmsRu\Auth\ApiIdAuth($apiId));

The call to NotificationChannels\SmsRu\SmsRuApi::__construct() has too few arguments starting with client.

            return $client;
        });
    }

    public function provides(): array
    {
        return [
            SmsRuApi::class,
        ];
    }
}