fnash / graphql-qb

GraphQL/QueryTrait.php

<?php

namespace Fnash\GraphQL;

trait QueryTrait
{
    private static $operationNamePlaceholder = '_operationNamePlaceholder_';

    /**
     * @var string
     */
    public $operationName;

    /**
     * @var array
     */
    public $variables = [];

    /**
     * @var bool
     */
    public $isRootQuery = true;

    /**
     * @var array
     */
    public $type = [];

    /**
     * @var array
     */
    public $args = [];

    /**
     * @var array
     */
    public $fields = [];

    /**
     * @var array
     */
    public $skipIf = [];

    /**
     * @var array
     */
    public $includeIf = [];

    /**
     * @var array
     */
    public $fragments = [];

    /**
     * @param null $type

Are you sure the doc-type for parameter $type is correct as it would always require null to be passed?

     * @param array $args
     * @param array $fields
     *
     * @return self
     */
    public static function create($type = null, array $args = [], array $fields = [])
    {
        return new self($type, $args, $fields);
    }

    /**
     * @param string $operationName
     *
     * @return self
     */
    public function operationName(string $operationName)
    {
        $this->operationName = $operationName;

        return $this;
    }

    /**
     * @param $operationName
     * @param $variables
     *
     * @return string
     */
    private static function printQuery($operationName, $variables): string
    {
        if (null === $operationName) {
            if (\count($variables)) {
                $operationName = static::$operationNamePlaceholder;

Since $operationNamePlaceholder is declared private, accessing it with static will lead to errors in possible sub-classes; you can either use self, or increase the visibility of $operationNamePlaceholder to at least protected.

            } else {
                return static::class === Mutation::class ? sprintf('%s', static::KEYWORD) : '';

The condition static::class === Fnash\GraphQL\Mutation::class is always false.

            }
        }

        return sprintf('%s %s %s', static::KEYWORD, $operationName, static::printVariables($variables));

The constant Fnash\GraphQL\QueryTrait::KEYWORD was not found. Maybe you did not declare it correctly or list all dependencies?

    }

    /**
     * @param array $variables
     *
     * @return self
     */
    public function variables(array $variables = [])
    {
        foreach ($variables as $variableName => $variableType) {
            $this->variables[(string) $variableName] = (string) $variableType;
        }

        return $this;
    }

    /**
     * @param array $value
     *
     * @return string
     */
    private static function printVariables(array $value): string
    {
        if (!\count($value)) {
            return '';
        }

        $variables = [];

        foreach ($value as $variableName => $variableType) {
            $variables[] = sprintf('%s: %s', $variableName, $variableType);
        }

        return sprintf('(%s)', implode(', ', $variables));
    }

    /**
     * @param array $args
     *
     * @return self
     */
    public function arguments(array $args = [])
    {
        foreach ($args as $name => $value) {
            $this->args[$name] = $value;
        }

        ksort($this->args);

        return $this;
    }

    /**
     * @param array $value
     *
     * @return string
     */
    private static function printArgs(array $value): string
    {
        if (!count($value)) {
            return '';
        }

        $args = [];
        foreach ($value as $argName => $argValue) {
            if (\is_string($argValue) && '$' !== $argValue[0]) {
                if (preg_match_all('/"""/', $argValue) !== 2) { // if not a multi line argument value
                    $argValue = sprintf('"%s"', $argValue);
                }
            }

            if (\is_bool($argValue) || \is_float($argValue)) {
                $argValue = var_export($argValue, true);
            }

            $args[] = sprintf('%s: %s', $argName, $argValue);
        }

        return sprintf('(%s)', implode(', ', $args));
    }

    /**
     * @param array $fields
     *
     * @return self
     */
    public function fields(array $fields = [])
    {
        foreach ($fields as $fieldAlias => $field) {
            if (\is_string($field)) {
                if (\is_string($fieldAlias)) {
                    $this->fields[$fieldAlias] = $field;
                } else {
                    $this->fields[$field] = $field;
                }
            }

            if ($field instanceof Query) {
                $field->isRootQuery = false;
                $this->fields[$fieldAlias] = $field;
            }
        }

        ksort($this->fields);

        return $this;
    }

    /**
     * @param array $fields
     *
     * @return self
     */
    public function removeFields(array $fields = []): Query
    {
        foreach ($fields as $field) {
            unset($this->fields[$field]);
        }

        return $this;
    }

    /**
     * @param array $value
     * @param array $skipIf
     * @param array $includeIf
     *
     * @return string
     */
    private static function printFields(array $value, array $skipIf = [], array $includeIf = []): string
    {
        $fields = [];

        foreach ($value as $fieldAlias => $field) {
            $directive = '';

            if (\is_string($field)) {
                if ($fieldAlias !== $field) {
                    if (array_key_exists($fieldAlias, $skipIf)) {
                        $directive = sprintf('@skip(if: %s)', $skipIf[$fieldAlias]);
                    } elseif (array_key_exists($fieldAlias, $includeIf)) {
                        $directive = sprintf('@include(if: %s)', $includeIf[$fieldAlias]);
                    }

                    $fields[] = sprintf('%s: %s %s', $fieldAlias, $field, $directive);
                } else {
                    if (array_key_exists($field, $skipIf)) {
                        $directive = sprintf('@skip(if: %s)', $skipIf[$field]);
                    } elseif (array_key_exists($field, $includeIf)) {
                        $directive = sprintf('@include(if: %s)', $includeIf[$field]);
                    }

                    $fields[] = sprintf('%s %s', $field, $directive);
                }
            }

            if ($field instanceof Query) {
                $field->isRootQuery = false;

                if (array_key_exists($fieldAlias, $skipIf)) {
                    $directive = sprintf('@skip(if: %s)', $skipIf[$fieldAlias]);
                } elseif (array_key_exists($fieldAlias, $includeIf)) {
                    $directive = sprintf('@include(if: %s)', $includeIf[$fieldAlias]);
                }

                if (null !== $field->type) {
                    $fieldAlias = sprintf('%s: %s', $fieldAlias, $field->type);

$field->type of type array is incompatible with the type string expected by parameter $args of sprintf().

                }

                $fields[] = sprintf('%s %s { %s }', $fieldAlias, $directive, static::printFields($field->fields));
            }
        }

        return implode(', ', $fields);
    }

    /**
     * @param array $values
     *
     * @return self
     */
    public function skipIf(array $values = [])
    {
        foreach ($values as $field => $argument) {
            $this->skipIf[$field] = $argument;
        }

        return $this;
    }

    /**
     * @param array $values
     *
     * @return self
     */
    public function includeIf(array $values = [])
    {
        foreach ($values as $field => $argument) {
            $this->includeIf[$field] = $argument;
        }

        return $this;
    }

    public function __toString()
    {
        if ($this->isRootQuery) {
            $query = sprintf('%s { %s %s { %s } } %s', static::printQuery($this->operationName, $this->variables), static::printType($this->type), static::printArgs($this->args), static::printFields($this->fields, $this->skipIf, $this->includeIf), static::printFragments($this->fragments));

The method Fnash\GraphQL\QueryTrait::printFragments() is not static, but was called statically.

        } else {
            $query = sprintf('%s { %s }', static::printType($this->type), static::printFields($this->fields, $this->skipIf, $this->includeIf));
        }

        $query = \GraphQL\Language\Printer::doPrint(\GraphQL\Language\Parser::parse((string) $query));

        $query = str_replace(static::$operationNamePlaceholder, static::GENERATED_NAME_PREFIX.sha1($query), $query);

Since $operationNamePlaceholder is declared private, accessing it with static will lead to errors in possible sub-classes; you can either use self, or increase the visibility of $operationNamePlaceholder to at least protected.

The constant Fnash\GraphQL\QueryTrait::GENERATED_NAME_PREFIX was not found. Maybe you did not declare it correctly or list all dependencies?

        return $query;
    }

    /**
     * @param Fragment $fragment
     *
     * @return $this
     */
    public function addFragment(Fragment $fragment)
    {
        $this->fragments[$fragment->name] = $fragment;

        return $this;
    }

    /**
     * @param $value
     *
     * @return string
     */
    private function printFragments($value)
    {
        $fragments = '';
        foreach ($value as $fragment) {
            $fragments .= (string) $fragment;
        }

        return $fragments;
    }

    /**
     * @param null $type

Are you sure the doc-type for parameter $type is correct as it would always require null to be passed?

     * @param array $args
     * @param array $fields
     */
    private function __construct($type = null, array $args = [], array $fields = [])
    {
        $this->type = $type;

        $this->arguments($args);

        $this->fields($fields);
    }

    private static function printType($value): string
    {
        if (\is_string($value)) {
            return $value;
        }

        if (\is_array($value) && \count($value)) {
            foreach ($value as $alias => $type) {
                return sprintf('%s: %s', $alias, $type);
            }
        }
    }
}