Asset::add() - Code Metrics - Inspection of "refactor(Features/Jquery): use Asset util to load..." - flyntwp/flynt-starter-theme - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — jquery-cdn ( 400c4e...bf2c1a )

by Doğa

created 2017-05-16 15:59 UTC

Asset::add() C

↳ Parent: Asset

Complexity

Conditions	13
Paths	26

Size

Total Lines	58
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	13
eloc	35
nc	26
nop	2
dl	0
loc	58
rs	6.5104
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

namespace Flynt\Utils;

// TODO: add async & defer (see https://matthewhorne.me/defer-async-wordpress-scripts/); also add to cdn fallback

class Asset
{
    const DEFAULT_OPTIONS = [
        'dependencies' => [],
        'version' => null,
        'inFooter' => true,
        'media' => 'all',
        'cdn' => []
    ];

    protected static $assetManifest;
    protected static $loadFromCdn = false;

    public static function requireUrl($asset)
    {
        return self::get('url', $asset);
    }

    public static function requirePath($asset)
    {
        return self::get('path', $asset);
    }

    public static function register($options)
    {
        return self::add('register', $options);
    }

    public static function enqueue($options)
    {
        return self::add('enqueue', $options);
    }

    protected static function get($returnType, $asset)
    {
        $distPath = get_template_directory() . '/dist';

        if (!isset(self::$assetManifest)) {
            $manifestPath = $distPath . '/rev-manifest.json';
            if (is_file($manifestPath)) {
                self::$assetManifest = json_decode(file_get_contents($manifestPath), true);
            } else {
                self::$assetManifest = [];
            }
        }

        if (array_key_exists($asset, self::$assetManifest)) {
            $assetSuffix = self::$assetManifest[$asset];
        } else {
            $assetSuffix = $asset;
        }

        if ('path' == $returnType) {
            return $distPath . '/' . $assetSuffix;
        } else if ('url' == $returnType) {
            $distUrl = get_template_directory_uri() . '/dist';
            return $distUrl . '/' . $assetSuffix;
        }

        return false;
    }

    protected static function add($funcType, $options)
    {
        $options = array_merge(self::DEFAULT_OPTIONS, $options);

        if (!array_key_exists('name', $options)) {
            trigger_error('Cannot add asset: Name not provided!', E_USER_WARNING);
            return false;
        }

        if (!array_key_exists('path', $options)) {
            trigger_error('Cannot add asset: Path not provided!', E_USER_WARNING);
            return false;
        }

        $funcName = "wp_{$funcType}_{$options['type']}";
        $lastVar = $options['type'] === 'script' ? $options['inFooter'] : $options['media'];

        // allow external urls
        $path = $options['path'];
        if (!(StringHelpers::startsWith('http://', $path))
            && !(StringHelpers::startsWith('https://', $path))
            && !(StringHelpers::startsWith('//', $path))
        ) {
            $path = Asset::requireUrl($path);
        }

        // TODO: What if a script is registered twice?
        if (true === self::$loadFromCdn
            && !empty($options['cdn'])
            && !empty($options['cdn']['check'])
            && !empty($options['cdn']['url'])
        ) {
            $cdnCheck = $options['cdn']['check'];
            $localPath = $path;
            $path = $options['cdn']['url'];
        }

        if (function_exists($funcName)) {
            $funcName(
                $options['name'],
                $path,
                $options['dependencies'],
                $options['version'],
                $lastVar
            );

            if (isset($localPath)) {
                wp_add_inline_script(
                    $options['name'],
                    "${cdnCheck}||document.write(\"<script src=\\\"${localPath}\\\"><\/script>\")"
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                );
            }

            return true;
        }

        return false;
    }

    /**
     * Getter and setter for the loadFromCdn setting.
     *
     * @param boolean $load (optional) Value to set the parameter to.
     **/
    public static function loadFromCdn($load = null)
    {
        if (!isset($load)) {
            return self::$loadFromCdn;
        }
        self::$loadFromCdn = (bool) $load;
    }
}


1			<?php
2
3			namespace Flynt\Utils;
4
5			// TODO: add async & defer (see https://matthewhorne.me/defer-async-wordpress-scripts/); also add to cdn fallback
6
7			class Asset
8			{
9			const DEFAULT_OPTIONS = [
10			'dependencies' => [],
11			'version' => null,
12			'inFooter' => true,
13			'media' => 'all',
14			'cdn' => []
15			];
16
17			protected static $assetManifest;
18			protected static $loadFromCdn = false;
19
20			public static function requireUrl($asset)
21			{
22			return self::get('url', $asset);
23			}
24
25			public static function requirePath($asset)
26			{
27			return self::get('path', $asset);
28			}
29
30			public static function register($options)
31			{
32			return self::add('register', $options);
33			}
34
35			public static function enqueue($options)
36			{
37			return self::add('enqueue', $options);
38			}
39
40			protected static function get($returnType, $asset)
41			{
42			$distPath = get_template_directory() . '/dist';
43
44			if (!isset(self::$assetManifest)) {
45			$manifestPath = $distPath . '/rev-manifest.json';
46			if (is_file($manifestPath)) {
47			self::$assetManifest = json_decode(file_get_contents($manifestPath), true);
48			} else {
49			self::$assetManifest = [];
50			}
51			}
52
53			if (array_key_exists($asset, self::$assetManifest)) {
54			$assetSuffix = self::$assetManifest[$asset];
55			} else {
56			$assetSuffix = $asset;
57			}
58
59			if ('path' == $returnType) {
60			return $distPath . '/' . $assetSuffix;
61			} else if ('url' == $returnType) {
62			$distUrl = get_template_directory_uri() . '/dist';
63			return $distUrl . '/' . $assetSuffix;
64			}
65
66			return false;
67			}
68
69			protected static function add($funcType, $options)
70			{
71			$options = array_merge(self::DEFAULT_OPTIONS, $options);
72
73			if (!array_key_exists('name', $options)) {
74			trigger_error('Cannot add asset: Name not provided!', E_USER_WARNING);
75			return false;
76			}
77
78			if (!array_key_exists('path', $options)) {
79			trigger_error('Cannot add asset: Path not provided!', E_USER_WARNING);
80			return false;
81			}
82
83			$funcName = "wp_{$funcType}_{$options['type']}";
84			$lastVar = $options['type'] === 'script' ? $options['inFooter'] : $options['media'];
85
86			// allow external urls
87			$path = $options['path'];
88			if (!(StringHelpers::startsWith('http://', $path))
89			&& !(StringHelpers::startsWith('https://', $path))
90			&& !(StringHelpers::startsWith('//', $path))
91			) {
92			$path = Asset::requireUrl($path);
93			}
94
95			// TODO: What if a script is registered twice?
96			if (true === self::$loadFromCdn
97			&& !empty($options['cdn'])
98			&& !empty($options['cdn']['check'])
99			&& !empty($options['cdn']['url'])
100			) {
101			$cdnCheck = $options['cdn']['check'];
102			$localPath = $path;
103			$path = $options['cdn']['url'];
104			}
105
106			if (function_exists($funcName)) {
107			$funcName(
108			$options['name'],
109			$path,
110			$options['dependencies'],
111			$options['version'],
112			$lastVar
113			);
114
115			if (isset($localPath)) {
116			wp_add_inline_script(
117			$options['name'],
118			"${cdnCheck}\|\|document.write(\"<script src=\\\"${localPath}\\\"><\/script>\")"
			0 ignored issues – show Bug introduced 2017-05-16 16:02 UTC by Report Bug Copy Issue Report The variable `$cdnCheck` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
119			);
120			}
121
122			return true;
123			}
124
125			return false;
126			}
127
128			/**
129			* Getter and setter for the loadFromCdn setting.
130			*
131			* @param boolean $load (optional) Value to set the parameter to.
132			**/
133			public static function loadFromCdn($load = null)
134			{
135			if (!isset($load)) {
136			return self::$loadFromCdn;
137			}
138			self::$loadFromCdn = (bool) $load;
139			}
140			}
141

flyntwp / flynt-starter-theme

Push — jquery-cdn ( 400c4e...bf2c1a )

Asset::add() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like