flying-coders / SIFIKS

app/Http/Controllers/RoomController.php

<?php

namespace App\Http\Controllers;

use Illuminate\Support\Facades\DB;
use Illuminate\Http\Request;
use Carbon\Carbon;
use App\Hospital;
use App\Room;

class RoomController extends Controller
{
    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create($hospital_id)
    {
        $data = [
            'hospital' => Hospital::find($hospital_id)
        ];
        return view('pages.ext.add-room')->with('data', $data);

The expression return view('pages.ext.add-room')->with('data', $data) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Store a newly created resource in storage.
     *
     * @param Request $request
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
     * @throws \Illuminate\Validation\ValidationException
     */
    public function store(Request $request)
    {
        $this->validate($request, [
            'name' => 'required',
            'price' => 'required|numeric|min:6',
            'description' => 'required|min:150',
        ]);

        $hospital_id = $request->input('hospital_id');
        $room_id = DB::table('rooms')
            ->insertGetId(array(
                'name' => $request->input('name'),
                'price_per_night' => $request->input('price'),
                'description' => $request->input('description'),
                'created_at' => Carbon::now(),
                'updated_at' => Carbon::now()
            ));

        if($room_id != null && $hospital_id != null) {
            $data = [
                'hospital_id' => $hospital_id,
                'room_id' => $room_id
            ];

            if($this->insertRoomDetails($data) && $this->updateHospitalUpdatedAt($hospital_id)) {
                return redirect(route('hospital.show', $hospital_id))->with('success', 'Kamar baru berhasil ditambahkan !');
            }
        }
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show($id, $hospital_id)
    {
        $data = [
            'hospital' => Hospital::find($hospital_id),
            'room' => Room::find($id)
        ];
        return view('pages.ext.view-room')->with('data', $data);

The expression return view('pages.ext.view-room')->with('data', $data) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param   int $id
     * @param   int $hospital_id
     * @return \Illuminate\Http\Response
     */
    public function edit($id, $hospital_id)
    {
        $data = [
            'room' => Room::find($id),
            'hospital' => Hospital::find($hospital_id)
        ];
        return view('pages.ext.edit-room')->with('data', $data);

The expression return view('pages.ext.edit-room')->with('data', $data) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Update the specified resource in storage.
     *
     * @param Request $request
     * @param $id
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
     * @throws \Illuminate\Validation\ValidationException
     */
    public function update(Request $request, $id)
    {
        $this->validate($request, [
            'name' => 'required',
            'price' => 'required|numeric|min:6',
            'description' => 'required|min:150',
        ]);

        $room = Room::find($id);
        $room->name = $request->input('name');
        $room->price_per_night = $request->input('price');
        $room->description = $request->input('description');

        $hospital = $this->updateHospitalUpdatedAt($request->input('hospital_id'));

        if($room->save() && $hospital == true) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            return redirect(route('hospital.show', $request->input('hospital_id')))->with('success', 'Detil Kamar berhasil diubah !');
        }
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @param  int  $hospital_id
     * @return \Illuminate\Http\Response
     */
    public function destroy($room_id, $hospital_id)
    {
        $room = Room::find($room_id);
        $hospital = $this->updateHospitalUpdatedAt($hospital_id);
        $detail = $this->deleteRoomDetails($room_id, $hospital_id);

        if($room && $hospital && $detail) {
            return redirect(route('hospital.show', ['id' => $hospital_id]))->with('success', 'Kamar dihapus !');

The expression return redirect(route('hospital.show', array('id' => $hospital_id)))->with('success', 'Kamar dihapus !') returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

        }
    }

    /**
     * @param $data
     * @return bool
     */
    private function insertRoomDetails($data)
    {
        $insert = DB::table('room_details')
            ->insert([
                'room_id' => $data['room_id'],
                'hospital_id' => $data['hospital_id']
            ]);

        if($insert) {
            return true;
        }

        return false;
    }

    /**
     * @param $room_id
     * @param $hospital_id
     * @return bool
     */
    private function deleteRoomDetails($room_id, $hospital_id)
    {
        $delete = DB::table('room_details')
            ->where('room_id', '=', $room_id)
            ->where('hospital_id', '=', $hospital_id)
            ->delete();

        if($delete) {
            return true;
        }

        return false;
    }

    /**
     * @param $id
     * @return bool
     */
    private function updateHospitalUpdatedAt($id)
    {
        $hospital = Hospital::find($id);
        $hospital->updated_at = Carbon::now();
        if($hospital->save()) {
            return true;
        }

        return false;
    }
}