flying-coders / SIFIKS

app/Http/Controllers/ArticleController.php

<?php

namespace App\Http\Controllers;

use App\Common;
use Illuminate\Http\Request;
Use Illuminate\Support\Facades\Storage;
use Illuminate\Support\Facades\Auth;
use App\Articles;

class ArticleController extends Controller
{
    /**
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function index()
    {
        $articles = Articles::orderBy('created_at','desc')->paginate(15);
        $data = [
            'articles' => $articles
        ];

        return view('pages.article')->with('data', $data);
    }

    /**
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function create()
    {
        return view('pages.ext.add-article');
    }

    /**
     * @param Request $request
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
     * @throws \Illuminate\Validation\ValidationException
     */
    public function store(Request $request)
    {
        $this->validate($request,[
            'category' => 'required',
            'title' => 'required',
            'content' => 'required|min:500',
            'cover_image' => 'image|nullable|max:3999'
        ]);

        if($request->hasFile('cover_image')){
            $filenameWithExt = $request->file('cover_image')->getClientOriginalName();
            $filename = pathinfo($filenameWithExt, PATHINFO_FILENAME);
            $extension = $request->file('cover_image')->getClientOriginalExtension();
            $fileNameToStore = $filename.'_'.time().'.'.$extension;
            $path = $request->file('cover_image')->storeAs('public/cover_images', $fileNameToStore);

The assignment to $path is dead and can be removed.

        }else {
            $fileNameToStore = 'noimage.jpg';
        }

        $article = new Articles;
        $article->category = $request->input('category');
        $article->title = $request->input('title');
        $article->content = $request->input('content');
        if(session('guard') == 'admin') {
            $article->admin_id = Auth::guard('admin')->user()->id;
        } else {
            $article->doctor_id = Auth::guard('doctor')->user()->id;
        }
        $article->cover_image = $fileNameToStore;

        $log = null;
        if($article->save()) {
            $log = Common::registerLog([
                'action' => "membuat artikel baru.",
                'target' => 'article',
                'prefix' => 'a-create',
                'target_id' => $article->id,
                'actor' => session('guard'),
                'actor_id' => Common::currentUser(session('guard'))->id
            ]);
        }

        if($log != null && $log == true) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            return redirect (route(session('guard').'.article.index'))->with('success', 'Artikel baru berhasil ditambahkan !');

Are you sure session('guard') of type Illuminate\Session\SessionManager|Illuminate\Session\Store|mixed can be used in concatenation?

        }

        return redirect(route(session('guard').'.article.create'))->with('failed', 'Gagal menambahkan artikel.');
    }

    /**
     * @param $id
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function show($id)
    {
        $article = Articles::find($id);
        if(!$article) {
            abort(404);
        }
        return view('pages.ext.view-article')->with('article', $article);
    }

    /**
     * @param $cat
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function listByCat($cat)
    {
        $category = null;

        switch ($cat) {
            case "penyakit":
                $category = "Penyakit";
                break;
            case "obat":
                $category = "Obat - obatan";
                break;
            case "hidup-sehat":
                $category = "Hidup Sehat";
                break;
            case "keluarga":
                $category = "Keluarga";
                break;
            case "kesehatan":
                $category = "Kesehatan";
                break;
        }

        $data = [
            'articles' => Articles::where('category', $cat)->orderBy('title','asc')->get(),
            'category' => $category,
            'cat' => $cat
        ];

        return view('articles')->with('data', $data);
    }

    public function listByName($cat, $name)
    {
        $category = null;

        switch ($cat) {
            case "penyakit":
                $category = "Penyakit";
                break;
            case "obat":
                $category = "Obat - obatan";
                break;
            case "hidup-sehat":
                $category = "Hidup Sehat";
                break;
            case "keluarga":
                $category = "Keluarga";
                break;
            case "kesehatan":
                $category = "Kesehatan";
                break;
        }
            $data = [
                'articles' => Articles::where('category', $cat)
                                        ->where('title','LIKE',$name.'%')
                                        ->orderBy('title','asc')
                                        ->get(),
                'category' => $category,
                'cat' => $cat
            ];

        return view('articles')->with('data', $data);
    }

    public function search(Request $request, $cat)
    {
        $cari = $request->cari;
        $articles = Articles::where('category', $cat)
                        ->where('content','LIKE','%'.$cari.'%')
                        ->orderBy('title','asc')
                        ->get();
        $category = null;
        switch ($cat) {
            case "penyakit":
                $category = "Penyakit";
                break;
            case "obat":
                $category = "Obat - obatan";
                break;
            case "hidup-sehat":
                $category = "Hidup Sehat";
                break;
            case "keluarga":
                $category = "Keluarga";
                break;
            case "kesehatan":
                $category = "Kesehatan";
                break;
        }

        $data = [
            'articles' => $articles,
            'category' => $category,
            'cat' => $cat
        ];
        return view('articles')->with('data', $data);
    }

    /**
     * @param $id
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function edit($id)
    {
        $article = Articles::find($id);
        if(!$article) {
            abort(404);
        }

        if($article->writer()['data']->id != Auth::guard(session('guard'))->user()->id) {

It seems like session('guard') can also be of type Illuminate\Session\SessionManager and Illuminate\Session\Store; however, parameter $name of Illuminate\Support\Facades\Auth::guard() does only seem to accept null|string, maybe add an additional type check?

            return redirect(session('guard').'/article')->with('warning', 'Anda tidak berhak untuk mengubah Artikel tersebut.');

Are you sure session('guard') of type Illuminate\Session\SessionManager|Illuminate\Session\Store|mixed can be used in concatenation?

The expression return redirect(session('guard') . '/article')->with('warning', 'Anda tidak berhak untuk mengubah Artikel tersebut.') returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Contracts\View\Factory|Illuminate\View\View.

        }

        $data = [
            'article' => $article
        ];
        return view('pages.ext.edit-article')->with('data', $data);
    }

    /**
     * @param Request $request
     * @param $id
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
     * @throws \Illuminate\Validation\ValidationException
     */
    public function update(Request $request, $id)
    {
        $this->validate($request,[
            'category' => 'required',
            'title' => 'required',
            'content' => 'required|min:500',
            'cover_image' => 'image|nullable|max:3999'

        ]);

        if($request->hasFile('cover_image')){
            $filenameWithExt = $request->file('cover_image')->getClientOriginalName();
            $filename = pathinfo($filenameWithExt, PATHINFO_FILENAME);
            $extension = $request->file('cover_image')->getClientOriginalExtension();
            $fileNameToStore = $filename.'_'.time().'.'.$extension;
            $path = $request->file('cover_image')->storeAs('public/cover_images', $fileNameToStore);

The assignment to $path is dead and can be removed.

        }

        $article = Articles::find($id);
        $article->category = $request->input('category');
        $article->title = $request->input('title');
        $article->content = $request->input('content');
        if($request->hasFile('cover_image')){
            $article->cover_image = $fileNameToStore;

The variable $fileNameToStore does not seem to be defined for all execution paths leading up to this point.

        }

        $log = null;
        if($article->save()) {
            $log = Common::registerLog([
                'action' => "membuat perubahan pada artikelnya.",
                'target' => 'article',
                'prefix' => 'a-update',
                'target_id' => $article->id,
                'actor' => session('guard'),
                'actor_id' => Common::currentUser(session('guard'))->id
            ]);
        }

        if($log != null && $log == true) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            return redirect (route(session('guard').'.article.index'))->with('success', 'Artikel berhasil diubah !');

Are you sure session('guard') of type Illuminate\Session\SessionManager|Illuminate\Session\Store|mixed can be used in concatenation?

        }

        return redirect (route(session('guard').'.article.edit', $id))->with('failed', 'Gagal mengubah artikel !');
    }

    /**
     * @param $id
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
     */
    public function destroy($id)
    {
        $article = Articles::find($id);

        if($article->cover_image != 'noimage.jpg'){
            Storage::delete('public/cover_images/'.$article->cover_image);
        }

        $unreg = null;
        if($article->delete()) {
            $unreg = Common::unregisterLog([
                'target' => 'article',
                'target_id' => $id
            ]);
        }
        if($unreg != null && $unreg) {
            return redirect()->back()->with('success', 'Artikel dihapus !');
        }

        return redirect()->back()->with('failed', 'Gagal menghapus artikel.');
    }

    /**
     * Get current logged in user
     *
     * @return mixed
     */
    private function currentUser() {
        return Auth::guard(session('guard'))->user();

It seems like session('guard') can also be of type Illuminate\Session\SessionManager and Illuminate\Session\Store; however, parameter $name of Illuminate\Support\Facades\Auth::guard() does only seem to accept null|string, maybe add an additional type check?

    }
}