ThreadAskController::deleteTopic() - Code Metrics - Inspection of "Thread ask 2" - flying-coders/SIFIKS - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#63)

by Faiq

created 2019-04-17 14:42 UTC

ThreadAskController::deleteTopic() A

↳ Parent: ThreadAskController

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	4
nc	2
nop	1
dl	0
loc	6
rs	10
c	0
b	0
f	0

<?php

namespace App\Http\Controllers;

use Illuminate\Support\Facades\Auth;
use Illuminate\Http\Request;
use App\Thread;
use App\ThreadTopic;

class ThreadAskController extends Controller
{
    public function __construct()
    {
        $this->middleware('auth', ['except' => [
            'index', 'show'
        ]]);
    }


    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $threads = Thread::orderBy('created_at', 'desc')->paginate(5);
        $data = [
            'threads' => $threads
        ];
        return view('ask-index')->with('data', $data);

    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $threads = Thread::orderBy('created_at', 'desc')->paginate(5);
        $data = [
            'threads' => $threads
        ];
        return view('ask-form')->with('data', $data);

    }

    /**
     * Store a newly created resource in storage.
     *
     * @param Request $request
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
     * @throws \Illuminate\Validation\ValidationException
     */
    public function store(Request $request)
    {
        $this->validate($request, [
            'topic' => 'required|min:10',
            'question' => 'required|min:100'
        ]);

        $topic = $this->addTopic($request->input('topic'));

        if($topic != null) {
            $thread = new Thread;
            $thread->user_id = $this->currentUser()->id;
            $thread->id_topic = $topic->id;
            $thread->question = $request->input('question');

            if($thread->save()) {
                return redirect(route('user.thread.index'))->with('success', 'Pertanyaan dikirim !');
            }
            return redirect()->back()->with('failed', 'Gagal mengirim pertanyaan, silahkan coba lagi nanti.');
        }
        return redirect()->back()->with('failed', 'Gagal mengirim pertanyaan, silahkan coba lagi nanti.');
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $thread = Thread::find($id);
        if(!$thread) {
            abort(404);
        }

        $threads = Thread::orderBy('created_at', 'desc')->paginate(5);
        $data = [
            'thread' => $thread,
            'threads' => $threads
        ];
        return view('ask-view')->with('data', $data);

    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    {
        $user = $this->currentUser();
        $thread = Thread::find($id);
        if($thread->user_id != $user->id) {
            return redirect()->back()->with('warning', 'Anda tidak berhak mengakses laman tersebut.');

        }

        if($thread->doctor_id != null) {
            return redirect()->back()->with('warning', 'Tidak dapat mengubah pertanyaan karena sudah terjawab, silahkan tanyakan pertanyaan baru.');

        }
        $threads = Thread::orderBy('created_at', 'desc')->paginate(5);
        $data = [
            'thread' => $thread,
            'threads' => $threads
        ];

        return view('ask-edit')->with('data', $data);


    }

    /**
     * Update the specified resource in storage.
     *
     * @param Request $request
     * @param $id
     * @return \Illuminate\Http\RedirectResponse
     * @throws \Illuminate\Validation\ValidationException
     */
    public function update(Request $request, $id)
    {
        $user = $this->currentUser();
        $thread = Thread::find($id);
        if($thread->user_id != $user->id) {
            return redirect()->back()->with('warning', 'Anda tidak berhak mengubah ulasan tersebut.');
        }

        $this->validate($request, [
            'topic' => 'required|min:10',
            'question' => 'required|min:100'
        ]);

        $thread->topic = $request->input('topic');
        $thread->question = $request->input('question');
        if($thread->save()) {
            return redirect(route('user.thread.show', $thread->id))->with('success', 'Berhasil mengubah ulasan !');
        }
        return redirect(route('user.thread.show', $thread->id))->with('success', 'Berhasil mengubah ulasan !');
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        $user = $this->currentUser();
        $thread = Thread::find($id);
        if($thread->user_id != $user->id) {
            return redirect()->back()->with('warning', 'Anda tidak berhak menghapus ulasan tersebut.');

        }

        if($thread->delete() && $this->deleteTopic($thread->id_topic)) {
            return redirect(route('user.profile'))->with('success', 'Ulasan dihapus !');

        }
        return redirect()->back()->with('failed', 'Gagal menghapus ulasan.');

    }


    private function currentUser() {
        return Auth::guard('web')->user();
    }

    /**
     * @param string $topic
     * @return ThreadTopic|null
     */
    private function addTopic(string $topic) {
        $new = new ThreadTopic;
        $new->topic_name = $topic;
        if($new->save()) {
            return $new;
        }
        return null;
    }

    /**
     * Delete topic with given id
     *
     * @param int $id
     * @return bool
     */
    private function deleteTopic($id) {
        $topic = ThreadTopic::find($id);
        if($topic->delete()) {
            return true;
        }
        return false;
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use Illuminate\Support\Facades\Auth;
6			use Illuminate\Http\Request;
7			use App\Thread;
8			use App\ThreadTopic;
9
10			class ThreadAskController extends Controller
11			{
12			public function __construct()
13			{
14			$this->middleware('auth', ['except' => [
15			'index', 'show'
16			]]);
17			}
18
19
20			/**
21			* Display a listing of the resource.
22			*
23			* @return \Illuminate\Http\Response
24			*/
25			public function index()
26			{
27			$threads = Thread::orderBy('created_at', 'desc')->paginate(5);
28			$data = [
29			'threads' => $threads
30			];
31			return view('ask-index')->with('data', $data);
			0 ignored issues – show Bug Best Practice introduced 2019-04-17 14:47 UTC by Report Bug Copy Issue Report The expression `return view('ask-index')->with('data', $data)` returns the type `Illuminate\View\View` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
32			}
33
34			/**
35			* Show the form for creating a new resource.
36			*
37			* @return \Illuminate\Http\Response
38			*/
39			public function create()
40			{
41			$threads = Thread::orderBy('created_at', 'desc')->paginate(5);
42			$data = [
43			'threads' => $threads
44			];
45			return view('ask-form')->with('data', $data);
			0 ignored issues – show Bug Best Practice introduced 2019-04-17 14:47 UTC by Report Bug Copy Issue Report The expression `return view('ask-form')->with('data', $data)` returns the type `Illuminate\View\View` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
46			}
47
48			/**
49			* Store a newly created resource in storage.
50			*
51			* @param Request $request
52			* @return \Illuminate\Http\RedirectResponse\|\Illuminate\Routing\Redirector
53			* @throws \Illuminate\Validation\ValidationException
54			*/
55			public function store(Request $request)
56			{
57			$this->validate($request, [
58			'topic' => 'required\|min:10',
59			'question' => 'required\|min:100'
60			]);
61
62			$topic = $this->addTopic($request->input('topic'));
63
64			if($topic != null) {
65			$thread = new Thread;
66			$thread->user_id = $this->currentUser()->id;
67			$thread->id_topic = $topic->id;
68			$thread->question = $request->input('question');
69
70			if($thread->save()) {
71			return redirect(route('user.thread.index'))->with('success', 'Pertanyaan dikirim !');
72			}
73			return redirect()->back()->with('failed', 'Gagal mengirim pertanyaan, silahkan coba lagi nanti.');
74			}
75			return redirect()->back()->with('failed', 'Gagal mengirim pertanyaan, silahkan coba lagi nanti.');
76			}
77
78			/**
79			* Display the specified resource.
80			*
81			* @param int $id
82			* @return \Illuminate\Http\Response
83			*/
84			public function show($id)
85			{
86			$thread = Thread::find($id);
87			if(!$thread) {
88			abort(404);
89			}
90
91			$threads = Thread::orderBy('created_at', 'desc')->paginate(5);
92			$data = [
93			'thread' => $thread,
94			'threads' => $threads
95			];
96			return view('ask-view')->with('data', $data);
			0 ignored issues – show Bug Best Practice introduced 2019-04-17 14:47 UTC by Report Bug Copy Issue Report The expression `return view('ask-view')->with('data', $data)` returns the type `Illuminate\View\View` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
97			}
98
99			/**
100			* Show the form for editing the specified resource.
101			*
102			* @param int $id
103			* @return \Illuminate\Http\Response
104			*/
105			public function edit($id)
106			{
107			$user = $this->currentUser();
108			$thread = Thread::find($id);
109			if($thread->user_id != $user->id) {
110			return redirect()->back()->with('warning', 'Anda tidak berhak mengakses laman tersebut.');
			0 ignored issues – show Bug Best Practice introduced 2019-04-17 14:47 UTC by Report Bug Copy Issue Report The expression `return redirect()->back(...akses laman tersebut.')` returns the type `Illuminate\Http\RedirectResponse` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
111			}
112
113			if($thread->doctor_id != null) {
114			return redirect()->back()->with('warning', 'Tidak dapat mengubah pertanyaan karena sudah terjawab, silahkan tanyakan pertanyaan baru.');
			0 ignored issues – show Bug Best Practice introduced 2019-04-17 14:47 UTC by Report Bug Copy Issue Report The expression `return redirect()->back(...akan pertanyaan baru.')` returns the type `Illuminate\Http\RedirectResponse` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
115			}
116			$threads = Thread::orderBy('created_at', 'desc')->paginate(5);
117			$data = [
118			'thread' => $thread,
119			'threads' => $threads
120			];
121
122			return view('ask-edit')->with('data', $data);
			0 ignored issues – show Bug Best Practice introduced 2019-04-17 14:47 UTC by Report Bug Copy Issue Report The expression `return view('ask-edit')->with('data', $data)` returns the type `Illuminate\View\View` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
123
124			}
125
126			/**
127			* Update the specified resource in storage.
128			*
129			* @param Request $request
130			* @param $id
131			* @return \Illuminate\Http\RedirectResponse
132			* @throws \Illuminate\Validation\ValidationException
133			*/
134			public function update(Request $request, $id)
135			{
136			$user = $this->currentUser();
137			$thread = Thread::find($id);
138			if($thread->user_id != $user->id) {
139			return redirect()->back()->with('warning', 'Anda tidak berhak mengubah ulasan tersebut.');
140			}
141
142			$this->validate($request, [
143			'topic' => 'required\|min:10',
144			'question' => 'required\|min:100'
145			]);
146
147			$thread->topic = $request->input('topic');
148			$thread->question = $request->input('question');
149			if($thread->save()) {
150			return redirect(route('user.thread.show', $thread->id))->with('success', 'Berhasil mengubah ulasan !');
151			}
152			return redirect(route('user.thread.show', $thread->id))->with('success', 'Berhasil mengubah ulasan !');
153			}
154
155			/**
156			* Remove the specified resource from storage.
157			*
158			* @param int $id
159			* @return \Illuminate\Http\Response
160			*/
161			public function destroy($id)
162			{
163			$user = $this->currentUser();
164			$thread = Thread::find($id);
165			if($thread->user_id != $user->id) {
166			return redirect()->back()->with('warning', 'Anda tidak berhak menghapus ulasan tersebut.');
			0 ignored issues – show Bug Best Practice introduced 2019-04-17 14:47 UTC by Report Bug Copy Issue Report The expression `return redirect()->back(...apus ulasan tersebut.')` returns the type `Illuminate\Http\RedirectResponse` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
167			}
168
169			if($thread->delete() && $this->deleteTopic($thread->id_topic)) {
170			return redirect(route('user.profile'))->with('success', 'Ulasan dihapus !');
			0 ignored issues – show Bug Best Practice introduced 2019-04-17 14:47 UTC by Report Bug Copy Issue Report The expression `return redirect(route('u...s', 'Ulasan dihapus !')` returns the type `Illuminate\Http\RedirectResponse` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
171			}
172			return redirect()->back()->with('failed', 'Gagal menghapus ulasan.');
			0 ignored issues – show Bug Best Practice introduced 2019-04-17 14:47 UTC by Report Bug Copy Issue Report The expression `return redirect()->back(...gal menghapus ulasan.')` returns the type `Illuminate\Http\RedirectResponse` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
173			}
174
175
176			private function currentUser() {
177			return Auth::guard('web')->user();
178			}
179
180			/**
181			* @param string $topic
182			* @return ThreadTopic\|null
183			*/
184			private function addTopic(string $topic) {
185			$new = new ThreadTopic;
186			$new->topic_name = $topic;
187			if($new->save()) {
188			return $new;
189			}
190			return null;
191			}
192
193			/**
194			* Delete topic with given id
195			*
196			* @param int $id
197			* @return bool
198			*/
199			private function deleteTopic($id) {
200			$topic = ThreadTopic::find($id);
201			if($topic->delete()) {
202			return true;
203			}
204			return false;
205			}
206			}
207

flying-coders / SIFIKS

Pull Request — master (#63)

ThreadAskController::deleteTopic() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like