main_test::setUp() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/florin..." - florinp/phpbb-messenger - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cd6ca3...800f7e )

by Florin

created 2016-03-28 19:17 UTC

main_test::setUp() A

↳ Parent: main_test

Complexity

Conditions	1
Paths	1

Size

Total Lines	59
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	59
rs	9.597
cc	1
eloc	29
nc	1
nop	0

How to fix Long Method

<?php

namespace florinp\messenger\tests\controller;

use Symfony\Component\HttpFoundation\JsonResponse;

class main_test extends \phpbb_test_case {

    /**
     * @var \florinp\messenger\controller\main
     */
    protected $controller;

    public function setUp() {
        parent::setUp();
        /**
         * @var \phpbb\user $user Mock the user class
         */
        $user = $this->getMock('\phpbb\user', array(), array('\phpbb\datetime'));

        /**
         * @var \phpbb\request\request $request
         */
        $request = $this->getMockBuilder('\phpbb\request\request')
            ->disableOriginalConstructor()
            ->getMock();

        /**
         * @var \florinp\messenger\models\main_model $model
         */
        $model = $this->getMockBuilder('\florinp\messenger\models\main_model')
            ->disableOriginalConstructor()
            ->getMock();

        /**
         * @var \phpbb\notification\manager $notification_manager
         */
        $notification_manager = $this->getMockBuilder('\phpbb\notification\manager')
            ->disableOriginalConstructor()
            ->getMock();

        /**
         * @var \florinp\messenger\libs\emojione $emojione
         */
        $emojione = $this->getMockBuilder('\florinp\messenger\libs\emojione')
            ->disableOriginalConstructor()
            ->getMock();

        /**
         * @var \florinp\messenger\libs\upload $upload
         */
        $upload = $this->getMockBuilder('\florinp\messenger\libs\upload')
            ->disableOriginalConstructor()
            ->getMock();

        /**
         * @var \florinp\messenger\libs\download $download
         */
        $download = $this->getMockBuilder('\florinp\messenger\libs\download')
            ->disableOriginalConstructor()
            ->getMock();

        $this->controller = new \florinp\messenger\controller\main(
            $request,
            $user,
            $model,
            $notification_manager,
            $emojione,
            $upload,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $download

        );
    }

    public function tearDown() {
        $this->controller = null;
        parent::tearDown();
    }

    public function publish_data() {
        return array(
            array(200, json_encode(array()))
        );
    }
    /**
     * @dataProvider publish_data
     */
    public function test_publish($status_code, $page_content) {

        $response = $this->controller->publish();
        $this->assertInstanceOf('\Symfony\Component\HttpFoundation\Response', $response);
        $this->assertEquals($status_code, $response->getStatusCode());
        $this->assertEquals($page_content, $response->getContent());
    }


    public function load_data() {
        return array(
            array(200, json_encode(array(
                'success' => false,
                'error' => 'The request is invalid'
            )))
        );
    }
    /**
     * @dataProvider load_data
     */
    public function test_load($status_code, $page_content) {

        $response = $this->controller->load();
        $this->assertInstanceOf('\Symfony\Component\HttpFoundation\Response', $response);
        $this->assertEquals($status_code, $response->getStatusCode());
        $this->assertEquals($page_content, $response->getContent());
    }


    public function updateMessages_data() {
        return array(
            array(200, json_encode(array('success' => false)))
        );
    }
}

1		<?php
2
3		namespace florinp\messenger\tests\controller;
4
5		use Symfony\Component\HttpFoundation\JsonResponse;
6
7		class main_test extends \phpbb_test_case {
8
9		/**
10		* @var \florinp\messenger\controller\main
11		*/
12		protected $controller;
13
14		public function setUp() {
15		parent::setUp();
16		/**
17		* @var \phpbb\user $user Mock the user class
18		*/
19		$user = $this->getMock('\phpbb\user', array(), array('\phpbb\datetime'));
20
21		/**
22		* @var \phpbb\request\request $request
23		*/
24		$request = $this->getMockBuilder('\phpbb\request\request')
25		->disableOriginalConstructor()
26		->getMock();
27
28		/**
29		* @var \florinp\messenger\models\main_model $model
30		*/
31		$model = $this->getMockBuilder('\florinp\messenger\models\main_model')
32		->disableOriginalConstructor()
33		->getMock();
34
35		/**
36		* @var \phpbb\notification\manager $notification_manager
37		*/
38		$notification_manager = $this->getMockBuilder('\phpbb\notification\manager')
39		->disableOriginalConstructor()
40		->getMock();
41
42		/**
43		* @var \florinp\messenger\libs\emojione $emojione
44		*/
45		$emojione = $this->getMockBuilder('\florinp\messenger\libs\emojione')
46		->disableOriginalConstructor()
47		->getMock();
48
49		/**
50		* @var \florinp\messenger\libs\upload $upload
51		*/
52		$upload = $this->getMockBuilder('\florinp\messenger\libs\upload')
53		->disableOriginalConstructor()
54		->getMock();
55
56		/**
57		* @var \florinp\messenger\libs\download $download
58		*/
59		$download = $this->getMockBuilder('\florinp\messenger\libs\download')
60		->disableOriginalConstructor()
61		->getMock();
62
63		$this->controller = new \florinp\messenger\controller\main(
64		$request,
65		$user,
66		$model,
67		$notification_manager,
68		$emojione,
69		$upload,
		0 ignored issues – show Documentation introduced 2016-03-28 19:19 UTC by Report Bug Copy Issue Report `$upload` is of type `object<florinp\messenger\libs\upload>`, but the function expects a `object<florinp\messenger\libs\download>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
70		$download
		0 ignored issues – show Unused Code introduced 2016-03-28 19:19 UTC by Report Bug Copy Issue Report The call to `main::__construct()` has too many arguments starting with `$download`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
71		);
72		}
73
74		public function tearDown() {
75		$this->controller = null;
76		parent::tearDown();
77		}
78
79		public function publish_data() {
80		return array(
81		array(200, json_encode(array()))
82		);
83		}
84		/**
85		* @dataProvider publish_data
86		*/
87	View Code Duplication	public function test_publish($status_code, $page_content) {
		0 ignored issues – show Duplication introduced 2016-03-26 16:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
88		$response = $this->controller->publish();
89		$this->assertInstanceOf('\Symfony\Component\HttpFoundation\Response', $response);
90		$this->assertEquals($status_code, $response->getStatusCode());
91		$this->assertEquals($page_content, $response->getContent());
92		}
93
94
95		public function load_data() {
96		return array(
97		array(200, json_encode(array(
98		'success' => false,
99		'error' => 'The request is invalid'
100		)))
101		);
102		}
103		/**
104		* @dataProvider load_data
105		*/
106	View Code Duplication	public function test_load($status_code, $page_content) {
		0 ignored issues – show Duplication introduced 2016-03-26 16:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
107		$response = $this->controller->load();
108		$this->assertInstanceOf('\Symfony\Component\HttpFoundation\Response', $response);
109		$this->assertEquals($status_code, $response->getStatusCode());
110		$this->assertEquals($page_content, $response->getContent());
111		}
112
113
114		public function updateMessages_data() {
115		return array(
116		array(200, json_encode(array('success' => false)))
117		);
118		}
119		}

florinp / phpbb-messenger

Push — master ( cd6ca3...800f7e )

main_test::setUp() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like