Issues in Persister.php (master) - Issues in master - florianajir/rabbitmq-sql-worker - Measure and Improve Code Quality continuously with Scrutinizer

Issues (73)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Persister/Persister.php (9 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Ajir\RabbitMqSqlBundle\Persister;

use Exception;
use Ajir\RabbitMqSqlBundle\DataMapper\DataMapper;
use Ajir\RabbitMqSqlBundle\Factory\EntityFactoryInterface;
use Ajir\RabbitMqSqlBundle\Factory\RelationFactoryInterface;
use Ajir\RabbitMqSqlBundle\Model\EntityInterface;
use Ajir\RabbitMqSqlBundle\Provider\ProviderInterface;

/**
 * Class Persister
 *
 * @author Florian Ajir <[email protected]>
 */
class Persister implements PersisterInterface
{
    /**
     * @var ProviderInterface
     */
    protected $provider;

    /**
     * @var EntityFactoryInterface
     */
    protected $entityFactory;

    /**
     * @var RelationFactoryInterface
     */
    protected $relationFactory;

    /**
     * @param ProviderInterface        $provider
     * @param EntityFactoryInterface   $entityFactory
     * @param RelationFactoryInterface $relationFactory
     */
    public function __construct(
        ProviderInterface $provider,
        EntityFactoryInterface $entityFactory,
        RelationFactoryInterface $relationFactory
    ) {
        $this->provider = $provider;
        $this->entityFactory = $entityFactory;
        $this->relationFactory = $relationFactory;
    }

    /**
     * Persist data
     *
     * @param array $data An associative array containing column-value pairs.
     *
     * @throws Exception
     */
    public function persist(array $data)
    {
        foreach ($data as $infos) {
            $entity = $this->entityFactory->create($infos);
            $this->persistRecursive($entity);
        }
    }

    /**
     * Persist data recursively
     *
     * @param EntityInterface $entity
     *
     * @return array
     *
     * @throws Exception
     */
    protected function persistRecursive(EntityInterface $entity)
    {
        $entity->addDataSet($this->persistOneToOneRelations($entity));
        $entity->addDataSet($this->persistManyToOneRelations($entity));
        $id = $this->insertOrUpdateIfExists($entity);
        if ($entity->getIdentifier() === null) {
            $entity->setIdentifier(array('id' => $id));
        }
        $this->persistOneToManyRelations($entity);
        $this->persistManyToManyRelations($entity);

        return $entity->getIdentifier();
    }

    /**
     * Persist oneToOne relations
     *
     * @param EntityInterface $entity
     *
     * @return array associative array( 'foreign_key' => 'value' )
     *
     * @throws Exception
     */
    protected function persistOneToOneRelations(EntityInterface $entity)

    {
        $joinData = array();
        $relations = $entity->getOneToOneRelations();
        foreach ($relations as $relation) {
            $oneToOne = $this->relationFactory->create(DataMapper::RELATION_ONE_TO_ONE, $relation);
            $entity = $this->entityFactory->create($oneToOne->getEntity());

            $id = $this->persistRecursive($entity);
            $joinVal = $entity->getProperty($oneToOne->getJoinColumnReferencedColumnName());
            $joinData[$oneToOne->getJoinColumnName()] = !is_null($joinVal)
                ? $joinVal
                : $this->provider->getColumnValueWhere(
                    $oneToOne->getTable(),
                    $oneToOne->getJoinColumnReferencedColumnName(),
                    key($id),
                    current($id)
                );
        }

        return $joinData;
    }

    /**
     * Persist manyToOne relations
     *
     * @param EntityInterface $entity
     *
     * @return array associative array( 'foreign_key' => 'value' )
     *
     * @throws Exception
     */
    protected function persistManyToOneRelations(EntityInterface $entity)

    {
        $joinData = array();
        $relations = $entity->getManyToOneRelations();
        foreach ($relations as $relation) {
            $manyToOne = $this->relationFactory->create(DataMapper::RELATION_MANY_TO_ONE, $relation);
            $entity = $this->entityFactory->create($manyToOne->getEntity());

            $id = $this->persistRecursive($entity);
            $joinVal = $entity->getProperty($manyToOne->getJoinColumnReferencedColumnName());
            $joinData[$manyToOne->getJoinColumnName()] = !is_null($joinVal)
                ? $joinVal
                : $this->provider->getColumnValueWhere(
                    $manyToOne->getTable(),
                    $manyToOne->getJoinColumnReferencedColumnName(),
                    key($id),
                    current($id)
                );
        }

        return $joinData;
    }

    /**
     * @param EntityInterface $entity
     *
     * @return int
     */
    protected function insertOrUpdateIfExists(EntityInterface $entity)
    {
        return $this->provider->insertOrUpdateIfExists(
            $entity->getTable(),
            $entity->getData(),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $entity->getIdentifier()
        );
    }

    /**
     * @param EntityInterface $entity
     *
     * @throws Exception
     */
    protected function persistOneToManyRelations(EntityInterface $entity)
    {
        $relations = $entity->getOneToManyRelations();
        foreach ($relations as $relation) {
            $oneToMany = $this->relationFactory->create(DataMapper::RELATION_ONE_TO_MANY, $relation);
            $foreignValue = $entity->getProperty($oneToMany->getJoinColumnReferencedColumnName());
            $parentIdent = $entity->getIdentifier();
            if (is_null($foreignValue) && !empty($parentIdent)) {

                $foreignValue = $this->provider->getColumnValueWhere(
                    $entity->getTable(),
                    $oneToMany->getJoinColumnReferencedColumnName(),
                    key($parentIdent),
                    current($parentIdent)
                );
            }
            if (is_null($foreignValue)) {
                throw new Exception("Unable to get an identifier. (Table: {$entity->getTable()})");
            }

            foreach ($oneToMany->getEntities() as $childData) {
                $child = $this->entityFactory->create($childData[$oneToMany->getEntityName()]);
                $joinData = array($oneToMany->getJoinColumnName() => $foreignValue);
                foreach ($oneToMany->getReferences() as $field => $reference) {
                    $referenceValue = $this->provider->getColumnValueWhere(
                        $reference[DataMapper::MAPPING_KEY_TABLE],
                        $reference[DataMapper::RELATION_KEY_JOIN_COLUMN_REFERENCED_COLUMN_NAME],
                        key($reference[DataMapper::WHERE_KEY]),
                        current($reference[DataMapper::WHERE_KEY])
                    );
                    $joinData[$field] = $referenceValue;
                }
                $child->addDataSet($joinData);
                if ($oneToMany->isRemoveReferenced()) {
                    $this->provider->delete($oneToMany->getTable(), $joinData);
                }
                $this->persistRecursive($child);
            }
        }
    }

    /**
     * @param EntityInterface $entity
     *
     * @throws Exception
     */
    protected function persistManyToManyRelations(EntityInterface $entity)
    {
        $relations = $entity->getManyToManyRelations();
        foreach ($relations as $relation) {
            $manyToMany = $this->relationFactory->create(DataMapper::RELATION_MANY_TO_MANY, $relation);
            $foreignValue = $entity->getProperty($manyToMany->getJoinColumnReferencedColumnName());
            $parentIdent = $entity->getIdentifier();
            if (is_null($foreignValue) && !empty($parentIdent)) {

                $foreignValue = $this->provider->getColumnValueWhere(
                    $entity->getTable(),
                    $manyToMany->getJoinColumnReferencedColumnName(),
                    key($parentIdent),
                    current($parentIdent)
                );
            }
            if (is_null($foreignValue)) {
                throw new Exception("Unable to get an identifier. (Table: {$entity->getTable()})");
            }
            $joinData = array(
                $manyToMany->getJoinColumnName() => $foreignValue
            );
            //delete joins before loop
            $this->provider->delete($manyToMany->getJoinTableName(), $joinData);
            foreach ($manyToMany->getEntities() as $childData) {
                $child = $this->entityFactory->create($childData[$manyToMany->getEntityName()]);
                $this->persistRecursive($child);
                $newJoinDataValue = $child->getProperty($manyToMany->getInverseJoinColumnReferencedColumnName());

                $joinIdent = $child->getIdentifier();
                $joinData[$manyToMany->getInverseJoinColumnName()] = !is_null($newJoinDataValue)
                    ? $newJoinDataValue
                    : $this->provider->getColumnValueWhere(
                        $child->getTable(),
                        $manyToMany->getInverseJoinColumnReferencedColumnName(),

                        key($joinIdent),
                        current($joinIdent)
                    );
                //insert in join table
                $this->provider->insert($manyToMany->getJoinTableName(), $joinData);
            }
        }
    }
}


1			<?php
2			namespace Ajir\RabbitMqSqlBundle\Persister;
3
4			use Exception;
5			use Ajir\RabbitMqSqlBundle\DataMapper\DataMapper;
6			use Ajir\RabbitMqSqlBundle\Factory\EntityFactoryInterface;
7			use Ajir\RabbitMqSqlBundle\Factory\RelationFactoryInterface;
8			use Ajir\RabbitMqSqlBundle\Model\EntityInterface;
9			use Ajir\RabbitMqSqlBundle\Provider\ProviderInterface;
10
11			/**
12			* Class Persister
13			*
14			* @author Florian Ajir <[email protected]>
15			*/
16			class Persister implements PersisterInterface
17			{
18			/**
19			* @var ProviderInterface
20			*/
21			protected $provider;
22
23			/**
24			* @var EntityFactoryInterface
25			*/
26			protected $entityFactory;
27
28			/**
29			* @var RelationFactoryInterface
30			*/
31			protected $relationFactory;
32
33			/**
34			* @param ProviderInterface $provider
35			* @param EntityFactoryInterface $entityFactory
36			* @param RelationFactoryInterface $relationFactory
37			*/
38	1		public function __construct(
39			ProviderInterface $provider,
40			EntityFactoryInterface $entityFactory,
41			RelationFactoryInterface $relationFactory
42			) {
43	1		$this->provider = $provider;
44	1		$this->entityFactory = $entityFactory;
45	1		$this->relationFactory = $relationFactory;
46	1		}
47
48			/**
49			* Persist data
50			*
51			* @param array $data An associative array containing column-value pairs.
52			*
53			* @throws Exception
54			*/
55	1		public function persist(array $data)
56			{
57	1		foreach ($data as $infos) {
58	1		$entity = $this->entityFactory->create($infos);
59	1		$this->persistRecursive($entity);
60			}
61	1		}
62
63			/**
64			* Persist data recursively
65			*
66			* @param EntityInterface $entity
67			*
68			* @return array
69			*
70			* @throws Exception
71			*/
72	1		protected function persistRecursive(EntityInterface $entity)
73			{
74	1		$entity->addDataSet($this->persistOneToOneRelations($entity));
75	1		$entity->addDataSet($this->persistManyToOneRelations($entity));
76	1		$id = $this->insertOrUpdateIfExists($entity);
77	1		if ($entity->getIdentifier() === null) {
78	1		$entity->setIdentifier(array('id' => $id));
79			}
80	1		$this->persistOneToManyRelations($entity);
81	1		$this->persistManyToManyRelations($entity);
82
83	1		return $entity->getIdentifier();
84			}
85
86			/**
87			* Persist oneToOne relations
88			*
89			* @param EntityInterface $entity
90			*
91			* @return array associative array( 'foreign_key' => 'value' )
92			*
93			* @throws Exception
94			*/
95	1	View Code Duplication	protected function persistOneToOneRelations(EntityInterface $entity)
			0 ignored issues – show Duplication introduced 2016-05-03 20:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
96			{
97	1		$joinData = array();
98	1		$relations = $entity->getOneToOneRelations();
99	1		foreach ($relations as $relation) {
100	1		$oneToOne = $this->relationFactory->create(DataMapper::RELATION_ONE_TO_ONE, $relation);
101	1		$entity = $this->entityFactory->create($oneToOne->getEntity());
			0 ignored issues – show Bug introduced 2016-05-03 20:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getEntity()` does not exist on `Ajir\RabbitMqSqlBundle\Model\RelationInterface`. Did you maybe mean `getEntityName()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
102	1		$id = $this->persistRecursive($entity);
103	1		$joinVal = $entity->getProperty($oneToOne->getJoinColumnReferencedColumnName());
104	1		$joinData[$oneToOne->getJoinColumnName()] = !is_null($joinVal)
105			? $joinVal
106	1		: $this->provider->getColumnValueWhere(
107	1		$oneToOne->getTable(),
108	1		$oneToOne->getJoinColumnReferencedColumnName(),
109			key($id),
110			current($id)
111			);
112			}
113
114	1		return $joinData;
115			}
116
117			/**
118			* Persist manyToOne relations
119			*
120			* @param EntityInterface $entity
121			*
122			* @return array associative array( 'foreign_key' => 'value' )
123			*
124			* @throws Exception
125			*/
126	1	View Code Duplication	protected function persistManyToOneRelations(EntityInterface $entity)
			0 ignored issues – show Duplication introduced 2016-05-03 20:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
127			{
128	1		$joinData = array();
129	1		$relations = $entity->getManyToOneRelations();
130	1		foreach ($relations as $relation) {
131	1		$manyToOne = $this->relationFactory->create(DataMapper::RELATION_MANY_TO_ONE, $relation);
132	1		$entity = $this->entityFactory->create($manyToOne->getEntity());
			0 ignored issues – show Bug introduced 2016-05-03 20:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getEntity()` does not exist on `Ajir\RabbitMqSqlBundle\Model\RelationInterface`. Did you maybe mean `getEntityName()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
133	1		$id = $this->persistRecursive($entity);
134	1		$joinVal = $entity->getProperty($manyToOne->getJoinColumnReferencedColumnName());
135	1		$joinData[$manyToOne->getJoinColumnName()] = !is_null($joinVal)
136			? $joinVal
137	1		: $this->provider->getColumnValueWhere(
138	1		$manyToOne->getTable(),
139	1		$manyToOne->getJoinColumnReferencedColumnName(),
140			key($id),
141			current($id)
142			);
143			}
144
145	1		return $joinData;
146			}
147
148			/**
149			* @param EntityInterface $entity
150			*
151			* @return int
152			*/
153	1		protected function insertOrUpdateIfExists(EntityInterface $entity)
154			{
155	1		return $this->provider->insertOrUpdateIfExists(
156	1		$entity->getTable(),
157	1		$entity->getData(),
			0 ignored issues – show Documentation introduced 2016-05-03 20:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$entity->getData()` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
158	1		$entity->getIdentifier()
159			);
160			}
161
162			/**
163			* @param EntityInterface $entity
164			*
165			* @throws Exception
166			*/
167	1		protected function persistOneToManyRelations(EntityInterface $entity)
168			{
169	1		$relations = $entity->getOneToManyRelations();
170	1		foreach ($relations as $relation) {
171	1		$oneToMany = $this->relationFactory->create(DataMapper::RELATION_ONE_TO_MANY, $relation);
172	1		$foreignValue = $entity->getProperty($oneToMany->getJoinColumnReferencedColumnName());
173	1		$parentIdent = $entity->getIdentifier();
174	1	View Code Duplication	if (is_null($foreignValue) && !empty($parentIdent)) {
			0 ignored issues – show Duplication introduced 2016-05-03 20:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
175			$foreignValue = $this->provider->getColumnValueWhere(
176			$entity->getTable(),
177			$oneToMany->getJoinColumnReferencedColumnName(),
178			key($parentIdent),
179			current($parentIdent)
180			);
181			}
182	1		if (is_null($foreignValue)) {
183			throw new Exception("Unable to get an identifier. (Table: {$entity->getTable()})");
184			}
185
186	1		foreach ($oneToMany->getEntities() as $childData) {
187	1		$child = $this->entityFactory->create($childData[$oneToMany->getEntityName()]);
188	1		$joinData = array($oneToMany->getJoinColumnName() => $foreignValue);
189	1		foreach ($oneToMany->getReferences() as $field => $reference) {
190			$referenceValue = $this->provider->getColumnValueWhere(
191			$reference[DataMapper::MAPPING_KEY_TABLE],
192			$reference[DataMapper::RELATION_KEY_JOIN_COLUMN_REFERENCED_COLUMN_NAME],
193			key($reference[DataMapper::WHERE_KEY]),
194			current($reference[DataMapper::WHERE_KEY])
195			);
196			$joinData[$field] = $referenceValue;
197			}
198	1		$child->addDataSet($joinData);
199	1		if ($oneToMany->isRemoveReferenced()) {
200			$this->provider->delete($oneToMany->getTable(), $joinData);
201			}
202	1		$this->persistRecursive($child);
203			}
204			}
205	1		}
206
207			/**
208			* @param EntityInterface $entity
209			*
210			* @throws Exception
211			*/
212	1		protected function persistManyToManyRelations(EntityInterface $entity)
213			{
214	1		$relations = $entity->getManyToManyRelations();
215	1		foreach ($relations as $relation) {
216	1		$manyToMany = $this->relationFactory->create(DataMapper::RELATION_MANY_TO_MANY, $relation);
217	1		$foreignValue = $entity->getProperty($manyToMany->getJoinColumnReferencedColumnName());
218	1		$parentIdent = $entity->getIdentifier();
219	1	View Code Duplication	if (is_null($foreignValue) && !empty($parentIdent)) {
			0 ignored issues – show Duplication introduced 2016-05-03 20:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
220			$foreignValue = $this->provider->getColumnValueWhere(
221			$entity->getTable(),
222			$manyToMany->getJoinColumnReferencedColumnName(),
223			key($parentIdent),
224			current($parentIdent)
225			);
226			}
227	1		if (is_null($foreignValue)) {
228			throw new Exception("Unable to get an identifier. (Table: {$entity->getTable()})");
229			}
230			$joinData = array(
231	1		$manyToMany->getJoinColumnName() => $foreignValue
232			);
233			//delete joins before loop
234	1		$this->provider->delete($manyToMany->getJoinTableName(), $joinData);
235	1		foreach ($manyToMany->getEntities() as $childData) {
236	1		$child = $this->entityFactory->create($childData[$manyToMany->getEntityName()]);
237	1		$this->persistRecursive($child);
238	1		$newJoinDataValue = $child->getProperty($manyToMany->getInverseJoinColumnReferencedColumnName());
			0 ignored issues – show Bug introduced 2016-05-03 20:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getInverseJoinColumnReferencedColumnName()` does not exist on `Ajir\RabbitMqSqlBundle\Model\RelationInterface`. Did you maybe mean `getJoinColumnReferencedColumnName()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
239	1		$joinIdent = $child->getIdentifier();
240	1		$joinData[$manyToMany->getInverseJoinColumnName()] = !is_null($newJoinDataValue)
241			? $newJoinDataValue
242	1		: $this->provider->getColumnValueWhere(
243	1		$child->getTable(),
244	1		$manyToMany->getInverseJoinColumnReferencedColumnName(),
			0 ignored issues – show Bug introduced 2016-05-03 20:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getInverseJoinColumnReferencedColumnName()` does not exist on `Ajir\RabbitMqSqlBundle\Model\RelationInterface`. Did you maybe mean `getJoinColumnReferencedColumnName()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
245			key($joinIdent),
246			current($joinIdent)
247			);
248			//insert in join table
249	1		$this->provider->insert($manyToMany->getJoinTableName(), $joinData);
250			}
251			}
252	1		}
253			}
254

florianajir / rabbitmq-sql-worker

Issues (73)

Security Analysis no request data

Persister/Persister.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like