Issues in DataMapper.php (master) - Issues in master - florianajir/rabbitmq-sql-worker - Measure and Improve Code Quality continuously with Scrutinizer

Issues (73)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

DataMapper/DataMapper.php (8 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Ajir\RabbitMqSqlBundle\DataMapper;

use InvalidArgumentException;

/**
 * Class DataMapper
 *
 * @author Florian Ajir <[email protected]>
 */
class DataMapper implements DataMapperInterface
{
    const MAPPING_KEY_TABLE = 'table';
    const MAPPING_KEY_IDENTIFIER = 'identifier';
    const MAPPING_KEY_LENGTH = 'length';
    const MAPPING_KEY_COLUMN = 'column';
    const MAPPING_KEY_FIELDS = 'fields';
    const MAPPING_KEY_TYPE = 'type';
    const MAPPING_KEY_NULLABLE = 'nullable';
    const MAPPING_KEY_DISCRIMINATOR = 'discriminator';

    const RELATION_ONE_TO_ONE = 'oneToOne';
    const RELATION_ONE_TO_MANY = 'oneToMany';
    const RELATION_MANY_TO_ONE = 'manyToOne';
    const RELATION_MANY_TO_MANY = 'manyToMany';

    const RELATION_KEY_TARGET_ENTITY = 'targetEntity';
    const RELATION_KEY_JOIN_COLUMN = 'joinColumn';
    const RELATION_KEY_JOIN_COLUMN_NAME = 'name';
    const RELATION_KEY_JOIN_COLUMN_REFERENCED_COLUMN_NAME = 'referencedColumnName';
    const RELATION_KEY_JOIN_TABLE = 'joinTable';
    const RELATION_KEY_INVERSE_JOIN_COLUMN = 'inverseJoinColumn';

    const REFERENCES_KEY = 'references';
    const WHERE_KEY = 'where';
    const REMOVE_REFERENCED_KEY = 'removeReferenced';
    const FIXED_VALUE = 'value';

    /**
     * @var array
     */
    protected $mapping;

    /**
     * @param array $mapping
     */
    public function __construct(array $mapping)
    {
        $this->mapping = $mapping;
    }

    /**
     * @param string $entity
     *
     * @return array
     */
    public function getFieldsName($entity)
    {
        $fieldsName = array();
        if (isset($this->mapping[$entity][self::MAPPING_KEY_FIELDS])) {
            $fieldsName = array_keys($this->mapping[$entity][self::MAPPING_KEY_FIELDS]);
        }

        return $fieldsName;
    }

    /**
     * @param string $entity
     * @param string $field
     *
     * @return int|null
     */
    public function getFieldMaxLength($entity, $field)
    {
        $maxLength = null;
        $mapping = $this->getFieldMapping($entity, $field);
        if (isset($mapping[self::MAPPING_KEY_LENGTH])) {
            if (!is_numeric($mapping[self::MAPPING_KEY_LENGTH])) {
                throw new InvalidArgumentException(
                    "$entity.$field " .
                    self::MAPPING_KEY_LENGTH .
                    " mapping property must be a numeric value."
                );
            }
            $maxLength = intval($mapping[self::MAPPING_KEY_LENGTH]);
        }

        return $maxLength;
    }

    /**
     * @param string $entity
     * @param string $field
     *
     * @return array
     */
    public function getFieldMapping($entity, $field)
    {
        $mapping = array();
        if (isset($this->mapping[$entity][self::MAPPING_KEY_FIELDS][$field])) {
            $mapping = $this->mapping[$entity][self::MAPPING_KEY_FIELDS][$field];
        }

        return $mapping;
    }

    /**
     * @param string $entity
     * @param string $field
     *
     * @return string|null
     */
    public function getFieldType($entity, $field)

    {
        $type = null;
        $mapping = $this->getFieldMapping($entity, $field);
        if (isset($mapping[self::MAPPING_KEY_TYPE])) {
            $type = $mapping[self::MAPPING_KEY_TYPE];
        }

        return $type;
    }

    /**
     * Is the field nullable from mapping (default:true)
     *
     * @param string $entity
     * @param string $field
     *
     * @return bool
     */
    public function isFieldNullable($entity, $field)
    {
        $nullable = true;
        $mapping = $this->getFieldMapping($entity, $field);
        if (isset($mapping[self::MAPPING_KEY_NULLABLE])) {
            $nullable =
                $mapping[self::MAPPING_KEY_NULLABLE] !== false
                && $mapping[self::MAPPING_KEY_NULLABLE] !== 'false';
        }

        return $nullable;
    }

    /**
     * @param string $container
     * @param string $entity
     *
     * @return string|null
     */
    public function getRelation($container, $entity)
    {
        $relations = array(
            self::RELATION_MANY_TO_MANY,
            self::RELATION_MANY_TO_ONE,
            self::RELATION_ONE_TO_ONE,
            self::RELATION_ONE_TO_MANY,
        );

        foreach ($relations as $relation) {
            if (isset($this->mapping[$container][$relation][$entity])) {
                return $relation;
            }
        }

        return null;
    }

    /**
     * @param string $entity
     *
     * @return string|null
     */
    public function getIdentifier($entity)

    {
        $identifier = null;
        if (isset($this->mapping[$entity][self::MAPPING_KEY_IDENTIFIER])) {
            $identifier = $this->mapping[$entity][self::MAPPING_KEY_IDENTIFIER];
        }

        return $identifier;
    }

    /**
     * @param string $container
     * @param string $entity
     * @param string $relation
     *
     * @return string|null
     */
    public function getTargetEntity($container, $entity, $relation)

    {
        $targetEntity = null;
        $infos = $this->getRelationInfos($container, $entity, $relation);
        if (isset($infos[self::RELATION_KEY_TARGET_ENTITY])) {
            $targetEntity = $infos[self::RELATION_KEY_TARGET_ENTITY];
        }

        return $targetEntity;
    }

    /**
     * @param string $container
     * @param string $entity
     * @param string $relation
     *
     * @return array|null
     */
    public function getRelationInfos($container, $entity, $relation)
    {
        $details = null;
        if (isset($this->mapping[$container][$relation][$entity])) {
            $details = $this->mapping[$container][$relation][$entity];
            $details[self::MAPPING_KEY_TABLE] = $this->getTableName($details[self::RELATION_KEY_TARGET_ENTITY]);
        }

        return $details;
    }

    /**
     * @param string $entity
     *
     * @return string|null
     */
    public function getTableName($entity)

    {
        $tableName = null;
        if (isset($this->mapping[$entity][self::MAPPING_KEY_TABLE])) {
            $tableName = $this->mapping[$entity][self::MAPPING_KEY_TABLE];
        }

        return $tableName;
    }

    /**
     * @param string $entity
     *
     * @return string|null
     */
    public function getDiscriminator($entity)

    {
        $discr = null;
        if (isset($this->mapping[$entity][self::MAPPING_KEY_DISCRIMINATOR])) {
            $discr = $this->mapping[$entity][self::MAPPING_KEY_DISCRIMINATOR];
        }

        return $discr;
    }

    /**
     * @param string $container
     * @param string $entity
     * @param string $relation
     *
     * @return string|null
     */
    public function getJoinTable($container, $entity, $relation)

    {
        $joinTable = null;
        $infos = $this->getRelationInfos($container, $entity, $relation);
        if (isset($infos[self::RELATION_KEY_JOIN_TABLE])) {
            $joinTable = $infos[self::RELATION_KEY_JOIN_TABLE];

        }

        return $joinTable;
    }

    /**
     * @param string $relation
     *
     * @return bool
     */
    public function isCollection($relation)
    {
        $collections = array(self::RELATION_ONE_TO_MANY, self::RELATION_MANY_TO_MANY);

        return in_array($relation, $collections);
    }

    /**
     * Get the mapping column => fixed_value for a field
     *
     * @param string $entity
     * @param string $field
     *
     * @return array
     */
    public function getFixedFieldMapping($entity, $field)
    {
        $mapping = array();
        $fixed = $this->getFixedValue($entity, $field);
        if (isset($fixed)) {
            $mapping = array(
                $this->getFieldColumn($entity, $field) => $fixed
            );
        }

        return $mapping;
    }

    /**
     * Get the fixed field value
     *
     * @param string $entity
     * @param string $field
     *
     * @return string
     */
    public function getFixedValue($entity, $field)
    {
        $fixed = null;
        if (isset($this->mapping[$entity][self::MAPPING_KEY_FIELDS][$field][self::FIXED_VALUE])) {
            $fixed = $this->mapping[$entity][self::MAPPING_KEY_FIELDS][$field][self::FIXED_VALUE];
        }

        return $fixed;
    }

    /**
     * @param string $entity
     * @param string $field
     *
     * @return string|null
     */
    public function getFieldColumn($entity, $field)

    {
        $column = $field;
        $mapping = $this->getFieldMapping($entity, $field);
        if (isset($mapping[self::MAPPING_KEY_COLUMN])) {
            $column = $mapping[self::MAPPING_KEY_COLUMN];
        }

        return $column;
    }
}


1			<?php
2			namespace Ajir\RabbitMqSqlBundle\DataMapper;
3
4			use InvalidArgumentException;
5
6			/**
7			* Class DataMapper
8			*
9			* @author Florian Ajir <[email protected]>
10			*/
11			class DataMapper implements DataMapperInterface
12			{
13			const MAPPING_KEY_TABLE = 'table';
14			const MAPPING_KEY_IDENTIFIER = 'identifier';
15			const MAPPING_KEY_LENGTH = 'length';
16			const MAPPING_KEY_COLUMN = 'column';
17			const MAPPING_KEY_FIELDS = 'fields';
18			const MAPPING_KEY_TYPE = 'type';
19			const MAPPING_KEY_NULLABLE = 'nullable';
20			const MAPPING_KEY_DISCRIMINATOR = 'discriminator';
21
22			const RELATION_ONE_TO_ONE = 'oneToOne';
23			const RELATION_ONE_TO_MANY = 'oneToMany';
24			const RELATION_MANY_TO_ONE = 'manyToOne';
25			const RELATION_MANY_TO_MANY = 'manyToMany';
26
27			const RELATION_KEY_TARGET_ENTITY = 'targetEntity';
28			const RELATION_KEY_JOIN_COLUMN = 'joinColumn';
29			const RELATION_KEY_JOIN_COLUMN_NAME = 'name';
30			const RELATION_KEY_JOIN_COLUMN_REFERENCED_COLUMN_NAME = 'referencedColumnName';
31			const RELATION_KEY_JOIN_TABLE = 'joinTable';
32			const RELATION_KEY_INVERSE_JOIN_COLUMN = 'inverseJoinColumn';
33
34			const REFERENCES_KEY = 'references';
35			const WHERE_KEY = 'where';
36			const REMOVE_REFERENCED_KEY = 'removeReferenced';
37			const FIXED_VALUE = 'value';
38
39			/**
40			* @var array
41			*/
42			protected $mapping;
43
44			/**
45			* @param array $mapping
46			*/
47	26		public function __construct(array $mapping)
48			{
49	26		$this->mapping = $mapping;
50	26		}
51
52			/**
53			* @param string $entity
54			*
55			* @return array
56			*/
57	8		public function getFieldsName($entity)
58			{
59	8		$fieldsName = array();
60	8		if (isset($this->mapping[$entity][self::MAPPING_KEY_FIELDS])) {
61	8		$fieldsName = array_keys($this->mapping[$entity][self::MAPPING_KEY_FIELDS]);
62			}
63
64	8		return $fieldsName;
65			}
66
67			/**
68			* @param string $entity
69			* @param string $field
70			*
71			* @return int\|null
72			*/
73	7		public function getFieldMaxLength($entity, $field)
74			{
75	7		$maxLength = null;
76	7		$mapping = $this->getFieldMapping($entity, $field);
77	7		if (isset($mapping[self::MAPPING_KEY_LENGTH])) {
78	6		if (!is_numeric($mapping[self::MAPPING_KEY_LENGTH])) {
79	1		throw new InvalidArgumentException(
80			"$entity.$field " .
81	1		self::MAPPING_KEY_LENGTH .
82	1		" mapping property must be a numeric value."
83			);
84			}
85	5		$maxLength = intval($mapping[self::MAPPING_KEY_LENGTH]);
86			}
87
88	6		return $maxLength;
89			}
90
91			/**
92			* @param string $entity
93			* @param string $field
94			*
95			* @return array
96			*/
97	17		public function getFieldMapping($entity, $field)
98			{
99	17		$mapping = array();
100	17		if (isset($this->mapping[$entity][self::MAPPING_KEY_FIELDS][$field])) {
101	17		$mapping = $this->mapping[$entity][self::MAPPING_KEY_FIELDS][$field];
102			}
103
104	17		return $mapping;
105			}
106
107			/**
108			* @param string $entity
109			* @param string $field
110			*
111			* @return string\|null
112			*/
113	4	View Code Duplication	public function getFieldType($entity, $field)
			0 ignored issues – show Duplication introduced 2016-05-03 20:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
114			{
115	4		$type = null;
116	4		$mapping = $this->getFieldMapping($entity, $field);
117	4		if (isset($mapping[self::MAPPING_KEY_TYPE])) {
118	4		$type = $mapping[self::MAPPING_KEY_TYPE];
119			}
120
121	4		return $type;
122			}
123
124			/**
125			* Is the field nullable from mapping (default:true)
126			*
127			* @param string $entity
128			* @param string $field
129			*
130			* @return bool
131			*/
132	3		public function isFieldNullable($entity, $field)
133			{
134	3		$nullable = true;
135	3		$mapping = $this->getFieldMapping($entity, $field);
136	3		if (isset($mapping[self::MAPPING_KEY_NULLABLE])) {
137			$nullable =
138	3		$mapping[self::MAPPING_KEY_NULLABLE] !== false
139	3		&& $mapping[self::MAPPING_KEY_NULLABLE] !== 'false';
140			}
141
142	3		return $nullable;
143			}
144
145			/**
146			* @param string $container
147			* @param string $entity
148			*
149			* @return string\|null
150			*/
151	4		public function getRelation($container, $entity)
152			{
153			$relations = array(
154	4		self::RELATION_MANY_TO_MANY,
155	4		self::RELATION_MANY_TO_ONE,
156	4		self::RELATION_ONE_TO_ONE,
157	4		self::RELATION_ONE_TO_MANY,
158			);
159
160	4		foreach ($relations as $relation) {
161	4		if (isset($this->mapping[$container][$relation][$entity])) {
162	4		return $relation;
163			}
164			}
165
166	2		return null;
167			}
168
169			/**
170			* @param string $entity
171			*
172			* @return string\|null
173			*/
174	11	View Code Duplication	public function getIdentifier($entity)
			0 ignored issues – show Duplication introduced 2016-05-03 20:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
175			{
176	11		$identifier = null;
177	11		if (isset($this->mapping[$entity][self::MAPPING_KEY_IDENTIFIER])) {
178	8		$identifier = $this->mapping[$entity][self::MAPPING_KEY_IDENTIFIER];
179			}
180
181	11		return $identifier;
182			}
183
184			/**
185			* @param string $container
186			* @param string $entity
187			* @param string $relation
188			*
189			* @return string\|null
190			*/
191	3	View Code Duplication	public function getTargetEntity($container, $entity, $relation)
			0 ignored issues – show Duplication introduced 2016-05-03 20:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
192			{
193	3		$targetEntity = null;
194	3		$infos = $this->getRelationInfos($container, $entity, $relation);
195	3		if (isset($infos[self::RELATION_KEY_TARGET_ENTITY])) {
196	3		$targetEntity = $infos[self::RELATION_KEY_TARGET_ENTITY];
197			}
198
199	3		return $targetEntity;
200			}
201
202			/**
203			* @param string $container
204			* @param string $entity
205			* @param string $relation
206			*
207			* @return array\|null
208			*/
209	5		public function getRelationInfos($container, $entity, $relation)
210			{
211	5		$details = null;
212	5		if (isset($this->mapping[$container][$relation][$entity])) {
213	5		$details = $this->mapping[$container][$relation][$entity];
214	5		$details[self::MAPPING_KEY_TABLE] = $this->getTableName($details[self::RELATION_KEY_TARGET_ENTITY]);
215			}
216
217	5		return $details;
218			}
219
220			/**
221			* @param string $entity
222			*
223			* @return string\|null
224			*/
225	14	View Code Duplication	public function getTableName($entity)
			0 ignored issues – show Duplication introduced 2016-05-03 20:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
226			{
227	14		$tableName = null;
228	14		if (isset($this->mapping[$entity][self::MAPPING_KEY_TABLE])) {
229	12		$tableName = $this->mapping[$entity][self::MAPPING_KEY_TABLE];
230			}
231
232	14		return $tableName;
233			}
234
235			/**
236			* @param string $entity
237			*
238			* @return string\|null
239			*/
240	11	View Code Duplication	public function getDiscriminator($entity)
			0 ignored issues – show Duplication introduced 2016-05-03 20:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
241			{
242	11		$discr = null;
243	11		if (isset($this->mapping[$entity][self::MAPPING_KEY_DISCRIMINATOR])) {
244	2		$discr = $this->mapping[$entity][self::MAPPING_KEY_DISCRIMINATOR];
245			}
246
247	11		return $discr;
248			}
249
250			/**
251			* @param string $container
252			* @param string $entity
253			* @param string $relation
254			*
255			* @return string\|null
256			*/
257	1	View Code Duplication	public function getJoinTable($container, $entity, $relation)
			0 ignored issues – show Duplication introduced 2016-05-03 20:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
258			{
259	1		$joinTable = null;
260	1		$infos = $this->getRelationInfos($container, $entity, $relation);
261	1		if (isset($infos[self::RELATION_KEY_JOIN_TABLE])) {
262	1		$joinTable = $infos[self::RELATION_KEY_JOIN_TABLE];
			0 ignored issues – show Bug Compatibility introduced 2016-05-03 20:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$infos[self::RELATION_KEY_JOIN_TABLE];` of type `string\|null` adds the type `string` to the return on line 265 which is incompatible with the return type declared by the interface `Ajir\RabbitMqSqlBundle\D...Interface::getJoinTable` of type `array`. Loading history...
263			}
264
265	1		return $joinTable;
266			}
267
268			/**
269			* @param string $relation
270			*
271			* @return bool
272			*/
273	3		public function isCollection($relation)
274			{
275	3		$collections = array(self::RELATION_ONE_TO_MANY, self::RELATION_MANY_TO_MANY);
276
277	3		return in_array($relation, $collections);
278			}
279
280			/**
281			* Get the mapping column => fixed_value for a field
282			*
283			* @param string $entity
284			* @param string $field
285			*
286			* @return array
287			*/
288	7		public function getFixedFieldMapping($entity, $field)
289			{
290	7		$mapping = array();
291	7		$fixed = $this->getFixedValue($entity, $field);
292	7		if (isset($fixed)) {
293			$mapping = array(
294	2		$this->getFieldColumn($entity, $field) => $fixed
295			);
296			}
297
298	7		return $mapping;
299			}
300
301			/**
302			* Get the fixed field value
303			*
304			* @param string $entity
305			* @param string $field
306			*
307			* @return string
308			*/
309	7		public function getFixedValue($entity, $field)
310			{
311	7		$fixed = null;
312	7		if (isset($this->mapping[$entity][self::MAPPING_KEY_FIELDS][$field][self::FIXED_VALUE])) {
313	2		$fixed = $this->mapping[$entity][self::MAPPING_KEY_FIELDS][$field][self::FIXED_VALUE];
314			}
315
316	7		return $fixed;
317			}
318
319			/**
320			* @param string $entity
321			* @param string $field
322			*
323			* @return string\|null
324			*/
325	10	View Code Duplication	public function getFieldColumn($entity, $field)
			0 ignored issues – show Duplication introduced 2016-05-03 20:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
326			{
327	10		$column = $field;
328	10		$mapping = $this->getFieldMapping($entity, $field);
329	10		if (isset($mapping[self::MAPPING_KEY_COLUMN])) {
330	10		$column = $mapping[self::MAPPING_KEY_COLUMN];
331			}
332
333	10		return $column;
334			}
335			}
336

florianajir / rabbitmq-sql-worker

Issues (73)

Security Analysis no request data

DataMapper/DataMapper.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like