Downloader::download() - Code Metrics - Inspection of "add tests + refactoring" - florianajir/datanova-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 64470f...3a69fd )

by Florian

created 2016-03-10 00:21 UTC

Downloader::download() A

↳ Parent: Downloader

Complexity

Conditions	3
Paths	4

Size

Total Lines	19
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	0
loc	19
ccs	0
cts	18
cp	0
rs	9.4285
cc	3
eloc	13
nc	4
nop	4
crap	12

<?php

namespace Laposte\DatanovaBundle\Service;

use Laposte\DatanovaBundle\Client\ClientInterface;

class Downloader
{
    /** @var ClientInterface $client */
    private $client;

    /** @var  Finder $finder */
    private $finder;

    /**
     * @param ClientInterface $client
     * @param Finder $finder
     */
    public function __construct(ClientInterface $client, Finder $finder)
    {
        $this->client = $client;
        $this->finder = $finder;
    }

    /**
     * @param string $dataset
     * @param string $format
     * @param string $filter
     * @param bool $updateExisting
     *
     * @return false|string downloaded file content
     */
    public function download($dataset, $format, $filter = null, $updateExisting = false)
    {
        $result = false;
        $parameters = array(
            'dataset' => $dataset,
            'format' => $format
        );
        if (isset($filter)) {
            $parameters['q'] = $filter;
        }
        $this->client->setTimeout(0);
        $content = $this->client->get('download', $parameters);
        $save = $this->finder->save($dataset, $content, $format, $filter, $updateExisting);
        if ($save) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $result = $this->finder->getContent($save);
        }

        return $result;
    }

    /**
     * @param string $dataset
     * @param string $format
     * @param string $filter
     * @return false|string
     */
    public function findDownload($dataset, $format, $filter = null)
    {
        return $this->finder->findDataset($dataset, $format, $filter);
    }
}


1			<?php
2
3			namespace Laposte\DatanovaBundle\Service;
4
5			use Laposte\DatanovaBundle\Client\ClientInterface;
6
7			class Downloader
8			{
9			/** @var ClientInterface $client */
10			private $client;
11
12			/** @var Finder $finder */
13			private $finder;
14
15			/**
16			* @param ClientInterface $client
17			* @param Finder $finder
18			*/
19			public function __construct(ClientInterface $client, Finder $finder)
20			{
21			$this->client = $client;
22			$this->finder = $finder;
23			}
24
25			/**
26			* @param string $dataset
27			* @param string $format
28			* @param string $filter
29			* @param bool $updateExisting
30			*
31			* @return false\|string downloaded file content
32			*/
33			public function download($dataset, $format, $filter = null, $updateExisting = false)
34			{
35			$result = false;
36			$parameters = array(
37			'dataset' => $dataset,
38			'format' => $format
39			);
40			if (isset($filter)) {
41			$parameters['q'] = $filter;
42			}
43			$this->client->setTimeout(0);
44			$content = $this->client->get('download', $parameters);
45			$save = $this->finder->save($dataset, $content, $format, $filter, $updateExisting);
46			if ($save) {
			0 ignored issues – show Bug Best Practice introduced 2016-03-09 21:37 UTC by Report Bug Copy Issue Report The expression `$save` of type `false\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== false` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
47			$result = $this->finder->getContent($save);
48			}
49
50			return $result;
51			}
52
53			/**
54			* @param string $dataset
55			* @param string $format
56			* @param string $filter
57			* @return false\|string
58			*/
59			public function findDownload($dataset, $format, $filter = null)
60			{
61			return $this->finder->findDataset($dataset, $format, $filter);
62			}
63			}
64

florianajir / datanova-bundle

Push — master ( 64470f...3a69fd )

Downloader::download() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like