Laposte\DatanovaBundle\Command\DownloadDatasetCommand

Complexity

Total Complexity

6

Size/Duplication

Total Lines	78
Duplicated Lines	58.97 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	1	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
B	configure()	28	28	1
B	execute()	18	31	4

<?php
namespace Laposte\DatanovaBundle\Command;

use Laposte\DatanovaBundle\Service\Downloader;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * @author Florian Ajir <florianajir@gmail.com>
 */
class DownloadDatasetCommand extends Command
{
    /** @var Downloader $downloader */
    private $downloader;

    /**
     * @param Downloader $downloader
     */
    public function __construct(Downloader $downloader)
    {
        $this->downloader = $downloader;
        parent::__construct();
    }

    protected function configure()

This method seems to be duplicated in your project.

    {
        $this
            ->setName('datanova:download:dataset')
            ->setDescription('Download dataset records to use it locally')
            ->addArgument(
                'dataset',
                InputArgument::REQUIRED,
                'Which dataset to download?'
            )
            ->addArgument(
                'format',
                InputArgument::OPTIONAL,
                'Data file format : CSV (default), JSON',
                'CSV'
            )
            ->addArgument(
                'q',
                InputArgument::OPTIONAL,
                'query filter, by default all results will be download'
            )
            ->addOption(
                'force-replace',
                'f',
                InputOption::VALUE_NONE,
                'If set, the command will replace local storage'
            );
    }

    /**
     * {@inheritdoc}
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $dataset = $input->getArgument('dataset');
        $format = strtolower($input->getArgument('format'));
        $query = $input->getArgument('q');
        $download = $this->downloader->download(
            $dataset,
            $format,
            $input->getArgument('q'),
            $input->getOption('force-replace')
        );
        $filepath = $this->downloader->findDownload($dataset, $format, $query);
        if ($download) {

This code seems to be duplicated across your project.

            $output->writeln(sprintf(
                'Dataset %s downloaded to "%s" : %d bytes',
                $dataset,
                $filepath,
                filesize($filepath)
            ));
        } else {
            if (false !== $filepath) {
                if (false === $input->getOption('force-replace')) {
                    $output->writeln('Existing dataset. To overwrite it, try with --force-replace option');
                } else {
                    $output->writeln('Error during update of existing dataset.');
                }
            } else {
                $output->writeln('Error during dataset download.');
            }
        }
    }
}