JsonParser::getFieldsFromContent() - Code Metrics - Inspection of "add parser tests + refact" - florianajir/datanova-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3a69fd...c72125 )

by Florian

created 2016-03-10 01:45 UTC

JsonParser::getFieldsFromContent() A

↳ Parent: JsonParser

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	10
ccs	7
cts	7
cp	1
rs	9.4285
cc	2
eloc	6
nc	2
nop	1
crap	2

<?php

namespace Laposte\DatanovaBundle\Parser;

use Laposte\DatanovaBundle\Service\Finder;

class JsonParser implements ParserInterface
{
    /** File format */
    const FORMAT = 'json';

    /**
     * @var Finder
     */
    private $finder;

    /**
     * @param Finder $finder
     */
    public function __construct(Finder $finder)
    {
        $this->finder = $finder;
    }

    /**
     * @param string $dataset
     *
     * @return false|array
     */
    public function parse($dataset)
    {
        $data = false;
        $path = $this->finder->findDataset($dataset, self::FORMAT);
        if (false !== $path) {
            $content = $this->finder->getContent($path);
            if (null !== $content) {
                $data = $this->getFieldsFromContent($content);
            }
        }

        return $data;
    }

    /**
     * @param string $content json content
     *
     * @return array
     */
    private function getFieldsFromContent($content)
    {
        $data = array();
        $content = json_decode($content, true);
        foreach ($content as $record) {
            $data[] = $record['fields'];
        }

        return $data;
    }
}


1		<?php
2
3		namespace Laposte\DatanovaBundle\Parser;
4
5		use Laposte\DatanovaBundle\Service\Finder;
6
7		class JsonParser implements ParserInterface
8		{
9		/** File format */
10		const FORMAT = 'json';
11
12		/**
13		* @var Finder
14		*/
15		private $finder;
16
17		/**
18		* @param Finder $finder
19		*/
20	1	public function __construct(Finder $finder)
21		{
22	1	$this->finder = $finder;
23	1	}
24
25		/**
26		* @param string $dataset
27		*
28		* @return false\|array
29		*/
30	1	public function parse($dataset)
31		{
32	1	$data = false;
33	1	$path = $this->finder->findDataset($dataset, self::FORMAT);
34	1	if (false !== $path) {
35	1	$content = $this->finder->getContent($path);
36	1	if (null !== $content) {
37	1	$data = $this->getFieldsFromContent($content);
38	1	}
39	1	}
40
41	1	return $data;
42		}
43
44		/**
45		* @param string $content json content
46		*
47		* @return array
48		*/
49	1	private function getFieldsFromContent($content)
50		{
51	1	$data = array();
52	1	$content = json_decode($content, true);
53	1	foreach ($content as $record) {
54	1	$data[] = $record['fields'];
55	1	}
56
57	1	return $data;
58		}
59		}
60

florianajir / datanova-bundle

Push — master ( 3a69fd...c72125 )

JsonParser::getFieldsFromContent() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like