Laposte\DatanovaBundle\Tests\Model\CsvParserTest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	2
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	testParseCsvFixture()	0	21	1
A	getFinderMock()	0	12	1

<?php

namespace Fmaj\LaposteDatanovaBundle\Tests\Model;

use Fmaj\LaposteDatanovaBundle\Parser\CsvParser;

class CsvParserTest extends \PHPUnit_Framework_TestCase
{
    public function testParseCsvFixture()
    {
        $dataset = 'laposte_hexasmal';
        $finder = $this->getFinderMock($dataset, dirname(__FILE__) . '/Fixtures/laposte_hexasmal.csv');

        $csvParser = new CsvParser($finder);

It seems like $finder defined by $this->getFinderMock($dataset, dirname(__FILE__) . '/Fixtures/laposte_hexasmal.csv') on line 12 can also be of type object<PHPUnit_Framework_MockObject_MockObject>; however, Fmaj\LaposteDatanovaBundle\Parser\CsvParser::__construct() does only seem to accept object<Fmaj\LaposteDatanovaBundle\Service\Finder>, maybe add an additional type check?

        $result = $csvParser->parse($dataset);

        $this->assertNotFalse($result);
        $this->assertCount(15, $result);
        $this->assertArrayHasKey('code_commune_insee', $result[0]);
        $this->assertArrayHasKey('nom_commune', $result[0]);
        $this->assertArrayHasKey('code_postal', $result[0]);
        $this->assertArrayHasKey('libelle_acheminement', $result[0]);
        $this->assertArrayHasKey('ligne_5', $result[0]);
        $this->assertEquals('57077', $result[0]['code_commune_insee']);
        $this->assertEquals('BEZANGE LA PETITE', $result[0]['nom_commune']);
        $this->assertEquals('57630', $result[0]['code_postal']);
        $this->assertEquals('BEZANGE LA PETITE', $result[0]['libelle_acheminement']);
        $this->assertEquals('', $result[0]['ligne_5']);
    }

    /**
     * @param string $dataset
     * @param string $path
     *
     * @return \PHPUnit_Framework_MockObject_MockObject|\Fmaj\LaposteDatanovaBundle\Service\Finder
     */
    private function getFinderMock($dataset, $path)
    {
        $mock = $this->getMockBuilder('Fmaj\LaposteDatanovaBundle\Service\Finder')
            ->disableOriginalConstructor()
            ->getMock();
        $mock->expects($this->once())
            ->method('findDataset')
            ->with($dataset, CsvParser::FORMAT)
            ->willReturn($path);

        return $mock;
    }
}