Fmaj\LaposteDatanovaBundle\Tests\Model\JsonParserTest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	testParseJsonFixture()	0	20	1
A	getFinderMock()	0	17	1

<?php

namespace Fmaj\LaposteDatanovaBundle\Tests\Model;

use Fmaj\LaposteDatanovaBundle\Parser\JsonParser;

class JsonParserTest extends \PHPUnit_Framework_TestCase
{
    public function testParseJsonFixture()
    {
        $dataset = 'laposte_hexasmal';
        $path = dirname(__FILE__) . '/Fixtures/laposte_hexasmal.json';
        $finder = $this->getFinderMock($dataset, $path);

        $jsonParser = new JsonParser($finder);

It seems like $finder defined by $this->getFinderMock($dataset, $path) on line 13 can also be of type object<PHPUnit_Framework_MockObject_MockObject>; however, Fmaj\LaposteDatanovaBundle\Parser\JsonParser::__construct() does only seem to accept object<Fmaj\LaposteDatanovaBundle\Service\Finder>, maybe add an additional type check?

        $result = $jsonParser->parse($dataset);

        $this->assertNotFalse($result);
        $this->assertCount(15, $result);
        $this->assertArrayHasKey('code_commune_insee', $result[0]);
        $this->assertArrayHasKey('nom_de_la_commune', $result[0]);
        $this->assertArrayHasKey('code_postal', $result[0]);
        $this->assertArrayHasKey('libell_d_acheminement', $result[0]);
        $this->assertEquals('57077', $result[0]['code_commune_insee']);
        $this->assertEquals('BEZANGE LA PETITE', $result[0]['nom_de_la_commune']);
        $this->assertEquals('57630', $result[0]['code_postal']);
        $this->assertEquals('BEZANGE LA PETITE', $result[0]['libell_d_acheminement']);
    }

    /**
     * @param string $dataset
     * @param string $path
     *
     * @return \PHPUnit_Framework_MockObject_MockObject|\Fmaj\LaposteDatanovaBundle\Service\Finder
     */
    private function getFinderMock($dataset, $path)
    {
        $finder = $this->getMockBuilder('Fmaj\LaposteDatanovaBundle\Service\Finder')
            ->disableOriginalConstructor()
            ->getMock();

        $finder->expects($this->once())
            ->method('findDataset')
            ->with($dataset, JsonParser::FORMAT)
            ->willReturn($path);
        $finder->expects($this->once())
            ->method('getContent')
            ->with($path)
            ->willReturn(file_get_contents($path));

        return $finder;
    }
}