View GitHub Repository yii2-phone

Schedule Inspection
Subscribe

src/assets/validator.phone.js   A
last analyzed

↳ Parent: Project

Complexity

Total Complexity 8
Complexity/F 2

Size

Lines of Code 31
Function Count 4

Duplication

Duplicated Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
wmc 8
eloc 20
c 0
b 0
f 0
dl 0
loc 31
rs 10
mnd 4
bc 4
fnc 4
bpm 1
cpm 2
noi 6
1 
const f12phone = {
0 ignored issues
– show
Unused Code introduced by
The constant f12phone seems to be never used. Consider removing it.
Loading history...
2 
    validatePhone(value, messages, options) {
0 ignored issues
– show
Unused Code introduced by
The parameter options is not used and could be removed.

This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function.

Loading history...
3 
        value = value.replace(/_|-| |\(|\)|\+/g, '');
4 
        if (this.isEmpty(value)) {
5 
            return;
6 
        }
7 
        if (!this.isNumeric(value)) {
8 
            this.addMessage(messages, f12_phone_error_format, value);
0 ignored issues
– show
Bug introduced by
The variable f12_phone_error_format seems to be never declared. If this is a global, consider adding a /** global: f12_phone_error_format */ comment.

This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed.

To learn more about declaring variables in Javascript, see the MDN.

Loading history...
9 
            return;
10 
        }
11 
        value = value.replace(/\D/g, '');
12 
        if (value.length > 15 || value.length < 11)
13 
            this.addMessage(messages, f12_phone_error_length, value);
0 ignored issues
– show
Coding Style Best Practice introduced by
Curly braces around statements make for more readable code and help prevent bugs when you add further statements.

Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later.

Consider:

if (a > 0)
    b = 42;

If you or someone else later decides to put another statement in, only the first statement will be executed.

if (a > 0)
    console.log("a > 0");
    b = 42;

In this case the statement b = 42 will always be executed, while the logging statement will be executed conditionally.

if (a > 0) {
    console.log("a > 0");
    b = 42;
}

ensures that the proper code will be executed conditionally no matter how many statements are added or removed.

Loading history...
Bug introduced by
The variable f12_phone_error_length seems to be never declared. If this is a global, consider adding a /** global: f12_phone_error_length */ comment.

This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed.

To learn more about declaring variables in Javascript, see the MDN.

Loading history...
14 
    },
15 
    addMessage(messages, message, value) {
16 
        messages.push(message.replace(/\{value\}/g, value));
17 
    },
18 
    isEmpty(value, trim) {
19 
        return value === null || value === undefined || value == []
20 
            || value === '' || trim && $.trim(value) === '';
21 
    },
22 

            


            
                                                                        
                            
            
                                    
            
            

                
                    23
                

                                    
                                                    
                
                
                
    isNumeric(str) {

            


            
                                                                        
                            
            
                                    
            
            

                
                    24
                

                                    
                                                    
                
                
                
        /**

            


            
                                                                        
                            
            
                                    
            
            

                
                    25
                

                                    
                                                    
                
                
                
         * https://stackoverflow.com/questions/175739/how-can-i-check-if-a-string-is-a-valid-number

            


            
                                                                        
                            
            
                                    
            
            

                
                    26
                

                                    
                                                    
                
                
                
         */

            


            
                                                                        
                            
            
                                    
            
            

                
                    27
                

                                    
                                                    
                
                
                
        if (typeof str != "string") return false // we only process strings!

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Coding Style
            Best Practice
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
Curly braces around statements make for more readable code and help prevent bugs when you add further statements.
                                            

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
Consider adding curly braces around all statements when they are executed conditionally.
This is optional if there is only one statement, but leaving them out can lead to unexpected
behaviour if another statement is added later.


Consider:


if (a > 0)
    b = 42;





If you or someone else later decides to put another statement in, only the first
statement will be executed.


if (a > 0)
    console.log("a > 0");
    b = 42;





In this case the statement b = 42 will always be executed, while
the logging statement will be executed conditionally.


if (a > 0) {
    console.log("a > 0");
    b = 42;
}





ensures that the proper code will be executed conditionally no matter how
many statements are added or removed.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                                        
                            
            
                                    
            
            

                
                    28
                

                                    
                                                    
                
                
                
        return !isNaN(str) && // use type coercion to parse the _entirety_ of the string (`parseFloat` alone does not do this)...

            


            
                                                                        
                            
            
                                    
            
            

                
                    29
                

                                    
                                                    
                
                
                
            !isNaN(parseFloat(str)) // ...and ensure strings of whitespace fail

            


            
                                                                        
                            
            
                                    
            
            

                
                    30
                

                                    
                                                    
                
                
                
    }

            


            
                                                                        
                            
            
                                    
            
            

                
                    31
                

                                    
                                                    
                
                
                
}

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    32
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    33
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    34