floor12 / yii2-module-files

src/logic/FileCreateFromPath.php

<?php
/**
 * Created by PhpStorm.
 * User: floor12
 * Date: 07.01.2018
 * Time: 8:43
 */

namespace floor12\files\logic;


use floor12\files\components\SimpleImage;
use floor12\files\models\FileType;
use yii\base\ErrorException;
use yii\db\ActiveRecordInterface;

class FileCreateFromPath
{

    private $className;
    private $fieldName;
    private $filePath;
    private $fileName;
    private $storagePath;
    private $model;

    public function __construct(ActiveRecordInterface $model, string $filePath, string $className, string $fieldName, string $storagePath, string $fileName = null)
    {

        $this->model = $model;

        if (!$filePath || !$className || !$fieldName || !$storagePath)
            throw new ErrorException("Empty params not allowed.");

        if (!file_exists($storagePath))
            throw new ErrorException("File storage not found on disk.");

        if (!file_exists($filePath))
            throw new ErrorException("File not found on disk.");

        if (!is_writable($storagePath))
            throw new ErrorException("File storage is not writable.");
        $this->filePath = $filePath;
        $this->fileName = $fileName;
        $this->fieldName = $fieldName;
        $this->className = $className;
        $this->storagePath = $storagePath;

    }

    /** Основная  работка
     * @return bool
     * @throws ErrorException
     */
    public function execute()
    {
        // копируем файл в хранилище
        $tmp_extansion = explode('?', pathinfo($this->filePath, PATHINFO_EXTENSION));

It seems like pathinfo($this->filePath, floor12\files\logic\PATHINFO_EXTENSION) can also be of type array; however, parameter $string of explode() does only seem to accept string, maybe add an additional type check?

        $extansion = $tmp_extansion[0];
        $filename = new PathGenerator($this->storagePath) . "." . $extansion;
        $new_path = $this->storagePath . $filename;
        copy($this->filePath, $new_path);

        // создаем запись в базе
        $this->model->field = $this->fieldName;

Accessing field on the interface yii\db\ActiveRecordInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->model->class = $this->className;

Accessing class on the interface yii\db\ActiveRecordInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->model->filename = $filename;

Accessing filename on the interface yii\db\ActiveRecordInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        if ($this->model->filename)
            $this->model->title = $this->model->filename;

Accessing title on the interface yii\db\ActiveRecordInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        else
            $this->model->title = rand(0, 99999); #такой прикол )
        $this->model->content_type = $this->model->mime_content_type($new_path);

Accessing content_type on the interface yii\db\ActiveRecordInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->model->type = $this->detectType();

Accessing type on the interface yii\db\ActiveRecordInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->model->size = filesize($new_path);

Accessing size on the interface yii\db\ActiveRecordInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->model->created = time();

Accessing created on the interface yii\db\ActiveRecordInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        if ($this->model->type == FileType::VIDEO)
            $this->model->video_status = 0;

Accessing video_status on the interface yii\db\ActiveRecordInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        if ($this->model->save()) {

            if ($this->model->type == FileType::IMAGE) {
                $exif = '';

The assignment to $exif is dead and can be removed.

                @$exif = exif_read_data($new_path);
                if (isset($exif['Orientation'])) {
                    $ort = $exif['Orientation'];
                    $rotatingImage = new SimpleImage();
                    $rotatingImage->load($new_path);
                    switch ($ort) {

                        case 3: // 180 rotate left
                            $rotatingImage->rotateDegrees(180);
                            break;
                        case 6: // 90 rotate right
                            $rotatingImage->rotateDegrees(270);
                            break;
                        case 8:    // 90 rotate left
                            $rotatingImage->rotateDegrees(90);
                    }
                    $rotatingImage->save($new_path);
                }
            }
            return true;
        }
        return false;
    }

    /**
     * @return integer
     */
    private function detectType()
    {
        $contentTypeArray = explode('/', $this->model->content_type);

Accessing content_type on the interface yii\db\ActiveRecordInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        if ($contentTypeArray[0] == 'image')
            return FileType::IMAGE;
        if ($contentTypeArray[0] == 'video')
            return FileType::VIDEO;
        return FileType::FILE;
    }
}