floor12 / yii2-module-backup

tests/unit/FolderBackupMakerTest.php

<?php
/**
 * Created by PhpStorm.
 * User: floor12
 * Date: 11.11.2019
 * Time: 07:45
 */

namespace floor12\backup\tests\unit;

/**
 * This is a tests for Backup class
 */

use floor12\backup\logic\FolderBackupMaker;
use floor12\backup\tests\TestCase;
use Yii;
use yii\base\Exception;

class FolderBackupMakerTest extends TestCase
{
    public function testCreateBackupFileExists()
    {
        $this->expectException(Exception::class);
        $backupFilePath = Yii::getAlias('@app/data/sqlite.db');
        $creator = new FolderBackupMaker($backupFilePath, 'tmp');

The assignment to $creator is dead and can be removed.

It seems like $backupFilePath can also be of type false; however, parameter $backupFilePath of floor12\backup\logic\FolderBackupMaker::__construct() does only seem to accept string, maybe add an additional type check?

    }

    public function testCreateBackupTargetNotExists()
    {
        $this->expectException(Exception::class);
        $backupFilePath = Yii::getAlias('@app/data/backup.tgz');
        $creator = new FolderBackupMaker($backupFilePath, 'not-exists');

The assignment to $creator is dead and can be removed.

It seems like $backupFilePath can also be of type false; however, parameter $backupFilePath of floor12\backup\logic\FolderBackupMaker::__construct() does only seem to accept string, maybe add an additional type check?

    }


    public function testCreateBackupSuccess()
    {
        $backupFilePath = Yii::getAlias('@app/data/backup.tgz');
        $targetFolder = Yii::getAlias('@app/unit');
        $creator = new FolderBackupMaker($backupFilePath, $targetFolder);

It seems like $backupFilePath can also be of type false; however, parameter $backupFilePath of floor12\backup\logic\FolderBackupMaker::__construct() does only seem to accept string, maybe add an additional type check?

It seems like $targetFolder can also be of type false; however, parameter $targetFolder of floor12\backup\logic\FolderBackupMaker::__construct() does only seem to accept string, maybe add an additional type check?

        $this->assertTrue($creator->execute());
        $this->fileExists($backupFilePath);

The call to PHPUnit\Framework\Assert::fileExists() has too many arguments starting with $backupFilePath.

        unlink($backupFilePath);

It seems like $backupFilePath can also be of type false; however, parameter $filename of unlink() does only seem to accept string, maybe add an additional type check?

    }

    public function testCreateBackupSuccessWithIoNice()
    {
        $backupFilePath = Yii::getAlias('@app/data/backup.tgz');
        $targetFolder = Yii::getAlias('@app/data/folder_for_backup');

        $this->assertFileNotExists($backupFilePath);

It seems like $backupFilePath can also be of type false; however, parameter $filename of PHPUnit\Framework\Assert::assertFileNotExists() does only seem to accept string, maybe add an additional type check?

        $creator = new FolderBackupMaker($backupFilePath, $targetFolder);

It seems like $targetFolder can also be of type false; however, parameter $targetFolder of floor12\backup\logic\FolderBackupMaker::__construct() does only seem to accept string, maybe add an additional type check?

It seems like $backupFilePath can also be of type false; however, parameter $backupFilePath of floor12\backup\logic\FolderBackupMaker::__construct() does only seem to accept string, maybe add an additional type check?

        $this->assertTrue($creator->execute());
        $this->assertFileExists($backupFilePath);

It seems like $backupFilePath can also be of type false; however, parameter $filename of PHPUnit\Framework\Assert::assertFileExists() does only seem to accept string, maybe add an additional type check?

        unlink($backupFilePath);

It seems like $backupFilePath can also be of type false; however, parameter $filename of unlink() does only seem to accept string, maybe add an additional type check?

    }

    public function testCreateBackupSuccessWithChmod()
    {
        $backupFilePath = Yii::getAlias('@app/data/backup.tgz');
        $targetFolder = Yii::getAlias('@app/data/folder_for_backup');
        Yii::$app->getModule('backup')->chmod = 0700;
        $this->assertFileNotExists($backupFilePath);

It seems like $backupFilePath can also be of type false; however, parameter $filename of PHPUnit\Framework\Assert::assertFileNotExists() does only seem to accept string, maybe add an additional type check?

        $creator = new FolderBackupMaker($backupFilePath, $targetFolder);

It seems like $backupFilePath can also be of type false; however, parameter $backupFilePath of floor12\backup\logic\FolderBackupMaker::__construct() does only seem to accept string, maybe add an additional type check?

It seems like $targetFolder can also be of type false; however, parameter $targetFolder of floor12\backup\logic\FolderBackupMaker::__construct() does only seem to accept string, maybe add an additional type check?

        $this->assertTrue($creator->execute());
        $this->assertFileExists($backupFilePath);

It seems like $backupFilePath can also be of type false; however, parameter $filename of PHPUnit\Framework\Assert::assertFileExists() does only seem to accept string, maybe add an additional type check?

        $this->assertEquals('0700', $this->readPerms($backupFilePath));

It seems like $backupFilePath can also be of type false; however, parameter $file of floor12\backup\tests\unit\FolderBackupMakerTest::readPerms() does only seem to accept string, maybe add an additional type check?

        @unlink($backupFilePath);

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

It seems like $backupFilePath can also be of type false; however, parameter $filename of unlink() does only seem to accept string, maybe add an additional type check?

    }

    protected function readPerms(string $file)
    {
        return substr(sprintf('%o', fileperms($file)), -4);
    }


}