floor12 / yii2-module-backup

tests/unit/DatabaseBackuperTest.php

<?php
/**
 * Created by PhpStorm.
 * User: floor12
 * Date: 11.11.2019
 * Time: 07:45
 */

namespace floor12\backup\tests\unit;

/**
 * This is a tests for Backup class
 */

use floor12\backup\logic\DatabaseBackuper;
use floor12\backup\tests\TestCase;
use Yii;
use yii\base\Exception;
use yii\db\Connection;

class DatabaseBackuperTest extends TestCase
{

    public function testBackupFileExists()
    {
        $this->expectException(Exception::class);
        $backupFilePath = Yii::getAlias('@app/_output/sqlite.db'); // Just existing file
        $connection = Yii::$app->mysql;
        new DatabaseBackuper($backupFilePath, $connection);

It seems like $connection can also be of type null; however, parameter $connection of floor12\backup\logic\DatabaseBackuper::__construct() does only seem to accept yii\db\Connection, maybe add an additional type check?

It seems like $backupFilePath can also be of type false; however, parameter $backupFilePath of floor12\backup\logic\DatabaseBackuper::__construct() does only seem to accept string, maybe add an additional type check?

        $backuper = new DatabaseBackuper($backupFilePath, $connection);
        $backuper->backup();
    }

//    public function testCreateMysqlBackup()
//    {
//        $backupFilePath = Yii::getAlias('@app/data/mysql.tar');
//        $connection = Yii::$app->mysql;
//        $backuper = new DatabaseBackuper($backupFilePath, $connection);
//        $backuper->backup();
//        $this->assertFileExists($backupFilePath);
//    }

    public function testCreatePostgresBackup()
    {
        $backupFilePath = Yii::getAlias('@app/_output/postgres');
        $connection = Yii::$app->postgres;
        $backuper = new DatabaseBackuper($backupFilePath, $connection);

It seems like $connection can also be of type null; however, parameter $connection of floor12\backup\logic\DatabaseBackuper::__construct() does only seem to accept yii\db\Connection, maybe add an additional type check?

It seems like $backupFilePath can also be of type false; however, parameter $backupFilePath of floor12\backup\logic\DatabaseBackuper::__construct() does only seem to accept string, maybe add an additional type check?

        $backuper->backup();
        $this->assertFileExists($backupFilePath);

It seems like $backupFilePath can also be of type false; however, parameter $filename of PHPUnit\Framework\Assert::assertFileExists() does only seem to accept string, maybe add an additional type check?

        @unlink($backupFilePath);

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

It seems like $backupFilePath can also be of type false; however, parameter $filename of unlink() does only seem to accept string, maybe add an additional type check?

    }

    public function testRestorePostgresBackupEmptyBase()
    {
        $backupFilePath = Yii::getAlias('@app/data/postgres');
        /** @var $connection Connection */
        $connection = Yii::$app->postgres;
        $this->assertFalse($this->deleteTableSuccess('test_table', $connection));
        $backuper = new DatabaseBackuper($backupFilePath, $connection);

It seems like $backupFilePath can also be of type false; however, parameter $backupFilePath of floor12\backup\logic\DatabaseBackuper::__construct() does only seem to accept string, maybe add an additional type check?

        $backuper->restore();
        $this->assertTrue($this->deleteTableSuccess('test_table', $connection));
    }

    public function testRestorePostgresBackupNotEmptyBase()
    {
        $backupFilePath = Yii::getAlias('@app/data/postgres');
        /** @var $connection Connection */
        $connection = Yii::$app->postgres;
        $connection->createCommand()->createTable('test_table', ['id' => 'int null'])->execute();
        $backuper = new DatabaseBackuper($backupFilePath, $connection);

It seems like $backupFilePath can also be of type false; however, parameter $backupFilePath of floor12\backup\logic\DatabaseBackuper::__construct() does only seem to accept string, maybe add an additional type check?

        $backuper->restore();
        $this->assertTrue($this->deleteTableSuccess('test_table', $connection));
    }

    public function testCreateMysqlBackup()
    {
        $backupFilePath = Yii::getAlias('@app/_output/mysql.sql.tgz');
        $connection = Yii::$app->mysql;
        $backuper = new DatabaseBackuper($backupFilePath, $connection);

It seems like $connection can also be of type null; however, parameter $connection of floor12\backup\logic\DatabaseBackuper::__construct() does only seem to accept yii\db\Connection, maybe add an additional type check?

It seems like $backupFilePath can also be of type false; however, parameter $backupFilePath of floor12\backup\logic\DatabaseBackuper::__construct() does only seem to accept string, maybe add an additional type check?

        $backuper->backup();
        $this->assertFileExists($backupFilePath);

It seems like $backupFilePath can also be of type false; however, parameter $filename of PHPUnit\Framework\Assert::assertFileExists() does only seem to accept string, maybe add an additional type check?

        @unlink($backupFilePath);

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

It seems like $backupFilePath can also be of type false; however, parameter $filename of unlink() does only seem to accept string, maybe add an additional type check?

    }

    public function testRestoreMysqlBackupEmptyBase()
    {
        $backupFilePath = Yii::getAlias('@app/data/mysql.sql.tgz');
        /** @var $connection Connection */
        $connection = Yii::$app->mysql;
        $this->assertFalse($this->deleteTableSuccess('test_table', $connection));
        $backuper = new DatabaseBackuper($backupFilePath, $connection);

It seems like $backupFilePath can also be of type false; however, parameter $backupFilePath of floor12\backup\logic\DatabaseBackuper::__construct() does only seem to accept string, maybe add an additional type check?

        $backuper->restore();
        $this->assertTrue($this->deleteTableSuccess('test_table', $connection));
    }

    public function testRestoreMysqlBackupNotEmptyBase()
    {
        $backupFilePath = Yii::getAlias('@app/data/mysql.sql.tgz');
        /** @var $connection Connection */
        $connection = Yii::$app->mysql;
        $connection->createCommand()->createTable('test_table', ['id' => 'int null'])->execute();
        $backuper = new DatabaseBackuper($backupFilePath, $connection);

It seems like $backupFilePath can also be of type false; however, parameter $backupFilePath of floor12\backup\logic\DatabaseBackuper::__construct() does only seem to accept string, maybe add an additional type check?

        $backuper->restore();
        $this->assertTrue($this->deleteTableSuccess('test_table', $connection));
    }

    protected function deleteTableSuccess(string $tableName, $connection)
    {
        try {
            $connection->createCommand()->dropTable($tableName)->execute();
        } catch (\yii\db\Exception $e) {
            return false;
        }
        return true;
    }
}