floor12 / yii2-module-backup

src/models/Backup.php

<?php
/**
 * Created by PhpStorm.
 * User: floor12
 * Date: 17.09.2018
 * Time: 23:10
 */

namespace floor12\backup\models;


use Yii;
use yii\db\ActiveRecord;

/**
 * Class Backup
 * @package floor12\backup\models
 * @property integer $id
 * @property integer $status
 * @property integer $type
 * @property integer $size
 * @property string $config_id
 * @property string $config_name
 * @property string $date
 * @property string $filename
 * @property string $fullPath
 */
class Backup extends ActiveRecord
{

    const EXT_DUMP = 'dump';
    const EXT_TGZ = 'gz';
    const EXT_ZIP = 'zip';

    public static function getDb()
    {
        return Yii::$app->getModule('backup')->connection;
    }

    /**
     * @inheritdoc
     */
    public static function tableName()
    {
        return 'backup';
    }

    /**
     * @inheritdoc
     */
    public function attributeLabels()
    {
        return [
            'date' => Yii::t('app.f12.backup', 'Date'),
            'config_id' => Yii::t('app.f12.backup', 'Config'),
            'type' => Yii::t('app.f12.backup', 'Backup type'),
            'filename' => Yii::t('app.f12.backup', 'File name'),
            'config_name' => Yii::t('app.f12.backup', 'Config name'),
            'size' => Yii::t('app.f12.backup', 'Size'),
            'status' => Yii::t('app.f12.backup', 'Status'),
        ];
    }

    /**
     * Full path to backup file on disk
     * @return string|void
     */
    public function getFullPath()
    {
        if (!$this->filename)
            return;
        return Yii::$app->getModule('backup')->backupRootPath . DIRECTORY_SEPARATOR . $this->filename;

Are you sure Yii::app->getModule('backup')->backupRootPath of type mixed|null|object can be used in concatenation?

    }

    /**
     * Backup file size updating
     * @return void
     */
    public function updateFileSize()
    {
        $this->size = 0;
        if (file_exists($this->getFullPath()))
            $this->size = filesize($this->getFullPath());
    }

    /**
     * Delete file from disk
     * @return void
     */
    public function afterDelete()
    {
        @unlink($this->getFullPath());

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

        parent::afterDelete();
    }
}