floor12\backup\tests\unit\BackupCreateTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	testDatabaseSuccess()	0	14	1
A	testEmptyConfigs()	0	7	1
A	testWrongConfigName()	0	6	1
A	testFolderSuccess()	0	14	1

<?php
/**
 * Created by PhpStorm.
 * User: floor12
 * Date: 11.11.2019
 * Time: 07:45
 */

namespace floor12\backup\tests\unit;

/**
 * This is a tests for Backup class
 */

use floor12\backup\logic\BackupCreate;
use floor12\backup\models\Backup;
use floor12\backup\models\BackupType;
use floor12\backup\tests\MysqldumpMock;
use floor12\backup\tests\TestCase;
use Yii;
use yii\base\InvalidConfigException;

class BackupCreateTest extends TestCase
{

    public function testEmptyConfigs()
    {
        $this->expectException(InvalidConfigException::class);
        $this->module->configs = [];
        $this->expectExceptionMessage('Backup module need to be configured with `config array`');
        $backupFilePath = Yii::getAlias('@app/tmp/sqlite.db');

The assignment to $backupFilePath is dead and can be removed.

        $creator = new BackupCreate('main');

The assignment to $creator is dead and can be removed.

    }

    public function testWrongConfigName()
    {
        $this->expectException(InvalidConfigException::class);
        $config_id = 'wrong';
        $this->expectExceptionMessage("Config `{$config_id}` not found.");
        $creator = new BackupCreate($config_id);

The assignment to $creator is dead and can be removed.

    }

    public function testDatabaseSuccess()
    {
        Backup::deleteAll();
        $this->assertEquals(0, Backup::find()->count());
        $config_id = 'main_db';
        $dumperClass = MysqldumpMock::class;
        $creator = new BackupCreate($config_id, $dumperClass);
        $creator->run();

        $backup = Backup::find()->one();
        $this->assertTrue(is_object($backup));
        $this->assertEquals(BackupType::DB, $backup->type);
        $this->assertFileExists($backup->getFullPath());
        @unlink($backup->getFullPath());

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

    }

    public function testFolderSuccess()
    {
        Backup::deleteAll();
        $this->assertEquals(0, Backup::find()->count());
        $config_id = 'tmp_folder';
        $dumperClass = MysqldumpMock::class;
        $creator = new BackupCreate($config_id, $dumperClass);
        $creator->run();

        $backup = Backup::find()->one();
        $this->assertTrue(is_object($backup));
        $this->assertEquals(BackupType::FILES, $backup->type);
        $this->assertFileExists($backup->getFullPath());
        @unlink($backup->getFullPath());

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

    }


}