floor12\backup\tests\unit\FolderBackupRestorerTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	testFileNoExists()	0	7	1
A	testFolderNoExists()	0	7	1
A	testRestoreSuccess()	0	11	1

<?php
/**
 * Created by PhpStorm.
 * User: floor12
 * Date: 11.11.2019
 * Time: 07:45
 */

namespace floor12\backup\tests\unit;

/**
 * This is a tests for Backup class
 */

use floor12\backup\logic\FolderBackupRestorer;
use floor12\backup\tests\TestCase;
use Yii;
use yii\base\Exception;

class FolderBackupRestorerTest extends TestCase
{
    public function testFolderNoExists()
    {
        $this->expectException(Exception::class);
        $this->expectExceptionMessage('Target folder don`t exist.');
        $backupFilePath = Yii::getAlias('@app/data/folder.zip');
        $targetFolder = Yii::getAlias('@app/no-exists');
        new FolderBackupRestorer($backupFilePath, $targetFolder);

It seems like $backupFilePath can also be of type false; however, parameter $backupFilePath of floor12\backup\logic\FolderBackupRestorer::__construct() does only seem to accept string, maybe add an additional type check?

It seems like $targetFolder can also be of type false; however, parameter $targetFolder of floor12\backup\logic\FolderBackupRestorer::__construct() does only seem to accept string, maybe add an additional type check?

    }

    public function testFileNoExists()
    {
        $this->expectException(Exception::class);
        $this->expectExceptionMessage('Backup file don`t exist.');
        $backupFilePath = Yii::getAlias('@app/data/no-exist.tgz');
        $targetFolder = Yii::getAlias('@app/data/');
        new FolderBackupRestorer($backupFilePath, $targetFolder);

It seems like $targetFolder can also be of type false; however, parameter $targetFolder of floor12\backup\logic\FolderBackupRestorer::__construct() does only seem to accept string, maybe add an additional type check?

It seems like $backupFilePath can also be of type false; however, parameter $backupFilePath of floor12\backup\logic\FolderBackupRestorer::__construct() does only seem to accept string, maybe add an additional type check?

    }

    public function testRestoreSuccess()
    {
        $fileFromBackup = Yii::getAlias('@app/data/exists_test_file.txt');
        $backupFilePath = Yii::getAlias('@app/data/folder.zip');
        $targetFolder = Yii::getAlias('@app/data/');
        @unlink($fileFromBackup);

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

It seems like $fileFromBackup can also be of type false; however, parameter $filename of unlink() does only seem to accept string, maybe add an additional type check?

        $this->assertFileNotExists($fileFromBackup);

It seems like $fileFromBackup can also be of type false; however, parameter $filename of PHPUnit\Framework\Assert::assertFileNotExists() does only seem to accept string, maybe add an additional type check?

        $restorer = new FolderBackupRestorer($backupFilePath, $targetFolder);

It seems like $backupFilePath can also be of type false; however, parameter $backupFilePath of floor12\backup\logic\FolderBackupRestorer::__construct() does only seem to accept string, maybe add an additional type check?

It seems like $targetFolder can also be of type false; however, parameter $targetFolder of floor12\backup\logic\FolderBackupRestorer::__construct() does only seem to accept string, maybe add an additional type check?

        $restorer->execute();
        $this->assertFileExists($fileFromBackup);

It seems like $fileFromBackup can also be of type false; however, parameter $filename of PHPUnit\Framework\Assert::assertFileExists() does only seem to accept string, maybe add an additional type check?

        @unlink($fileFromBackup);
    }


}