floor12\backup\tests\unit\BackupRestoreTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	85
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	testWrongConfigName()	0	11	1
A	testDatabaseSuccess()	0	21	1
A	testFolderSuccess()	0	18	1
A	testEmptyConfigs()	0	11	1

<?php
/**
 * Created by PhpStorm.
 * User: floor12
 * Date: 11.11.2019
 * Time: 07:45
 */

namespace floor12\backup\tests\unit;

/**
 * This is a tests for Backup class
 */

use ErrorException;
use floor12\backup\Exceptions\ModuleNotConfiguredException;
use floor12\backup\logic\BackupRestore;
use floor12\backup\models\Backup;
use floor12\backup\models\BackupStatus;
use floor12\backup\models\BackupType;
use floor12\backup\tests\TestCase;
use Yii;
use yii\base\InvalidConfigException;

class BackupRestoreTest extends TestCase
{
    /**
     * @throws ErrorException
     * @throws InvalidConfigException
     */
    public function testEmptyConfigs()
    {
        $backup = new Backup([
            'status' => BackupStatus::DONE,
            'filename' => 'test.gz',
            'type' => BackupType::FILES,
            'config_id' => 'tmp_folder'
        ]);
        $this->expectException(ModuleNotConfiguredException::class);
        $this->module->configs = [];
        new BackupRestore($backup);
    }

    /**
     * @throws ErrorException
     * @throws InvalidConfigException
     */
    public function testWrongConfigName()
    {
        $config_id = 'wrong_config_id';
        $backup = new Backup([
            'status' => BackupStatus::DONE,
            'filename' => 'test.gz',
            'type' => BackupType::FILES,
            'config_id' => $config_id
        ]);
        $this->expectException(ErrorException::class);
        new BackupRestore($backup);
    }

    /**
     * @throws ErrorException
     * @throws InvalidConfigException
     */
    public function testDatabaseSuccess()
    {
        $this->module->backupFolder = '@vendor/../tests/data';
        $this->module->backupRootPath = Yii::getAlias('@vendor/../tests/data');

It seems like Yii::getAlias('@vendor/../tests/data') can also be of type false. However, the property $backupRootPath is declared as type string. Maybe add an additional type check?

        $backup = new Backup([
            'status' => BackupStatus::DONE,
            'filename' => 'postgres',
            'type' => BackupType::DB,
            'config_id' => 'postgres_db'
        ]);
        $restorer = new BackupRestore($backup);
        $restorer->run();
        $tableExists = Yii::$app->postgres->createCommand("SELECT EXISTS (

The method createCommand() does not exist on null.

               SELECT FROM information_schema.tables
               WHERE  table_schema = 'public'
                 AND    table_name   = 'test_table'
           );")->queryScalar() == 'true';
        $this->assertTrue($tableExists);
        $dropResult = Yii::$app->postgres->createCommand()->dropTable('test_table')->execute();
        $this->assertEquals(0, $dropResult);
    }

    /**
     * @throws ErrorException
     * @throws InvalidConfigException
     */
    public function testFolderSuccess()
    {
        $this->module->backupFolder = '@vendor/../tests/data';
        $this->module->backupRootPath = Yii::getAlias('@vendor/../tests/data');

It seems like Yii::getAlias('@vendor/../tests/data') can also be of type false. However, the property $backupRootPath is declared as type string. Maybe add an additional type check?

        $resultFilePath = Yii::getAlias('@app/data/folder_for_backup/exists_test_file.txt');
        @unlink($resultFilePath);

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

It seems like $resultFilePath can also be of type false; however, parameter $filename of unlink() does only seem to accept string, maybe add an additional type check?

        $this->assertFileNotExists($resultFilePath);

It seems like $resultFilePath can also be of type false; however, parameter $filename of PHPUnit\Framework\Assert::assertFileNotExists() does only seem to accept string, maybe add an additional type check?

        $backup = new Backup([
            'status' => BackupStatus::DONE,
            'filename' => 'folder.zip',
            'type' => BackupType::FILES,
            'config_id' => 'backup_test_folder'
        ]);
        $restorer = new BackupRestore($backup);
        $restorer->run();
        $this->assertFileExists($resultFilePath);

It seems like $resultFilePath can also be of type false; however, parameter $filename of PHPUnit\Framework\Assert::assertFileExists() does only seem to accept string, maybe add an additional type check?

        @unlink($resultFilePath);
    }


}