floor12 / dalli-api

src/OrderStatusDispatcher.php

<?php


namespace floor12\DalliApi;


use Exception;
use floor12\DalliApi\Enum\DalliOrderStatus;
use floor12\DalliApi\Models\Item;
use floor12\DalliApi\Models\Response\DalliOrderStatusEvent;

class OrderStatusDispatcher
{
    /** @var Item[] */
    protected $items = [];
    /** @var string */
    private $xmlBody;

The private property $xmlBody is not used, and could be removed.

    /** @var int|null */
    private $statusTimestamp;

The private property $statusTimestamp is not used, and could be removed.

    /** @var string|null */
    private $statusName;

The private property $statusName is not used, and could be removed.

    /** @var string|null */
    private $statusId;

The private property $statusId is not used, and could be removed.

    /** @var string */
    private $paymentType;

The private property $paymentType is not used, and could be removed.

    /** @var string */
    private $deliveredTo;

The private property $deliveredTo is not used, and could be removed.

    /** @var string */
    private $externalBarCode;
    /**
     * @var \$1|false|\SimpleXMLElement

The type $1 was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    private $xml;
    /**
     * @var DalliOrderStatusEvent[]
     */
    private $statuses;

    /**
     * @param string $xmlBody
     * @throws Exception
     */
    public function __construct(string $xmlBody)
    {
        $this->xml = simplexml_load_string($xmlBody);
        if ($this->xml === false)
            throw new Exception('XML body is not valid.');
        if ($this->xml->order) {

            foreach ($this->xml->order->statushistory->status as $statusItem) {
                $this->statuses[] = new DalliOrderStatusEvent(
                    trim($statusItem[0]),
                    $statusItem['eventstore'],
                    strtotime($statusItem['eventtime']));
            }

            foreach ($this->xml->order->items->item as $item) {
                $orderItem = new Item();
                $orderItem->setBarcode((string)$item['barcode'])
                    ->setQuantity((int)$item['quantity'])
                    ->setReturn(boolval($item['returns']))
                    ->setRetprice((float)$item['retprice']);
                $this->items[$orderItem->_barcode] = $orderItem;
            }
        }
    }

    /**
     * @param string|int $barcode
     * @return bool|null
     */
    public function isItemReturned($barcode): ?bool
    {
        if (isset($this->items[$barcode]))
            return $this->items[$barcode]->isReturned();
        return null;
    }

    public function getStatusId(): ?string
    {
        if ($this->statuses) {

The expression $this->statuses of type floor12\DalliApi\Models\Response\DalliOrderStatusEvent[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $this->statuses[0]->getStatusId();
        }
        return null;
    }

    public function getStatusName(): ?string
    {
        if ($this->getStatusId())
            DalliOrderStatus::getLabel($this->getStatusId());
        return null;
    }

    public function getStatusTimestamp(): ?int
    {
        if ($this->statuses) {

The expression $this->statuses of type floor12\DalliApi\Models\Response\DalliOrderStatusEvent[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $this->statuses[0]->getTimestamp();
        }
        return null;
    }

    public function getItems(): array
    {
        return $this->items;
    }

    /**
     * @return Item[]
     */
    public function getReturnedItems(): array
    {
        $returned = [];
        foreach ($this->items as $item) {
            if ($item->isReturned())
                $returned[] = $item;
        }
        return $returned;
    }

    public function getOrderHistory(): ?array
    {
        return $this->statuses;
    }

    public function getStatuses(): array
    {
        return $this->statuses;
    }

    public function getExternalBarCode()
    {
        return $this->externalBarCode;
    }
}