Item - Code Metrics - Inspection of "Government code added to order item." - floor12/dalli-api - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 8b743f...e448f9 )

by Evgenii

created 2022-01-10 17:49 UTC

Item A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	112
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
eloc	27
dl	0
loc	112
ccs	23
cts	23
cp	1
rs	10
c	3
b	0
f	1
wmc	10

9 Methods

Rating	Name	Size	Complexity
A	setBarcode()	4	1
A	setTitle()	4	1
A	setQuantity()	4	1
A	setWeight()	4	1
A	setReturn()	4	1
A	setRetprice()	4	1
A	isReturned()	3	1
A	setGovernmentCode()	6	2
A	setArticle()	4	1

<?php


namespace floor12\DalliApi\Models;


class Item extends BaseXmlObject
{
    /** @var string */
    public $title;
    /** @var int */
    public $_quantity = 1;
    /** @var float */
    public $_weight;
    /** @var float */
    public $_retprice;
    /** @var int */
    public $_barcode;
    /** @var string */
    public $_article;
    /** @var bool|null */
    public $_return;
    /** @var string|null */
    public $_governmentCode;


    /**
     * @param int $quantity
     * @return Item
     */
    public function setQuantity(int $quantity)
    {
        $this->_quantity = $quantity;
        return $this;
    }

    /**
     * @param float $_weight
     * @return Item
     * @return Item
     */
    public function setWeight(float $_weight)
    {
        $this->_weight = $_weight;
        return $this;
    }

    /**
     * @param float $retprice
     * @return Item
     * @return Item
     */
    public function setRetprice(float $retprice)
    {
        $this->_retprice = $retprice;
        return $this;
    }

    /**
     * @param string $_barcode
     * @return Item
     * @return Item
     */
    public function setBarcode(string $_barcode)
    {
        $this->_barcode = $_barcode;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        return $this;
    }

    /**
     * @param string $_article
     * @return Item
     * @return Item
     */
    public function setArticle(string $_article)
    {
        $this->_article = $_article;
        return $this;
    }

    /**
     * @param string $title
     * @return self
     */
    public function setTitle(string $title): self
    {
        $this->title = $title;
        return $this;
    }

    /**
     * @param bool $return
     * @return self;
     */
    public function setReturn(bool $return): self
    {
        $this->_return = $return;
        return $this;
    }

    /**
     * @return bool|null
     */
    public function isReturned(): ?bool
    {
        return $this->_return;
    }

    /**
     * @param string $code
     * @return self;
     */
    public function setGovernmentCode(string $code): self
    {
        if ($code) {
            $this->_governmentCode = $code;
        }
        return $this;
    }
}


1		<?php
2
3
4		namespace floor12\DalliApi\Models;
5
6
7		class Item extends BaseXmlObject
8		{
9		/** @var string */
10		public $title;
11		/** @var int */
12		public $_quantity = 1;
13		/** @var float */
14		public $_weight;
15		/** @var float */
16		public $_retprice;
17		/** @var int */
18		public $_barcode;
19		/** @var string */
20		public $_article;
21		/** @var bool\|null */
22		public $_return;
23		/** @var string\|null */
24		public $_governmentCode;
25
26
27		/**
28		* @param int $quantity
29	2	* @return Item
30		*/
31	2	public function setQuantity(int $quantity)
32	2	{
33		$this->_quantity = $quantity;
34		return $this;
35		}
36
37		/**
38		* @param float $_weight
39		* @return Item
40	2	* @return Item
41		*/
42	2	public function setWeight(float $_weight)
43	2	{
44		$this->_weight = $_weight;
45		return $this;
46		}
47
48		/**
49		* @param float $retprice
50		* @return Item
51	2	* @return Item
52		*/
53	2	public function setRetprice(float $retprice)
54	2	{
55		$this->_retprice = $retprice;
56		return $this;
57		}
58
59		/**
60		* @param string $_barcode
61		* @return Item
62	5	* @return Item
63		*/
64	5	public function setBarcode(string $_barcode)
65	5	{
66		$this->_barcode = $_barcode;
		0 ignored issues – show Documentation Bug introduced 2020-08-09 10:40 UTC by Report Bug Copy Issue Report The property `$_barcode` was declared of type `integer`, but `$_barcode` is of type `string`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
67		return $this;
68		}
69
70		/**
71		* @param string $_article
72		* @return Item
73	1	* @return Item
74		*/
75	1	public function setArticle(string $_article)
76	1	{
77		$this->_article = $_article;
78		return $this;
79		}
80
81		/**
82		* @param string $title
83	1	* @return self
84		*/
85	1	public function setTitle(string $title): self
86	1	{
87		$this->title = $title;
88		return $this;
89		}
90
91		/**
92		* @param bool $return
93	3	* @return self;
94		*/
95	3	public function setReturn(bool $return): self
96	3	{
97		$this->_return = $return;
98		return $this;
99		}
100
101		/**
102	2	* @return bool\|null
103		*/
104	2	public function isReturned(): ?bool
105		{
106		return $this->_return;
107		}
108
109		/**
110		* @param string $code
111		* @return self;
112		*/
113		public function setGovernmentCode(string $code): self
114		{
115		if ($code) {
116		$this->_governmentCode = $code;
117		}
118		return $this;
119		}
120		}
121

floor12 / dalli-api

Push — master ( 8b743f...e448f9 )

Item A

Complexity

Size/Duplication

Test Coverage

Importance

9 Methods

Duplication Side-by-Side

Filter issues like